From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 27C17222630A7 for ; Thu, 22 Feb 2018 07:58:30 -0800 (PST) Received: by mail-wr0-x244.google.com with SMTP id n7so11116432wrn.5 for ; Thu, 22 Feb 2018 08:04:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SSZH9bUfzmjcx2sSc0nqeJm4GQl8aQkBiooeeZse/uE=; b=bmjKqHkPkDZiCT5I7hYhFC7RhqDNYiKCC6ws82r0ibHWbvnOweV0aT7Dt8YZ3V4xFK 46abq+pquhlDqoIfwavfQ4t8yZFhZe2LaonnHjzLuz8NWwDWisCb37pucAGhspcPNJE/ o1lPm1+SGPp/so+Gg13NWK/d22X7L5PvMYC/w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SSZH9bUfzmjcx2sSc0nqeJm4GQl8aQkBiooeeZse/uE=; b=lJa9SAze8R5rRTFpoHRLQUzF8n+3dTokTczW1yB4CMF5ddGFcSSoyITJTyTHY85HS5 064u5iDlaxomHZ5IH/k1vqXwXYNy4JOpG1DHXOhaFuuQ4FRB3pVAROC6eBbnw1bnVE8o geohbEThwzE+YiaIBIc3vs5p0k8PLNvihRkxarzx1Ih1M3tTdvjJWcv+o7Vf0Q3xxTv7 z4hhrfkP/nIz1TDJ0iFxFSMm6bw3uv3ltE9KBwGQPb5MJ7L84Wfi7pe3Ev5xJy1YAXcp gzZIAB6B1fVYgNJZbrRtPlEzeuA6LhlK15StjCNisypucCeB5uifPGlmxYKgZU3t6XHO jPzA== X-Gm-Message-State: APf1xPDca+zyt8OpAP5JwCX8bG1TqpXUDMOnPfkZL20xJ98+N2SqVgE2 a6ycp1nlt/Tco2JfZLtNIEpRBvEfWj8= X-Google-Smtp-Source: AH8x226QZXejYM839OdkiV5AtMFC+toNr7c1zkbRUxCvaePmpTdTRmB8XgPkoWy/P0OE6RqQdHWwBQ== X-Received: by 10.223.150.102 with SMTP id c35mr6730097wra.225.1519315470312; Thu, 22 Feb 2018 08:04:30 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f23sm547915wrf.77.2018.02.22.08.04.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Feb 2018 08:04:29 -0800 (PST) Date: Thu, 22 Feb 2018 16:04:27 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20180222160427.pcvfevuosaf3efja@bivouac.eciton.net> References: <20180220174944.525-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180220174944.525-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 0/7] Add Secure96 mezzanine support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 15:58:31 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline So, the ones I haven't commented on in this series, I'm happy with, but since there may be non-trivial refactoring I'm not posting R-b on yet. On Tue, Feb 20, 2018 at 05:49:37PM +0000, Ard Biesheuvel wrote: > Almost a complete rewrite of the v1. I omitted the patches that add SPI > and I2C DT nodes to the SynQuacer DTS. I did include the v2 of the Atmel > AtSha204a driver, since the latter patches depend on it. > > This version implements a complete split between the generic 96boards > LS connector support and its associated plumbing (defining which I2C, > SPI and GPIO controllers are connected) on the one hand, and support > for the Secure96 mezzanine board in particular on the other. More > specifically, all Secure96 PCDs were dropped, and the only platform > specific configuration that remains is including the Secure96 driver > and the driver for its peripherals to the build. > > Patch #1 is v2 of the AtSha204a driver, with Leif's review comments > addressed. > > Patch #2 introduces the mezzanine protocol, which abstracts away from > any particular mezzanine implementation. > > Patch #3 introduces the generic I2C plumbing for any mezzanine that exposes > I2C peripherals. > > Patch #4 implements the protocol that asserts the presence of a 96boards LS > connector and the type of mezzanine connected to it. > > Patch #5 adds the Secure96 driver, which incorporates the DT overlay, and > a description of the I2C peripheral. > > Patch #6 adds a generic driver for configuring the type of mezzanine, and > to interface with it at end of DXE time to install the appropriate DT > overlay. > > Patch #7 wires everything up for the DeveloperBox platform. > > Ard Biesheuvel (7): > Silicon/Atmel: add support for AtSha204a RNG > Platform/NinetySixBoards: introduce package and mezzanine protocol > Platform/NinetySixBoards: introduce I2C driver > Platform/NinetySixBoards: introduce LsConnector protocol > Platform/NinetySixBoards: add a driver for the Secure96 mezzanine > board > Platform/NinetySixBoards: add core driver for LS connector and config > Platform/Socionext/DeveloperBox: add 96boards mezzanine support > > Platform/NinetySixBoards/Include/Guid/FormSet.h | 23 ++ > Platform/NinetySixBoards/Include/Protocol/LsConnector.h | 35 +++ > Platform/NinetySixBoards/Include/Protocol/Mezzanine.h | 71 +++++ > Platform/NinetySixBoards/NinetySixBoards.dec | 73 +++++ > Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.c | 221 ++++++++++++++ > Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.h | 32 ++ > Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.inf | 57 ++++ > Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsHii.uni | 27 ++ > Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsHii.vfr | 51 ++++ > Platform/NinetySixBoards/NinetySixBoardsI2cDxe/NinetySixBoardsI2cDxe.c | 202 +++++++++++++ > Platform/NinetySixBoards/NinetySixBoardsI2cDxe/NinetySixBoardsI2cDxe.inf | 51 ++++ > Platform/NinetySixBoards/Secure96Dxe/Secure96.dts | 76 +++++ > Platform/NinetySixBoards/Secure96Dxe/Secure96.h | 26 ++ > Platform/NinetySixBoards/Secure96Dxe/Secure96Dxe.c | 211 +++++++++++++ > Platform/NinetySixBoards/Secure96Dxe/Secure96Dxe.inf | 67 +++++ > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 34 +++ > Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 10 + > Silicon/Atmel/AtSha204a/AtSha204a.dec | 22 ++ > Silicon/Atmel/AtSha204a/AtSha204aDriver.c | 309 ++++++++++++++++++++ > Silicon/Atmel/AtSha204a/AtSha204aDriver.h | 81 +++++ > Silicon/Atmel/AtSha204a/AtSha204aDxe.inf | 52 ++++ > Silicon/Atmel/AtSha204a/ComponentName.c | 186 ++++++++++++ > Silicon/Atmel/AtSha204a/DriverBinding.c | 242 +++++++++++++++ > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c | 9 + > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 2 + > 25 files changed, 2170 insertions(+) > create mode 100644 Platform/NinetySixBoards/Include/Guid/FormSet.h > create mode 100644 Platform/NinetySixBoards/Include/Protocol/LsConnector.h > create mode 100644 Platform/NinetySixBoards/Include/Protocol/Mezzanine.h > create mode 100644 Platform/NinetySixBoards/NinetySixBoards.dec > create mode 100644 Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.c > create mode 100644 Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.h > create mode 100644 Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.inf > create mode 100644 Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsHii.uni > create mode 100644 Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsHii.vfr > create mode 100644 Platform/NinetySixBoards/NinetySixBoardsI2cDxe/NinetySixBoardsI2cDxe.c > create mode 100644 Platform/NinetySixBoards/NinetySixBoardsI2cDxe/NinetySixBoardsI2cDxe.inf > create mode 100644 Platform/NinetySixBoards/Secure96Dxe/Secure96.dts > create mode 100644 Platform/NinetySixBoards/Secure96Dxe/Secure96.h > create mode 100644 Platform/NinetySixBoards/Secure96Dxe/Secure96Dxe.c > create mode 100644 Platform/NinetySixBoards/Secure96Dxe/Secure96Dxe.inf > create mode 100644 Silicon/Atmel/AtSha204a/AtSha204a.dec > create mode 100644 Silicon/Atmel/AtSha204a/AtSha204aDriver.c > create mode 100644 Silicon/Atmel/AtSha204a/AtSha204aDriver.h > create mode 100644 Silicon/Atmel/AtSha204a/AtSha204aDxe.inf > create mode 100644 Silicon/Atmel/AtSha204a/ComponentName.c > create mode 100644 Silicon/Atmel/AtSha204a/DriverBinding.c > > -- > 2.11.0 >