public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: "Zeng, Star" <star.zeng@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH v2 1/3] MdePkg: restrict UefiMultiPhase.h contents if VFRCOMPILE defined
Date: Fri, 23 Feb 2018 11:40:54 +0000	[thread overview]
Message-ID: <20180223114054.46iqnva4x4kztky6@bivouac.eciton.net> (raw)
In-Reply-To: <ab3b4048-a413-ae24-f396-f3bc8f76b28d@intel.com>

On Fri, Feb 23, 2018 at 10:33:46AM +0800, Zeng, Star wrote:
> Leif,
> 
> On 2018/2/23 4:09, Leif Lindholm wrote:
> > Hi Star,
> > 
> > I lost track of this one during my sabbatical until Ard's patch
> > earlier today jogged my memory.
> > 
> > On Sun, Dec 17, 2017 at 11:23:10AM +0000, Zeng, Star wrote:
> > > You may submit a bugzilla for the long term approach as Liming
> > > suggested in V1 patch series, and then add the bug link in this
> > > commit log?
> > 
> > I have raised https://bugzilla.tianocore.org/show_bug.cgi?id=878
> > for the enhancement.
> > 
> > Are you OK with the patch as below (it rebases cleanly to current
> > master) if I add the paragraph:
> > ---
> > https://bugzilla.tianocore.org/show_bug.cgi?id=878 has been raised to
> > request VfrCompile is extended to support the original format.
> > ---
> > to the end of the commit message?
> 
> I am ok. With this update, Reviewed-by: Star Zeng <star.zeng@intel.com>.

Thanks!

> I have given RB to MdeModulePkg change before. :)

Yup.

> You may also get opinion from Mike and Liming.

Of course.

/
    Leif


  parent reply	other threads:[~2018-02-23 11:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 16:59 [PATCH v2 0/3] Use central definitions for EFI_VARIABLE_* Leif Lindholm
2017-12-15 16:59 ` [PATCH v2 1/3] MdePkg: restrict UefiMultiPhase.h contents if VFRCOMPILE defined Leif Lindholm
2017-12-17 11:23   ` Zeng, Star
2018-02-22 20:09     ` Leif Lindholm
2018-02-23  2:33       ` Zeng, Star
2018-02-23 10:25         ` Gao, Liming
2018-02-23 14:24           ` Leif Lindholm
2018-02-23 11:40         ` Leif Lindholm [this message]
2017-12-15 16:59 ` [PATCH v2 2/3] MdeModulePkg: use central variable definitions in DriverSampleDxe Leif Lindholm
2017-12-17 11:20   ` Zeng, Star
2017-12-15 16:59 ` [PATCH v2 3/3] EmbeddedPkg: use central variable definitions in .vfr files Leif Lindholm
2018-02-22 16:33   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180223114054.46iqnva4x4kztky6@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox