From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::234; helo=mail-wr0-x234.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x234.google.com (mail-wr0-x234.google.com [IPv6:2a00:1450:400c:c0c::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 76B3922436936 for ; Fri, 23 Feb 2018 03:34:57 -0800 (PST) Received: by mail-wr0-x234.google.com with SMTP id f14so13760423wre.8 for ; Fri, 23 Feb 2018 03:40:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OFQSi3BVwKePXmXuoISOw8FQh+04gOuDJ5TUT9S/j0E=; b=GdNeuDjp3GjhSyblnxcI6GW0w8CS8iZLPFgCuAkg0wRHJGRhP8DIEl/CQpXAGUlxkJ CFifUfY6GxyscYtdfuC0tx1JzA6mFqpUB5YEED6Vv8GppBghhSujuCw1SZ5X6rddfnCn bgvhcsJWUZaQ6k3ihstN9ulYtTRIgdFEZyOCI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OFQSi3BVwKePXmXuoISOw8FQh+04gOuDJ5TUT9S/j0E=; b=Zc79+F5AP2e4YO64MOnetd13ghEud0BZvgNix5etuMby+kHjFzvomYygU9bd6hvOvQ OeK6RsAs7XMtOXR9Qvx75RtPwbK0AsJzsBysMHiU9AQlMmTEbZtOIKHn2UDEnGJtUG+t wTBc7OszRX38Utz40aF/VB2BNB+OdmPsiN1oLWqCbKnF8Hj/JT8XhuEEhEBF5GSi4D/n GRKx5dMLmg/1N8qG22YFoeoTIjEkMi+ystQkaSZBNM3JAtryfY3Ls+oeKGj4+AU/0S0K IhuWYX87zs87K3wq11wUV6mFxVgNdKQsmj/VsMVvBp5qEjIF6rVc0opTJN9MwpvInuUu 4L5g== X-Gm-Message-State: APf1xPDLVAdTDgPws1h4RM/39G0fbdCM4GQ5/vp1G62koMSMq2Jlmc/8 1MEVrzJU2Hw22R4olKTFVHQUNw== X-Google-Smtp-Source: AH8x227XbbaLe6asi9hpSwkRqyQRkpe35hFaJx+J132rwvqISPgiR9FSfeI8HMbYTLHGDhl0bSbsig== X-Received: by 10.223.196.250 with SMTP id o55mr1409839wrf.200.1519386057301; Fri, 23 Feb 2018 03:40:57 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o9sm3055303wrf.43.2018.02.23.03.40.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Feb 2018 03:40:55 -0800 (PST) Date: Fri, 23 Feb 2018 11:40:54 +0000 From: Leif Lindholm To: "Zeng, Star" Cc: "Kinney, Michael D" , "edk2-devel@lists.01.org" , "Gao, Liming" Message-ID: <20180223114054.46iqnva4x4kztky6@bivouac.eciton.net> References: <20171215165925.12306-1-leif.lindholm@linaro.org> <20171215165925.12306-2-leif.lindholm@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483103B9C46A4@shsmsx102.ccr.corp.intel.com> <20180222200900.n7n3wy4dihdzlvqo@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v2 1/3] MdePkg: restrict UefiMultiPhase.h contents if VFRCOMPILE defined X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 11:34:58 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 23, 2018 at 10:33:46AM +0800, Zeng, Star wrote: > Leif, > > On 2018/2/23 4:09, Leif Lindholm wrote: > > Hi Star, > > > > I lost track of this one during my sabbatical until Ard's patch > > earlier today jogged my memory. > > > > On Sun, Dec 17, 2017 at 11:23:10AM +0000, Zeng, Star wrote: > > > You may submit a bugzilla for the long term approach as Liming > > > suggested in V1 patch series, and then add the bug link in this > > > commit log? > > > > I have raised https://bugzilla.tianocore.org/show_bug.cgi?id=878 > > for the enhancement. > > > > Are you OK with the patch as below (it rebases cleanly to current > > master) if I add the paragraph: > > --- > > https://bugzilla.tianocore.org/show_bug.cgi?id=878 has been raised to > > request VfrCompile is extended to support the original format. > > --- > > to the end of the commit message? > > I am ok. With this update, Reviewed-by: Star Zeng . Thanks! > I have given RB to MdeModulePkg change before. :) Yup. > You may also get opinion from Mike and Liming. Of course. / Leif