From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::231; helo=mail-wm0-x231.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 67F1522436929 for ; Fri, 23 Feb 2018 07:50:40 -0800 (PST) Received: by mail-wm0-x231.google.com with SMTP id t3so5518109wmc.2 for ; Fri, 23 Feb 2018 07:56:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KMIJikqX4FDJKZ3kz5Er8yukiHmkC40So6vq84AfmGU=; b=Yqnplj7sM9G1O9mKA3jO0jANJFZdog5vUEyp2un/rIXV+cqnub/FNg9fblPEvLdA+3 kNefQCoos6dpXyarZUZs6K3je9eBbPy4YW1b5jLdLjPu159qeIcpW3Fl7XatA5oDqy1K g9JnwXJhcQ7qgc9+yYDfNXueu3pLdghPts2AQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KMIJikqX4FDJKZ3kz5Er8yukiHmkC40So6vq84AfmGU=; b=Ok83bh9H6gUiDyITl5fKkaUaS8WbDLjow4+VdrYoijrA0OaYPgaHlBHi0VkG32aBE6 M1kKHrI7WEMozITrX/nRU+02+oG9lI1vfC+XJoYlIewpqKWRg4OMcBVpGGQPK4LKFZwi k2dWIkfupNbmPhDNNSnEsjFrASELrWu7IMw6hjmRiAqUf15nr2ed4Eb5TVisw9kfsW51 nBK5V/fONfLTOf3rtDdSR9oxgU5wZt48owYjD1p2+H4ZvFi7e3Yd+OQOG/jHAr7O3Z3J w5p0QRgvVfch/9tMgKHOOKtr4oq3ghG06bKeAehavFpJ8RNCp0lx8q5O9oMSmeEfntMj nhJQ== X-Gm-Message-State: APf1xPAGenNOA76lfy9nK45S+SEud2chl92p5DFCE7uIkuN+53TR82Fs uGqc10qJnY9NyX5aGPt1Nb750N3pcgM= X-Google-Smtp-Source: AG47ELtP0+utJC8PYAAaS5L3Tkdb/LTi4Ho+/I3cNctK816xfeVpanLWNpca9tVXc/VDJp5KGQXiGQ== X-Received: by 10.28.228.131 with SMTP id b125mr2009207wmh.153.1519401400770; Fri, 23 Feb 2018 07:56:40 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e67sm1974618wmd.7.2018.02.23.07.56.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Feb 2018 07:56:39 -0800 (PST) Date: Fri, 23 Feb 2018 15:56:38 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20180223155638.72ef2rrv5r2wmeqj@bivouac.eciton.net> References: <20180223154052.9828-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180223154052.9828-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v3 0/6] Add Secure96 mezzanine support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 15:50:40 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 23, 2018 at 03:40:46PM +0000, Ard Biesheuvel wrote: > This v3 (as did v2) implements a complete split between the generic > 96boards LS connector support and its associated plumbing (defining which > I2C, SPI and GPIO controllers are connected) on the one hand, and support > for the Secure96 mezzanine board in particular on the other. More > specifically, all Secure96 PCDs were dropped, and the only platform > specific configuration that remains is including the Secure96 driver > and the driver for its peripherals to the build. > > v3: > - The ATSHA204A driver has been merged, so it has been dropped from this > series. > - Rename Platform/NinetySixBoards back to Platform/96Boards. Note that in > some places, using leading digits is problematic so the string does still > occur in a couple of places. > - Rebase onto EDK2 that has the MultiPhase.h VFR changes. All of my feedback has been addressed, so for the series: Reviewed-by: Leif Lindholm If we get enum support in VfrCompile in the future, a minor cleanup to the code introduced by 5/6 will be possible, but this is an excellent start to a generic mezzanine infrastructure - thanks!