From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c05::242; helo=mail-pg0-x242.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg0-x242.google.com (mail-pg0-x242.google.com [IPv6:2607:f8b0:400e:c05::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9ED382034D8F7 for ; Mon, 26 Feb 2018 17:44:35 -0800 (PST) Received: by mail-pg0-x242.google.com with SMTP id g12so6932459pgs.0 for ; Mon, 26 Feb 2018 17:50:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=D1Gc4NMsdujpIUNZcLBkZi2aSPpwKX19LVh8TXJ/5Wg=; b=K7bvUd4X1kMOXSG92McD43pkiYOxKQERJnQTa86H2DF3bCRLTUclElrVBKK1wcobJ/ 10ReC67MUvx7iaQ29ZcPGSIUbYuqP1aCkaCaebvGkS5POeLZNVSXFVOG1DVCoDr7Bnqo fCc/tV4mHz42dX5qmen30DPOX2K/jyUzpA8qQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=D1Gc4NMsdujpIUNZcLBkZi2aSPpwKX19LVh8TXJ/5Wg=; b=oA7/i1/oOAbYvfPdFZWAdmkdI0XTM+0xPlX8hPCEs4VKTNERS5/XeDaeU3gSrTWY/u bUXjUu4MaeuxTraLFtHB1NNhQ03+3qiMtiyfaE3h+rFEDvXciv0dnP2rCYtzuu9fMJEX CldL3LdgxFwKk00gyCxe259Y3J684seHW0TtK7zQPqDzDnNCWMOoJFDlq0sray1uMdrG jaqAK0P3G/JL8L1dqre2rgwLvqOCrk7+D8WFgEiXaEMHeJ0QcAi+Aox58I5GfsxVuKfU xADeSt2hV0WS96vKFRfXz70Q8eVmU8UzG1TAwnx3OGBA9VcjRN9I777uJbdXbbmOQ2/7 r0Mg== X-Gm-Message-State: APf1xPDxXaEeIfkP2EAMbpJQMisxzEdMG71jYX9VjGO4zZwqqd7AqIs3 7TL7B9IFTmM8tIhBBKWr36354g== X-Google-Smtp-Source: AH8x224KZbMn93nzwwuKM4S+fN00B80mwNk/kdWIGpponhARhxj7zLB8coe0ahjDOZsbRTqXx8kbOg== X-Received: by 10.99.8.4 with SMTP id 4mr10043570pgi.289.1519696240559; Mon, 26 Feb 2018 17:50:40 -0800 (PST) Received: from SZX1000114654 ([104.237.91.49]) by smtp.gmail.com with ESMTPSA id a14sm7383733pff.75.2018.02.26.17.50.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Feb 2018 17:50:40 -0800 (PST) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Tue, 27 Feb 2018 09:50:36 +0800 To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, lersek@redhat.com, leif.lindholm@linaro.org Message-ID: <20180227015036.GC2261@SZX1000114654> References: <20180224142515.461-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180224142515.461-1-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 01:44:36 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Ard, Sorry for the late of seeing this patch. I have one question: why don't we implement a runtime serial port lib, which will switch UART base address in virtual address map change? I think this will be useful when we want to debug runtime driver in OS stage. And if we have a runtime version of SerialPortLib, then we don't need a runtime version of DebugLib which just disable touching serial port. Thanks, Heyi On Sat, Feb 24, 2018 at 02:25:14PM +0000, Ard Biesheuvel wrote: > Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more > debug message") broke the DEBUG build for all platforms that rely on > MMIO mapped UART devices, since it introduces a DEBUG() print that > may trigger at runtime, at which such UART devices are usually not > mapped, resulting in an OS crash. > > Given that this mostly only affects ARM and AARCH64, it is not unlikely > that similar inadvertent breakage will occur again in the future, so > let's fix this once and for all by switching affected platforms to the > new DxeRuntimeDebugLibSerialPort DebugLib implementation that takes care > not to touch the UART hardware after ExitBootServices(). > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 +++ > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 3 +++ > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 3 +++ > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 3 +++ > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 3 +++ > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 +++ > Silicon/Hisilicon/Hisilicon.dsc.inc | 3 +++ > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++ > 8 files changed, 24 insertions(+) > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > index 7d85b78642da..348828e18d44 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -227,6 +227,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.common.UEFI_APPLICATION] > UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index b026ce3a420a..7cb47937329e 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -227,6 +227,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > !if $(SECURE_BOOT_ENABLE) == TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > !endif > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.ARM, LibraryClasses.AARCH64] > # > diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > index 2468583c0daa..569e444f6b26 100644 > --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc > +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > @@ -211,6 +211,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.common.UEFI_APPLICATION] > UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > index 8450d7800e43..925ce36d278b 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > @@ -208,6 +208,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > ################################################################################ > # > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > index 45ab2afc4069..2d5a94ed1dab 100644 > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > @@ -203,6 +203,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > ################################################################################ > # > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > index f0a7e9794153..3f4c7c8a3eef 100644 > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > @@ -217,6 +217,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.common.UEFI_APPLICATION] > UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf > diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc > index 9050f29be381..b196322a20e2 100644 > --- a/Silicon/Hisilicon/Hisilicon.dsc.inc > +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc > @@ -213,6 +213,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > !ifndef CONFIG_NO_DEBUGLIB > DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > !endif > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.AARCH64] > ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > index ef70b5216727..535cc3ff4c19 100644 > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > @@ -184,6 +184,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.ARM, LibraryClasses.AARCH64] > # > -- > 2.11.0 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel