From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A7FD6209574C6 for ; Tue, 27 Feb 2018 02:33:01 -0800 (PST) Received: by mail-wr0-x241.google.com with SMTP id l43so24346847wrc.2 for ; Tue, 27 Feb 2018 02:39:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=swp5KZNT4G3GquGTDiNIBLR8EivZBxK6uzkxcsZ8bHQ=; b=c7twVNwHHEVp7inMk/tX41psoqgsz+nU5PlMgK9ptS5USNa2YZM48uqie9mJhVryFi NpAFr6RIv8SHEz7qWiB0dNUcxRk3wohDtdhF3djdzcziZJAIjmFSJm/cqvFcGLQT4CEs NS1TDl2GagVihuwNYwVlaqx3D9v4U9xcFTV5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=swp5KZNT4G3GquGTDiNIBLR8EivZBxK6uzkxcsZ8bHQ=; b=esv9ZWvOcQBofCt4ljapQRIuf+aIFqhb7tu//hu4aZ8iA4C6BVi7ezCh+pmtkWgfsw caH5R/fXFHkRxSke5HTuhTDLnnjaF7zXzlMIDKMI4FL835rVJicRqn7+Ro4rVlv21WQx w7UaT+uPow6N+X/h2N33MYMSKBoIpj14GDbFphwJ53/+W2x/dlQb48PJi9i/Vv2PKUUl hYaX53ohkMsnxZh1Wt/BUUPvbBc4ANfP3CjwAfXdoyxdCnD1+kPWq58criSLpB9CWKu9 A4bu+SysQip1PdnHwHzi2vGLc/L2utf2dXsuThLZgbe5bo6y3MxVTuR2A1t37OlODAr6 Z4Hg== X-Gm-Message-State: APf1xPCwonEhWEfWoCa1JA0Lki8DFwaZbvoMrKTE+vY3qlImmCd2dx1M jhvnZCHT8lwLSPbeEK7Fq2Je1O0xRBs= X-Google-Smtp-Source: AH8x226EcodO15R6Kya2Gk43Ues2iEllxmgLWteW3X4j31Tr5/jY2xx8DjaHMLi95jU4zky/YUGfDg== X-Received: by 10.223.179.194 with SMTP id x2mr13002049wrd.94.1519727946247; Tue, 27 Feb 2018 02:39:06 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o12sm14986060wrb.15.2018.02.27.02.39.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Feb 2018 02:39:05 -0800 (PST) Date: Tue, 27 Feb 2018 10:39:03 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, lersek@redhat.com Message-ID: <20180227103903.lqq6exh6jamzqkd3@bivouac.eciton.net> References: <20180224142515.461-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180224142515.461-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 10:33:02 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Feb 24, 2018 at 02:25:14PM +0000, Ard Biesheuvel wrote: > Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more > debug message") broke the DEBUG build for all platforms that rely on > MMIO mapped UART devices, since it introduces a DEBUG() print that > may trigger at runtime, at which such UART devices are usually not > mapped, resulting in an OS crash. > > Given that this mostly only affects ARM and AARCH64, it is not unlikely > that similar inadvertent breakage will occur again in the future, so > let's fix this once and for all by switching affected platforms to the > new DxeRuntimeDebugLibSerialPort DebugLib implementation that takes care > not to touch the UART hardware after ExitBootServices(). > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel For the series (pending DxeRuntimeDebugLibSerialPort hitting edk2): Reviewed-by: Leif Lindholm > --- > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 +++ > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 3 +++ > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 3 +++ > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 3 +++ > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 3 +++ > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 +++ > Silicon/Hisilicon/Hisilicon.dsc.inc | 3 +++ > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++ > 8 files changed, 24 insertions(+) > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > index 7d85b78642da..348828e18d44 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -227,6 +227,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.common.UEFI_APPLICATION] > UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index b026ce3a420a..7cb47937329e 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -227,6 +227,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > !if $(SECURE_BOOT_ENABLE) == TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > !endif > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.ARM, LibraryClasses.AARCH64] > # > diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > index 2468583c0daa..569e444f6b26 100644 > --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc > +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > @@ -211,6 +211,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.common.UEFI_APPLICATION] > UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > index 8450d7800e43..925ce36d278b 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > @@ -208,6 +208,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > ################################################################################ > # > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > index 45ab2afc4069..2d5a94ed1dab 100644 > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > @@ -203,6 +203,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > ################################################################################ > # > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > index f0a7e9794153..3f4c7c8a3eef 100644 > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > @@ -217,6 +217,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.common.UEFI_APPLICATION] > UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf > diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc > index 9050f29be381..b196322a20e2 100644 > --- a/Silicon/Hisilicon/Hisilicon.dsc.inc > +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc > @@ -213,6 +213,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > !ifndef CONFIG_NO_DEBUGLIB > DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > !endif > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.AARCH64] > ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > index ef70b5216727..535cc3ff4c19 100644 > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > @@ -184,6 +184,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.ARM, LibraryClasses.AARCH64] > # > -- > 2.11.0 >