From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::233; helo=mail-wr0-x233.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x233.google.com (mail-wr0-x233.google.com [IPv6:2a00:1450:400c:c0c::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC5E220954CCE for ; Tue, 27 Feb 2018 10:04:20 -0800 (PST) Received: by mail-wr0-x233.google.com with SMTP id v111so13616957wrb.3 for ; Tue, 27 Feb 2018 10:10:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Z9wg47siA1Ep98c1XeJn2SrSBJJuw2JTLgO9MEhXzjI=; b=RJJoDLuZSp7btN9Y4LMdEtrFGpWmip6MKrcpUDCUnomiJFoFDN1jjL9sVxFCL6eCfg 0Tqd7Imt3p1Rg6cb7okiMKkHDhGhogH4lrIlTUPPpVDlXQVIu3hh5JlA2+jskG5BU2C8 mkAXV7WYyabex8EoHJh8vp8/J1QLV3D9m36FQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Z9wg47siA1Ep98c1XeJn2SrSBJJuw2JTLgO9MEhXzjI=; b=koksImOf28vNIJAmGxLgMvLGz+f4D93anpXMpYuFmK0W3DgmN7tnIcXF5sfDCQsaiK tkufDHZvv2O9FIcwBLDOSY5H0mFMaXhU3XNk0qqTBMsxwR/avUnoENjlgb/FusrQVdke 5DYfYvtdPXIcsMSYhhE+4wOnBtK/SBtIlsRL4njVWgcKQ8yzcMSxDQ6/trYtFpHjYK43 ils1uxqbQKhGD8zx0H3SiOi7eF2i0ibIp+mMiudZJDnCVfkn4XCSreVsCSadsQRGhRn+ a2nOY+iruS8Ngh/IxJOmM5khIMZMdl9oGaVx2huugWHv40L/i8AdWbnmnAqXqcVwF6xj +cBQ== X-Gm-Message-State: APf1xPDWjthC30JZlm6O98+qVzlVSyOw5uSAboGIkfO4QcT5Ua3YYQB9 COOlXFUYnPIupE9yUyhRo0PiMQ== X-Google-Smtp-Source: AH8x224j9bqb/F/zmcfrBagDqklWcaazOT7nW4Xvqeo5kjuXaYz+W3ij9Nvr8zfsNH47rH/rLsZA3Q== X-Received: by 10.223.153.51 with SMTP id x48mr12743967wrb.216.1519755025535; Tue, 27 Feb 2018 10:10:25 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l22sm14514700wre.52.2018.02.27.10.10.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Feb 2018 10:10:24 -0800 (PST) Date: Tue, 27 Feb 2018 18:10:23 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20180227181023.laplmremvchew535@bivouac.eciton.net> References: <20180227134747.13238-1-ard.biesheuvel@linaro.org> <20180227173640.vavijseacrm5wnau@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Silicon/SynQuacer: add stage 2 override translation tables for PCIe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 18:04:21 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 27, 2018 at 05:45:09PM +0000, Ard Biesheuvel wrote: > >> > +[Sources] > >> > + Stage2Tables.S > >> > + > >> > +[Packages] > >> > + MdePkg/MdePkg.dec > >> > + Silicon/Socionext/SynQuacer/SynQuacer.dec > >> > + > >> > +[BuildOptions] > >> > + *_*_*_OBJCOPY_PATH == objcopy > >> > + *_*_*_OBJCOPY_FLAGS == -I elf64-little -O binary -j .rodata > >> > >> I can improve this and fix Clang at the same time by adding > >> > >> *_*_*_ASM_FLAGS == -nostdlib > >> -Wl,-e,0x81f8000,--section-start=.rodata=0x81f8000 > >> *_CLANG35_*_ASM_FLAGS = -no-integrated-as > >> *_CLANG38_*_ASM_FLAGS = -no-integrated-as > >> > >> (and remove the linker arguments from the Makefile) > > > > I can confirm this resolves the CLANG issue. > > > > Could we do this with a CLANG_ALL_ASM_FLAGS, rather than listing each > > new toolchain profile as they get added? > > No, not really. CLANG3x is not a separate toolchain family, so we can > apply things to GCC+CLANG combined, or to certain versions > individually. Ah, I had managed to miss that bit up until now. Thanks! In that case, with these latest changes: Reviewed-by: Leif Lindholm / Leif