* [PATCH edk2-platforms] Platform/96Boards/Secure96Dxe: remove /plugin/ from .dts
@ 2018-02-27 18:26 Ard Biesheuvel
2018-02-27 20:06 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-02-27 18:26 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, Ard Biesheuvel
Even though the Secure96 device tree source is strictly an overlay, we
managed to express it in a way that does not rely on unresolved symbols
and other tricks that are only implemented in fairly recent versions of
the device tree compiler, and so adding the /plugin/ directive is not
only unnecessary, it is harmful because it is only understood by those
same recent compiler versions. So remove it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/96Boards/Secure96Dxe/Secure96.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/96Boards/Secure96Dxe/Secure96.dts b/Platform/96Boards/Secure96Dxe/Secure96.dts
index b56ce59985cc..a221bdf9bbec 100644
--- a/Platform/96Boards/Secure96Dxe/Secure96.dts
+++ b/Platform/96Boards/Secure96Dxe/Secure96.dts
@@ -22,7 +22,6 @@
#define GPIO_PARENT_PLACEHOLDER_PHANDLE 0x0
/dts-v1/;
-/plugin/;
/ {
fragment@0 {
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Platform/96Boards/Secure96Dxe: remove /plugin/ from .dts
2018-02-27 18:26 [PATCH edk2-platforms] Platform/96Boards/Secure96Dxe: remove /plugin/ from .dts Ard Biesheuvel
@ 2018-02-27 20:06 ` Leif Lindholm
2018-02-28 9:17 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2018-02-27 20:06 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Tue, Feb 27, 2018 at 06:26:19PM +0000, Ard Biesheuvel wrote:
> Even though the Secure96 device tree source is strictly an overlay, we
> managed to express it in a way that does not rely on unresolved symbols
> and other tricks that are only implemented in fairly recent versions of
> the device tree compiler, and so adding the /plugin/ directive is not
> only unnecessary, it is harmful because it is only understood by those
> same recent compiler versions. So remove it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Platform/96Boards/Secure96Dxe/Secure96.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Platform/96Boards/Secure96Dxe/Secure96.dts b/Platform/96Boards/Secure96Dxe/Secure96.dts
> index b56ce59985cc..a221bdf9bbec 100644
> --- a/Platform/96Boards/Secure96Dxe/Secure96.dts
> +++ b/Platform/96Boards/Secure96Dxe/Secure96.dts
> @@ -22,7 +22,6 @@
> #define GPIO_PARENT_PLACEHOLDER_PHANDLE 0x0
>
> /dts-v1/;
> -/plugin/;
>
> / {
> fragment@0 {
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Platform/96Boards/Secure96Dxe: remove /plugin/ from .dts
2018-02-27 20:06 ` Leif Lindholm
@ 2018-02-28 9:17 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-02-28 9:17 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On 27 February 2018 at 20:06, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Feb 27, 2018 at 06:26:19PM +0000, Ard Biesheuvel wrote:
>> Even though the Secure96 device tree source is strictly an overlay, we
>> managed to express it in a way that does not rely on unresolved symbols
>> and other tricks that are only implemented in fairly recent versions of
>> the device tree compiler, and so adding the /plugin/ directive is not
>> only unnecessary, it is harmful because it is only understood by those
>> same recent compiler versions. So remove it.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks
Pushed as f90743b8813518fd7111c272ea4a3483a94ed462
>> ---
>> Platform/96Boards/Secure96Dxe/Secure96.dts | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/Platform/96Boards/Secure96Dxe/Secure96.dts b/Platform/96Boards/Secure96Dxe/Secure96.dts
>> index b56ce59985cc..a221bdf9bbec 100644
>> --- a/Platform/96Boards/Secure96Dxe/Secure96.dts
>> +++ b/Platform/96Boards/Secure96Dxe/Secure96.dts
>> @@ -22,7 +22,6 @@
>> #define GPIO_PARENT_PLACEHOLDER_PHANDLE 0x0
>>
>> /dts-v1/;
>> -/plugin/;
>>
>> / {
>> fragment@0 {
>> --
>> 2.11.0
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-28 9:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-27 18:26 [PATCH edk2-platforms] Platform/96Boards/Secure96Dxe: remove /plugin/ from .dts Ard Biesheuvel
2018-02-27 20:06 ` Leif Lindholm
2018-02-28 9:17 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox