Re: [PATCH] EmbeddedPkg/Drivers: add virtual keyboard driver

[Leif Lindholm <leif.lindholm@linaro.org>]

On Wed, Feb 28, 2018 at 01:03:07AM +0000, Haojian Zhuang wrote:
> >> diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/ComponentName.c b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/ComponentName.c
> >> new file mode 100644
> >> index 0000000..2935307
> >> --- /dev/null
> >> +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/ComponentName.c
> >> @@ -0,0 +1,184 @@
> >> +/** @file
> >> +
> >> +Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
> >> +Copyright (c) 2018, Linaro Ltd. All rights reserved.<BR>
> >> +
> >> +This program and the accompanying materials
> >> +are licensed and made available under the terms and conditions
> >> +of the BSD License which accompanies this distribution.  The
> >> +full text of the license may be found at
> >> +http://opensource.org/licenses/bsd-license.php
> >> +
> >> +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> >> +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> >> +
> >> +**/
> >> +
> >> +#include "VirtualKeyboard.h"
> >> +
> >> +//
> >> +// EFI Component Name Protocol
> >> +//
> >> +GLOBAL_REMOVE_IF_UNREFERENCED EFI_COMPONENT_NAME_PROTOCOL  gVirtualKeyboardComponentName = {
> >> +  VirtualKeyboardComponentNameGetDriverName,
> >> +  VirtualKeyboardComponentNameGetControllerName,
> >> +  "eng"
> >> +};
> >> +
> >> +//
> >> +// EFI Component Name 2 Protocol
> >> +//
> >> +GLOBAL_REMOVE_IF_UNREFERENCED EFI_COMPONENT_NAME2_PROTOCOL gVirtualKeyboardComponentName2 = {
> >> +  (EFI_COMPONENT_NAME2_GET_DRIVER_NAME) VirtualKeyboardComponentNameGetDriverName,
> >> +  (EFI_COMPONENT_NAME2_GET_CONTROLLER_NAME) VirtualKeyboardComponentNameGetControllerName,
> >> +  "en"
> >> +};
> >> +
> >> +
> >> +GLOBAL_REMOVE_IF_UNREFERENCED EFI_UNICODE_STRING_TABLE mVirtualKeyboardDriverNameTable[] = {
> >> +  {
> >> +    "eng;en",
> >> +    L"RAM Keyboard Driver"
> > 
> > What is a RAM Keyboard Driver?
> > 
> 
> Oh, I'll rename it to Virtual Keyboard Driver for consistent.

Thanks.

> >> +  },
> > 
> > Any chance of a "zh-chs" entry?
> > 
> 
> Thanks. "zh-chs" may be inconvenient for others. "eng;en" is good for 
> everyone.

The purpose of this functionality is to provide a list with
translations of the driver name into different languages.
My request was not to use zh-chs instead of eng;en, but in addition to.

Or (according to google translate):
  {
    "eng;en",
    L"Virtual Keyboard Driver"
  },
  {
    "zh-chs".
    L"虚拟键盘驱动"
  },
  {
    NULL,
    NULL
  }
};

Best Regards,

Leif