From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::229; helo=mail-wm0-x229.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D03D2034D8C2 for ; Wed, 28 Feb 2018 05:30:56 -0800 (PST) Received: by mail-wm0-x229.google.com with SMTP id a20so26332795wmd.1 for ; Wed, 28 Feb 2018 05:37:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=C1n6FqutxBO4FlXT2reQdKjtWYfNNwgcuTAE7iIPeX8=; b=IizJ2IXjt/+J6ay3v+juvrTbf2Qo9KhXiTkwEVzKRdO+oW4heXhmqJXjBKJCcjLIDn dfIYtDO9Sw3sC5iTogvIDQ7k7RkA2/VaV7MYOn2jHwb2zm4ZG2endtVlpfBL2aUR0O0W wdMJCPK62gkgylVu7OnMrxwUQ0sist/VhHhcY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=C1n6FqutxBO4FlXT2reQdKjtWYfNNwgcuTAE7iIPeX8=; b=Cp/3nfYZNmr5UtMIuwx1QnZRPUPorkbpu4WyVnfeMU/I3L5CRbOFm5F5bHZpxpjL9f EfjUq7msDgbH9eRvxjArcVfefP1RuwmPa3oqg8JCK0oGMWkgMJU/AuM1kp6s2YjAyuCk /ADjL0V2pm6ZeCCsIvlZU8VZBOMJFNm3I/Wgr3qNqwi9ugNNhR43+oHFBx8mSu//P3Kz o+NeUwYqmVR1dBd32T2iuwmLAlEx8ZEfsEPOwx40yd1KwWHDxvrzmnqgtK0VCWz3Xdu3 8MUZzPGnzKfdkmbrho2xvtF9UoT8mdnH+hnmxA67pxOQBvX9u9bWgU5Ousuvb82aybcW HBCA== X-Gm-Message-State: APf1xPDGeWsne/4S6Zb58lC5QNLHGCUg8OV8mv/OqOyMrn3WMevsQlju 784voa0rwVgNEHku3c46LjeFIg== X-Google-Smtp-Source: AH8x226p8XtVgc10nBVC3v3DEoc9v6KmcN7Gg1llQ/73uNK2vJKPDuz3U5ANrPX+4YjpPCLsBcnLqQ== X-Received: by 10.28.52.4 with SMTP id b4mr15750782wma.90.1519825021994; Wed, 28 Feb 2018 05:37:01 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 47sm1389228wrb.48.2018.02.28.05.37.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Feb 2018 05:37:00 -0800 (PST) Date: Wed, 28 Feb 2018 13:36:59 +0000 From: Leif Lindholm To: Haojian Zhuang Cc: "ard.biesheuvel@linaro.org" , "linaro-uefi@lists.linaro.org" , "edk2-devel@lists.01.org" Message-ID: <20180228133659.xifaxc7itd5zcroj@bivouac.eciton.net> References: <1519635156-21954-1-git-send-email-haojian.zhuang@linaro.org> <20180227122847.fr2zq6nurtrlstqh@bivouac.eciton.net> <9a4bc569-d5b6-b935-fc72-2271e68a6a38@linaro.org> MIME-Version: 1.0 In-Reply-To: <9a4bc569-d5b6-b935-fc72-2271e68a6a38@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] EmbeddedPkg/Drivers: add virtual keyboard driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 13:30:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Feb 28, 2018 at 01:03:07AM +0000, Haojian Zhuang wrote: > >> diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/ComponentName.c b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/ComponentName.c > >> new file mode 100644 > >> index 0000000..2935307 > >> --- /dev/null > >> +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/ComponentName.c > >> @@ -0,0 +1,184 @@ > >> +/** @file > >> + > >> +Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.
> >> +Copyright (c) 2018, Linaro Ltd. All rights reserved.
> >> + > >> +This program and the accompanying materials > >> +are licensed and made available under the terms and conditions > >> +of the BSD License which accompanies this distribution. The > >> +full text of the license may be found at > >> +http://opensource.org/licenses/bsd-license.php > >> + > >> +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > >> +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > >> + > >> +**/ > >> + > >> +#include "VirtualKeyboard.h" > >> + > >> +// > >> +// EFI Component Name Protocol > >> +// > >> +GLOBAL_REMOVE_IF_UNREFERENCED EFI_COMPONENT_NAME_PROTOCOL gVirtualKeyboardComponentName = { > >> + VirtualKeyboardComponentNameGetDriverName, > >> + VirtualKeyboardComponentNameGetControllerName, > >> + "eng" > >> +}; > >> + > >> +// > >> +// EFI Component Name 2 Protocol > >> +// > >> +GLOBAL_REMOVE_IF_UNREFERENCED EFI_COMPONENT_NAME2_PROTOCOL gVirtualKeyboardComponentName2 = { > >> + (EFI_COMPONENT_NAME2_GET_DRIVER_NAME) VirtualKeyboardComponentNameGetDriverName, > >> + (EFI_COMPONENT_NAME2_GET_CONTROLLER_NAME) VirtualKeyboardComponentNameGetControllerName, > >> + "en" > >> +}; > >> + > >> + > >> +GLOBAL_REMOVE_IF_UNREFERENCED EFI_UNICODE_STRING_TABLE mVirtualKeyboardDriverNameTable[] = { > >> + { > >> + "eng;en", > >> + L"RAM Keyboard Driver" > > > > What is a RAM Keyboard Driver? > > > > Oh, I'll rename it to Virtual Keyboard Driver for consistent. Thanks. > >> + }, > > > > Any chance of a "zh-chs" entry? > > > > Thanks. "zh-chs" may be inconvenient for others. "eng;en" is good for > everyone. The purpose of this functionality is to provide a list with translations of the driver name into different languages. My request was not to use zh-chs instead of eng;en, but in addition to. Or (according to google translate): { "eng;en", L"Virtual Keyboard Driver" }, { "zh-chs". L"虚拟键盘驱动" }, { NULL, NULL } }; Best Regards, Leif