From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 852F322402DFE for ; Wed, 28 Feb 2018 08:11:47 -0800 (PST) Received: by mail-wr0-x244.google.com with SMTP id p104so3005941wrc.12 for ; Wed, 28 Feb 2018 08:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Sv57Yn1+zoOEevbt7wngGtME8zyaJ3jiASrsg/FSgHw=; b=gkmBVMw68cnu85/TUvhKVbI0MgI0aS1UGTlHXpL+Yy2t48tj/0Ft9BeK5Xi/KxYNiY /QE7Oleu8Eob7/nGb1Qw6sqjQNDxYTNnzaCuCc4D0Glvo68OXgpHjmlBOO1mbLi1lvF5 yvdeNp3ZQFWQv/no2NmgtOxEHnY938BCfwk38= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Sv57Yn1+zoOEevbt7wngGtME8zyaJ3jiASrsg/FSgHw=; b=cE0uZFVW/mfJqxyZ7ErLrBP3t26NgGk7jZoL+X97uQ4TlxSUWB+/Yrcwu58SN3XQ6R xJeT1asElvNAqU4zcEKuAmmN4aqgMeVN9cPZsr+fISFBzM1gvhXxv7vpt+XJgJdIuEIT IrJaT/W/P1ElDPHbxmlfrDRu/tGQJJyoHfacr+tUEi0JOUe0Z74dafVKq6qpOeW5Qwkw p7hTMdebmcadozdHTSdUgrmD4FnPIWUl0Mz2NlRtf8FZzCIKsHoE6n+Lpnlg5lXxyM9L I4ivQlRFP5uVYV95S3XkWx9MEq/9DZ7Kp87IQ61dGfKEQEbMbCMpX/Ksi8Byf2voAemK 0OpQ== X-Gm-Message-State: APf1xPBrbO5CHCzBaGxxsu2kfIY2gLL4LXvD/QM9f6C+tGrgo0EPoI1F YpEwljdXdnTxFhvbEGiup9gNIQ== X-Google-Smtp-Source: AH8x227gwzFrE9Xg2tJ2//ozeaT93zTij1ZW3lX7OZfPdiApZOuQS0uDKdq1jEeqWw9kYLr19hLXMg== X-Received: by 10.223.199.10 with SMTP id k10mr16192155wrg.186.1519834673442; Wed, 28 Feb 2018 08:17:53 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r70sm2445228wmg.30.2018.02.28.08.17.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Feb 2018 08:17:52 -0800 (PST) Date: Wed, 28 Feb 2018 16:17:50 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, graeme.gregory@linaro.org, masahisa.kojima@linaro.org Message-ID: <20180228161750.4h5fx4yxfocujfob@bivouac.eciton.net> References: <20180227092017.23617-1-ard.biesheuvel@linaro.org> <20180227092017.23617-2-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180227092017.23617-2-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 1/5] Platform/Socionext/DeveloperBox: fix PCIe slot to B/D/F mapping X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 16:11:48 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 27, 2018 at 09:20:13AM +0000, Ard Biesheuvel wrote: > Fix the static B/D/F specifiers that refer to the pair of x1 PCIe slots > on the DeveloperBox PCB. What is the user-observable problem that is addressed by this patch? > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Silicon/Socionext/SynQuacer/Include/Platform/Pcie.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Socionext/SynQuacer/Include/Platform/Pcie.h b/Silicon/Socionext/SynQuacer/Include/Platform/Pcie.h > index ee2357be9a06..2d3d5cd91be0 100644 > --- a/Silicon/Socionext/SynQuacer/Include/Platform/Pcie.h > +++ b/Silicon/Socionext/SynQuacer/Include/Platform/Pcie.h > @@ -62,7 +62,7 @@ > > #define SYNQUACER_PCI_LOCATION(s,b,d) (((s) << 16) | ((b) << 8) | (d)) > #define SYNQUACER_PCI_SLOT0_LOCATION SYNQUACER_PCI_LOCATION(1, 0, 0) > -#define SYNQUACER_PCI_SLOT1_LOCATION SYNQUACER_PCI_LOCATION(0, 1, 7) > -#define SYNQUACER_PCI_SLOT2_LOCATION SYNQUACER_PCI_LOCATION(0, 1, 3) > +#define SYNQUACER_PCI_SLOT1_LOCATION SYNQUACER_PCI_LOCATION(0, 1, 3) > +#define SYNQUACER_PCI_SLOT2_LOCATION SYNQUACER_PCI_LOCATION(0, 1, 7) > > #endif > -- > 2.11.0 >