From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <heyi.guo@linaro.org>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com;
 envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org 
Received: from mail-io0-x244.google.com (mail-io0-x244.google.com
 [IPv6:2607:f8b0:4001:c06::244])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id C121A22423839
 for <edk2-devel@lists.01.org>; Thu,  1 Mar 2018 02:19:29 -0800 (PST)
Received: by mail-io0-x244.google.com with SMTP id h23so6579536iob.11
 for <edk2-devel@lists.01.org>; Thu, 01 Mar 2018 02:25:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=from:date:to:cc:subject:message-id:references:mime-version
 :content-disposition:in-reply-to:user-agent;
 bh=RslOhOvG9uxDkAXPZry4xVrwsYdLm8EuH29px2Twxf4=;
 b=BLmdeLOAuNSRrtxxtShs2wS7AC63e0dFhrlLkzMsiX52hHicLecHsAQygbCmcSZLZA
 yo1wlATeJicPO43yayz+I23KqLDcey6062yZYnbIzhbYrUxV8AZl3cQ9inG8NstgFdT9
 H2N+t3ly3WtHseOogSUfMeeQfUJpZhwt+2cMM=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:date:to:cc:subject:message-id:references
 :mime-version:content-disposition:in-reply-to:user-agent;
 bh=RslOhOvG9uxDkAXPZry4xVrwsYdLm8EuH29px2Twxf4=;
 b=o9DClqj9FfBXlJ5qS2kGJiXtKQz5r/ReyBouODOT8isbDso+ll+IDb6IA4ouhYcS/U
 ljij/vAeGr9E/hlTnFFw9rH2SiO0a5nmryF9Z5KJNEy8/m4RVeFLoHF2/RwIiCB5f+QX
 RHsZD6w4eMOAu8gelEk7qZ9jQkL4K5cmggjup61spFAZZ8i4Hn532xMeJd+3GmXYLftg
 LPHvEDVatmokhQAHgXqHz09j4VCWGQ/BPAQLsoslw5mvblQkk1orNEYheKwybxdmpZ2w
 nchPlL0NDOidbYNkT6O9J/tXvjcSdM6QS6k0Xa+GUqXd94y4JfyJdU8gIsujSgXi4FU9
 kGlg==
X-Gm-Message-State: APf1xPAkiX0m055/GWNX9lmwYk/17VbBfX6lo8Y/a0MZurWDb5St7/t6
 ohj7okYIfI14gGaI1NPZ+NhYqw==
X-Google-Smtp-Source: AG47ELtK2lv8bi7aFam/SjrZ/qyxqqltKftUIhdtQvOwPWRizpUNDQPROgsUVdRDP48ie9Wh3zsW9w==
X-Received: by 10.107.156.81 with SMTP id f78mr1419851ioe.68.1519899936944;
 Thu, 01 Mar 2018 02:25:36 -0800 (PST)
Received: from SZX1000114654 ([45.56.152.115])
 by smtp.gmail.com with ESMTPSA id z18sm3070391iti.30.2018.03.01.02.25.34
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 01 Mar 2018 02:25:36 -0800 (PST)
From: Guo Heyi <heyi.guo@linaro.org>
X-Google-Original-From: Guo Heyi <g00179230@SZX1000114654>
Date: Thu, 1 Mar 2018 18:25:32 +0800
To: Laszlo Ersek <lersek@redhat.com>
Cc: Heyi Guo <heyi.guo@linaro.org>, edk2-devel@lists.01.org,
 Jordan Justen <jordan.l.justen@intel.com>,
 Anthony Perard <anthony.perard@citrix.com>,
 Julien Grall <julien.grall@linaro.org>, Ruiyu Ni <ruiyu.ni@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
Message-ID: <20180301102532.GC39361@SZX1000114654>
References: <1519887444-75510-1-git-send-email-heyi.guo@linaro.org>
 <1519887444-75510-3-git-send-email-heyi.guo@linaro.org>
 <dddc2461-34c8-2350-f72e-4141bd5fa006@redhat.com>
MIME-Version: 1.0
In-Reply-To: <dddc2461-34c8-2350-f72e-4141bd5fa006@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Mar 2018 10:19:30 -0000
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Thanks; I got some trouble in making the subject short and clear :)

Regards,
Heyi

On Thu, Mar 01, 2018 at 11:20:22AM +0100, Laszlo Ersek wrote:
> On 03/01/18 07:57, Heyi Guo wrote:
> > Use ZeroMem to initialize all fields in temporary
> > PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but
> > is helpful for future extension: when we add new fields to
> > PCI_ROOT_BRIDGE_APERTURE and the default value of these fields can
> > safely be zero, this code will not suffer from an additional
> > change.
> > 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> > 
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> > Cc: Julien Grall <julien.grall@linaro.org>
> > Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> >  OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 ++++
> >  OvmfPkg/Library/PciHostBridgeLib/XenSupport.c       | 5 +++++
> >  2 files changed, 9 insertions(+)
> 
> I also suggest a different subject line:
> 
> OvmfPkg/PciHostBridgeLib: clear PCI_ROOT_BRIDGE_APERTURE vars for (re)init
> 
> (74 chars)
> 
> Thanks
> Laszlo