From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::236; helo=mail-wm0-x236.google.com; envelope-from=graeme.gregory@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 31617224511A0 for ; Thu, 1 Mar 2018 03:17:22 -0800 (PST) Received: by mail-wm0-x236.google.com with SMTP id x7so10910054wmc.0 for ; Thu, 01 Mar 2018 03:23:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tTdFAAgyarb7HELTihy0lBppThOuZwFLvcA90P7+v/o=; b=jXroeYvTB7LX5VxDDYhzKWrPzgGO3R/V7SxNG+u6NNZQdkOrdNnEV80JIilYM6rIJW pM28+LQtWNw6kRidE8q4D8kgmTMtZGClNr8gBPmaIh3os+z4hchhaLqFn+X55L/L/VcN +GR8kmYQl2gMprREXOJMRgj1mEO+c3kSqOqeE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tTdFAAgyarb7HELTihy0lBppThOuZwFLvcA90P7+v/o=; b=hrsb9dTS4jSUiRBk91SmXCfElnK9hQ2mprpS+sWtlP0Y9M6zrwZp5mHo2fvcUoTs76 u/PwiuJg6JQcIOCPYN4Py9N7ExKMYgExqSR/9QiE/346bfDy21ksQHDBSuxUBeTTbbAa DBkmew2ffbVO9PjQ1iDqOraV8Rh2vEof+Zdi0LktWHoGazRb5wB6juKSSQ8+8hDUdbcb wKwWT3Y/pGo7UUJyxszuPYynQrUq15LIniZE7JA8sllCCdH3wzACjh/vZnYbUyEsJuuq gSsRNqdMo21peboyONG85WgNAeW2wBpcYOntrPEr7K0bVLQ1zcuABTx5mtjAH7P+hzGk ljpw== X-Gm-Message-State: AElRT7FfK/Rx98md1uPOP0F2ETVc8b0YzX5mXFMWND4Ac+5/ZoTgSm5Q V20Fn65y06oyEV7H22ZRsJofAA== X-Google-Smtp-Source: AG47ELtHUt3I+Fr809oLTFrwEfoUTJlTHdqM2jaiXP+ODAC2Y16zF4bDIByitYoDBf1JxBw/qubOGQ== X-Received: by 10.28.3.65 with SMTP id 62mr1433716wmd.116.1519903409490; Thu, 01 Mar 2018 03:23:29 -0800 (PST) Received: from localhost (host-92-20-151-143.as13285.net. [92.20.151.143]) by smtp.gmail.com with ESMTPSA id j132sm4096701wmd.27.2018.03.01.03.23.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Mar 2018 03:23:28 -0800 (PST) Date: Thu, 1 Mar 2018 11:23:27 +0000 From: "Graeme Gregory (Linaro)" To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, leif.lindholm@linaro.org, masahisa.kojima@linaro.org Message-ID: <20180301112327.GB1635@xora-monster> References: <20180228192421.17684-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180228192421.17684-1-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.9.2 (2017-12-15) Subject: Re: [PATCH edk2-platforms v2 0/7] SynQuacer ACPI support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2018 11:17:23 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 28, 2018 at 07:24:14PM +0000, Ard Biesheuvel wrote: > This implements ACPI support for the SynQuacer platforms. > > Changes since v1: > - improve commit log (#1, #2) > - replace bare numbers with symbolic constants (#2) > - add Leif's R-b (#4) > - add patches #6 and #7 > > Note that supporting ACPI on this SoC is non-trivial, due to the quirky > DesignWare RCs and the pre-ITS that sits between the PCIe RCs and the GICv3. > However, the most important issue has been addressed by modifying the static > SMMU mapping that sits between the CPUs and the PCIe config space, working > around the ghosting issue that occurs on these RCs, due the complete lack of > type 0 config TLP filtering by the [non-existent] root port. (This was tested > using the 20180226-LB1.1-ACPI-ramfw.bin SCP firmware image, which is not [yet] > installed by default on DeveloperBox hardware) > > That leaves the MSI issue, which is worked around by limiting MSI support to a > single RC. In the presented configuration, this is RC #1, which connects to the > x16 slot [and nothing else] on the DeveloperBox PCB. The onboard PCIe devices > (XHCI + SATA) work without problem using wired interrupts only, and so RC #0 > has MSI support disabled. This means cards that require MSI support should > be inserted into the x16 slot, which is likely to be the preferred slot in > such cases anwyay (e.g., when using NVME or high end networking plugin cards) > > Patch #1 fixes a minor issue in the slot-to-BDF mapping. > > Patch #2 modifies the static PCIe window configuration so it can be described > using ACPI as well as DT. > > Patch #3 introduces the static ACPI tables that describe the fixed platform > devices and peripherals to the OS. > > Patch #4 adds a menu option to the platform driver to make ACPI vs DT user > selectable. > > Patch #5 adds support for describing the eMMC controller using a SSDT table > which is only installed if eMMC support is enabled. > > Patch #6 adds a _STA method implementation to the PCIe RC devices so that > they are only exposed to the OS when running on a platform that has one of > the several ECAM workarounds enabled. Otherwise, we can still boot via ACPI > using platform devices, but the PCIe RCs are unavailable. > > Patch #7 extends the _STA method for PCI0 to take the presence detect GPIO > into account. This is necessary because on the SynQuacer evaluation board, > any attempt to access the device registers will lock up the system if no > card is inserted into the slot. > > Note that driver support for the eMMC and network controller only landed in > v4.15, but when using a SATA driver and a plugin network card that does have > driver support, these patches should allow the SynQuacer based platforms to > boot stock Debian Stretch/Fedora/Centos etc installers. > The ACPI parts look good to me. Reviewed-by: Graeme Gregory > Ard Biesheuvel (7): > Platform/Socionext/DeveloperBox: fix PCIe slot to B/D/F mapping > Silicon/SynQuacer: tweak PCI I/O windows for ACPI/Linux support > Silicon/SynQuacer: add ACPI drivers and tables > Silicon/SynQuacer/PlatformDxe: add option to enable ACPI mode > Silicon/SynQuacer/PlatformDxe: add ACPI description of eMMC > Silicon/SynQuacer/AcpiTables: disable PCI RCs if ECAM ghosts are > detected > Silicon/SynQuacer/AcpiTables: take presence detect of PCI0 into > account > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 + > Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 14 + > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 2 + > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 14 + > Silicon/Socionext/SynQuacer/Acpi.dsc.inc | 48 +++ > Silicon/Socionext/SynQuacer/AcpiTables/AcpiSsdtRootPci.asl | 317 ++++++++++++++++++++ > Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.h | 73 +++++ > Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf | 65 ++++ > Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 187 ++++++++++++ > Silicon/Socionext/SynQuacer/AcpiTables/Fadt.aslc | 91 ++++++ > Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc | 93 ++++++ > Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 101 +++++++ > Silicon/Socionext/SynQuacer/AcpiTables/Madt.aslc | 182 +++++++++++ > Silicon/Socionext/SynQuacer/AcpiTables/Mcfg.aslc | 63 ++++ > Silicon/Socionext/SynQuacer/AcpiTables/Spcr.aslc | 128 ++++++++ > Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 2 +- > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.asl | 41 +++ > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c | 55 ++++ > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c | 32 +- > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.h | 4 + > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 5 + > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.uni | 8 +- > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr | 10 +- > Silicon/Socionext/SynQuacer/Include/Platform/Pcie.h | 22 +- > Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h | 8 +- > Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLibConstructor.c | 4 +- > 26 files changed, 1546 insertions(+), 25 deletions(-) > create mode 100644 Silicon/Socionext/SynQuacer/Acpi.dsc.inc > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/AcpiSsdtRootPci.asl > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.h > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/Fadt.aslc > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/Madt.aslc > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/Mcfg.aslc > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/Spcr.aslc > create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.asl > > -- > 2.11.0 >