[PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory()

[PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory()

[Hao Wu]

Within function UpdateDisplayFromHistory():

When getting a character with different attribute with the current one,
the statement to compare the character with a 'NULL' char should be:

*StringSegmentEnd != CHAR_NULL

rather than:

StringSegmentEnd != CHAR_NULL

This commit resolves this typo.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 ShellPkg/Application/Shell/ConsoleLogger.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Application/Shell/ConsoleLogger.c b/ShellPkg/Application/Shell/ConsoleLogger.c
index bc96da1f1b..074e0cf046 100644
--- a/ShellPkg/Application/Shell/ConsoleLogger.c
+++ b/ShellPkg/Application/Shell/ConsoleLogger.c
@@ -2,7 +2,7 @@
   Provides interface to shell console logger.
 
   (C) Copyright 2013 Hewlett-Packard Development Company, L.P.<BR>
-  Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2016 Hewlett-Packard Development Company, L.P.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -322,7 +322,7 @@ UpdateDisplayFromHistory(
         //
         StringSegmentEndChar = CHAR_NULL;
         for ( StringSegmentEnd = StringSegment
-            ; StringSegmentEnd != CHAR_NULL
+            ; *StringSegmentEnd != CHAR_NULL
             ; StringSegmentEnd++
             , Column++
            ){
-- 
2.12.0.windows.1

Re: [PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory()

[Ni, Ruiyu]

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Wu, Hao A
> Sent: Saturday, March 3, 2018 11:05 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [PATCH] ShellPkg/ConsoleLogger: Fix a typo in
> UpdateDisplayFromHistory()
> 
> Within function UpdateDisplayFromHistory():
> 
> When getting a character with different attribute with the current one, the
> statement to compare the character with a 'NULL' char should be:
> 
> *StringSegmentEnd != CHAR_NULL
> 
> rather than:
> 
> StringSegmentEnd != CHAR_NULL
> 
> This commit resolves this typo.
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  ShellPkg/Application/Shell/ConsoleLogger.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Application/Shell/ConsoleLogger.c
> b/ShellPkg/Application/Shell/ConsoleLogger.c
> index bc96da1f1b..074e0cf046 100644
> --- a/ShellPkg/Application/Shell/ConsoleLogger.c
> +++ b/ShellPkg/Application/Shell/ConsoleLogger.c
> @@ -2,7 +2,7 @@
>    Provides interface to shell console logger.
> 
>    (C) Copyright 2013 Hewlett-Packard Development Company, L.P.<BR>
> -  Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2009 - 2018, Intel Corporation. All rights
> + reserved.<BR>
>    (C) Copyright 2016 Hewlett-Packard Development Company, L.P.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License @@ -322,7 +322,7 @@ UpdateDisplayFromHistory(
>          //
>          StringSegmentEndChar = CHAR_NULL;
>          for ( StringSegmentEnd = StringSegment
> -            ; StringSegmentEnd != CHAR_NULL
> +            ; *StringSegmentEnd != CHAR_NULL
>              ; StringSegmentEnd++
>              , Column++
>             ){
> --
> 2.12.0.windows.1

Re: [PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory()

[Carsey, Jaben]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Wu, Hao A
> Sent: Friday, March 02, 2018 7:05 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [PATCH] ShellPkg/ConsoleLogger: Fix a typo in
> UpdateDisplayFromHistory()
> Importance: High
> 
> Within function UpdateDisplayFromHistory():
> 
> When getting a character with different attribute with the current one,
> the statement to compare the character with a 'NULL' char should be:
> 
> *StringSegmentEnd != CHAR_NULL
> 
> rather than:
> 
> StringSegmentEnd != CHAR_NULL
> 
> This commit resolves this typo.
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  ShellPkg/Application/Shell/ConsoleLogger.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Application/Shell/ConsoleLogger.c
> b/ShellPkg/Application/Shell/ConsoleLogger.c
> index bc96da1f1b..074e0cf046 100644
> --- a/ShellPkg/Application/Shell/ConsoleLogger.c
> +++ b/ShellPkg/Application/Shell/ConsoleLogger.c
> @@ -2,7 +2,7 @@
>    Provides interface to shell console logger.
> 
>    (C) Copyright 2013 Hewlett-Packard Development Company, L.P.<BR>
> -  Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
>    (C) Copyright 2016 Hewlett-Packard Development Company, L.P.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
> @@ -322,7 +322,7 @@ UpdateDisplayFromHistory(
>          //
>          StringSegmentEndChar = CHAR_NULL;
>          for ( StringSegmentEnd = StringSegment
> -            ; StringSegmentEnd != CHAR_NULL
> +            ; *StringSegmentEnd != CHAR_NULL
>              ; StringSegmentEnd++
>              , Column++
>             ){
> --
> 2.12.0.windows.1