From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.96.140; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7DBA322135D59 for ; Tue, 6 Mar 2018 06:09:04 -0800 (PST) Received: from E107187.Emea.Arm.com (e107187.emea.arm.com [10.1.211.8]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w26EFB2g015399; Tue, 6 Mar 2018 14:15:11 GMT From: Sami Mujawar To: edk2-devel@lists.01.org Cc: Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, michael.d.kinney@intel.com, evan.lloyd@arm.com, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Date: Tue, 6 Mar 2018 14:15:06 +0000 Message-Id: <20180306141506.17316-1-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 Subject: [PATCH v1] Platform/ARM/VExpressPkg: Fix RSDT pointer in RSDP X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 14:09:05 -0000 According to the SBBR Specification (ARM DEN 0044B), Section 4.2.1.1 "Within the RSDP, the RsdtAddress field must be null (zero) and the XsdtAddresss MUST be a valid, non-null, 64-bit value." The PcdAcpiExposedTableVersions is used to indicate the ACPI versions that are supported. The default value for PcdAcpiExposedTableVersions is 0x3E which indicates that the ACPI versions 1.0B and above are supported. For ACPI 1.0B the RSDT pointer is set in the RSDP table. However for ACPI versions greater than ACPI 1.0B the AcpiTableDxe populates the RSDP with the RSDT address set to NULL. Therefore set the PcdAcpiExposedTableVersions to 0x20 indicating support for ACPI 5.0 and above. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Signed-off-by: Evan Lloyd --- The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/212_fvp_rsdt_fix_v1 Notes: v1: - Setup PcdAcpiExposedTableVersions correctly so that the AcpiTableDxe populates the RSDP with the RSDT address set to NULL. [SAMI] Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc index 295e9a126b0ebaa4653d7e25e2f7d8c396403764..cdf9e2d49784d542701dc84eb511f592e77ec106 100644 --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc @@ -1,5 +1,5 @@ # -# Copyright (c) 2011-2017, ARM Limited. All rights reserved. +# Copyright (c) 2011-2018, ARM Limited. All rights reserved. # # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -162,6 +162,11 @@ [PcdsFixedAtBuild.common] # the entire FVP address space can be covered by 36 bit VAs gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|36 + # + # ACPI Table Version + # + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 + ################################################################################ # # Components Section - list of all EDK II Modules needed by this Platform -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'