public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Guo Heyi <heyi.guo@linaro.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Guo Heyi <heyi.guo@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Yi Li <phoenix.liyi@huawei.com>,
	Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH 1/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload
Date: Tue, 13 Mar 2018 08:34:04 +0800	[thread overview]
Message-ID: <20180313003404.GB96299@SZX1000114654> (raw)
In-Reply-To: <cd5203dc-8a10-f9a4-e11f-fc34769115c3@arm.com>

On Mon, Mar 12, 2018 at 10:48:59AM +0000, Marc Zyngier wrote:
> On 12/03/18 10:38, Ard Biesheuvel wrote:
> > On 12 March 2018 at 10:38, Guo Heyi <heyi.guo@linaro.org> wrote:
> >> Hi Marc,
> >>
> >> I just tested with an ISB and it also worked for our platform.
> >>
> >> So is it acceptable to add an ISB after reloading timer compare value?
> >>
> > 
> > I am fine with that if Marc is.
> 
> An ISB makes a lot more sense to me. You can put my ack on a modified
> version of that patch.

Hi Marc,

I've sent v2 patch using ISB. Please help to check the updated commit message to
see if my understanding is correct.

Thanks,

Heyi

> 
> Thanks,
> 
> 	M.
> -- 
> Jazz is not dead. It just smells funny...


      reply	other threads:[~2018-03-13  0:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12  6:53 [PATCH 0/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload Heyi Guo
2018-03-12  6:53 ` [PATCH 1/1] " Heyi Guo
2018-03-12  9:46   ` Marc Zyngier
2018-03-12 10:26     ` Guo Heyi
2018-03-12 10:38       ` Guo Heyi
2018-03-12 10:38         ` Ard Biesheuvel
2018-03-12 10:48           ` Marc Zyngier
2018-03-13  0:34             ` Guo Heyi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180313003404.GB96299@SZX1000114654 \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox