From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <heyi.guo@linaro.org>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=2607:f8b0:400e:c00::232; helo=mail-pf0-x232.google.com;
 envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org 
Received: from mail-pf0-x232.google.com (mail-pf0-x232.google.com
 [IPv6:2607:f8b0:400e:c00::232])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 2738422135D56
 for <edk2-devel@lists.01.org>; Mon, 12 Mar 2018 17:27:47 -0700 (PDT)
Received: by mail-pf0-x232.google.com with SMTP id h11so5115987pfn.4
 for <edk2-devel@lists.01.org>; Mon, 12 Mar 2018 17:34:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=from:date:to:cc:subject:message-id:references:mime-version
 :content-disposition:in-reply-to:user-agent;
 bh=s4gYwmUARuZ67GhpSXo83Egn0XklKV02a8WTYDFBFPk=;
 b=CN/zK3QEteKlFI5iS/UnULdZrKHo56JID2OghXE2mBAhPFRy8q5/nsv3szCcfqduFA
 w2c+dko+HIX6yLKyJuewnf8NORz4BVYhpGQjz2n6WBQs/pclt9JzZoK0MSjR5SP9cvFg
 SCnC19+MPTNSItouIVWb7SQQTGFvWFKU2eUcY=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:date:to:cc:subject:message-id:references
 :mime-version:content-disposition:in-reply-to:user-agent;
 bh=s4gYwmUARuZ67GhpSXo83Egn0XklKV02a8WTYDFBFPk=;
 b=KaZJdFB7kAfLs5s9TBZ2z2WcFnp0NhC73l41IulSH2d9yiuPEix0clmqs6cbx6HSwr
 JabW1LDCDJxb0TAbxwHgdP2fMZqhg0YQfa1LQAPXePbm3QC3Wu+Aj6Unc3lrJpRoCZhu
 3+K9YBW2oQLpRsmmb/BcntO+DAU/PinRlpWbwrz2ONJe95vvpTiccoT14mjEufay0/Ff
 ggsCRU2s6tVnni8eBFSGqWuz/wn3bZzl1DQ5CZwxuIFPVmixRTiA8qc80pyCh00Nc/Dt
 gMJ+FSed1MUONAYDYAxWSZ7ge6bYhuMUCPnRfKmzqQQeibRFn+hQxm7J5ktQnFrNfAdi
 4yzg==
X-Gm-Message-State: AElRT7FKH+gDX2vY4DwiGPDPFibHdQflXMbcQWWmpsMlHjjMHfzPZVHZ
 NS9B6nKy+uCfHGpkEXX6o4sWDw==
X-Google-Smtp-Source: AG47ELvIz/7UwpLDDy7HInnK19rxwapBl2h+nkNarE78EVXF7Mq83frp3ZTVOEcX2kZBqh0kcU/2Uw==
X-Received: by 10.99.127.69 with SMTP id p5mr8076555pgn.346.1520901248962;
 Mon, 12 Mar 2018 17:34:08 -0700 (PDT)
Received: from SZX1000114654 ([45.56.152.76])
 by smtp.gmail.com with ESMTPSA id 189sm19015111pfu.129.2018.03.12.17.34.06
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 12 Mar 2018 17:34:08 -0700 (PDT)
From: Guo Heyi <heyi.guo@linaro.org>
X-Google-Original-From: Guo Heyi <g00179230@SZX1000114654>
Date: Tue, 13 Mar 2018 08:34:04 +0800
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>, Guo Heyi <heyi.guo@linaro.org>,
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Yi Li <phoenix.liyi@huawei.com>, Leif Lindholm <leif.lindholm@linaro.org>
Message-ID: <20180313003404.GB96299@SZX1000114654>
References: <1520837611-94728-1-git-send-email-heyi.guo@linaro.org>
 <1520837611-94728-2-git-send-email-heyi.guo@linaro.org>
 <54c4aab8-cc61-b4cc-6ab0-325dd42cca35@arm.com>
 <20180312102643.GC60232@SZX1000114654>
 <20180312103808.GD60232@SZX1000114654>
 <CAKv+Gu-35GwgUP4rNE3SpLLmtQ_kTpNapbCaTro9ZrxHA-So-A@mail.gmail.com>
 <cd5203dc-8a10-f9a4-e11f-fc34769115c3@arm.com>
MIME-Version: 1.0
In-Reply-To: <cd5203dc-8a10-f9a4-e11f-fc34769115c3@arm.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [PATCH 1/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Mar 2018 00:27:48 -0000
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Mar 12, 2018 at 10:48:59AM +0000, Marc Zyngier wrote:
> On 12/03/18 10:38, Ard Biesheuvel wrote:
> > On 12 March 2018 at 10:38, Guo Heyi <heyi.guo@linaro.org> wrote:
> >> Hi Marc,
> >>
> >> I just tested with an ISB and it also worked for our platform.
> >>
> >> So is it acceptable to add an ISB after reloading timer compare value?
> >>
> > 
> > I am fine with that if Marc is.
> 
> An ISB makes a lot more sense to me. You can put my ack on a modified
> version of that patch.

Hi Marc,

I've sent v2 patch using ISB. Please help to check the updated commit message to
see if my understanding is correct.

Thanks,

Heyi

> 
> Thanks,
> 
> 	M.
> -- 
> Jazz is not dead. It just smells funny...