public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Guo Heyi <heyi.guo@linaro.org>
To: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Guo Heyi <heyi.guo@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation
Date: Tue, 13 Mar 2018 15:31:07 +0800	[thread overview]
Message-ID: <20180313073107.GD96299@SZX1000114654> (raw)
In-Reply-To: <a6cad7d4-3847-1310-09e4-946e60f8102b@Intel.com>

Hi Ray,

If the major concern is about backward compatibility, we can think about ways to
get around of this, e.g. add a feature PCD to turn on translation and set the
default value to false.

Thanks,
Heyi

On Tue, Mar 13, 2018 at 11:00:12AM +0800, Ni, Ruiyu wrote:
> On 3/13/2018 1:18 AM, Ard Biesheuvel wrote:
> >On 7 March 2018 at 04:30, Ni, Ruiyu <ruiyu.ni@intel.com> wrote:
> >>On 3/6/2018 10:44 AM, Guo Heyi wrote:
> >>>
> >>>Hi Ray,
> >>>
> >>>Any comments for v5?
> >>
> >>
> >>Heyi,
> >>Some backward compatibility concerns were received from internal production
> >>teams. Current change will cause silent failure on old platforms because
> >>TranslationOffset might be random if uninitialized.
> >>I will solve the concern and then send out updates to you, hopefully by end
> >>of next week.
> >>
> >
> >Hello Ray,
> >
> >Do you have any updates on these issues? I'd like to proceed with
> >getting this code merged if we can
> >
> >Thanks,
> >Ard.
> >
> Ard,
> I will try to give updates tomorrow.
> If I cannot, I will let you know.
> Then I will give you updates by the end of this week.
> 
> -- 
> Thanks,
> Ray


  reply	other threads:[~2018-03-13  7:24 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01  6:57 [PATCH v5 0/6] Add translation support to generic PciHostBridge Heyi Guo
2018-03-01  6:57 ` [PATCH v5 1/6] CorebootPayloadPkg/PciHostBridgeLib: Init PCI aperture to 0 Heyi Guo
2018-03-14 11:24   ` Ard Biesheuvel
2018-03-01  6:57 ` [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: " Heyi Guo
2018-03-01 10:17   ` Laszlo Ersek
2018-03-01 10:48     ` Guo Heyi
2018-03-02 10:19       ` Laszlo Ersek
2018-03-05  8:23         ` Guo Heyi
2018-03-01 10:20   ` Laszlo Ersek
2018-03-01 10:25     ` Guo Heyi
2018-03-01 12:03     ` Ni, Ruiyu
2018-03-02 10:08       ` Laszlo Ersek
2018-03-01  6:57 ` [PATCH v5 3/6] MdeModulePkg/PciHostBridgeLib.h: add address Translation Heyi Guo
2018-03-01  6:57 ` [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation Heyi Guo
2018-03-06  2:44   ` Guo Heyi
2018-03-07  4:30     ` Ni, Ruiyu
2018-03-07  6:01       ` Guo Heyi
2018-03-14  7:57         ` Ni, Ruiyu
2018-03-14 11:25           ` Ard Biesheuvel
2018-03-15  2:57           ` Guo Heyi
2018-03-15  3:25             ` Ni, Ruiyu
2018-03-12 17:18       ` Ard Biesheuvel
2018-03-13  3:00         ` Ni, Ruiyu
2018-03-13  7:31           ` Guo Heyi [this message]
2018-03-13  8:04             ` Ard Biesheuvel
2018-03-01  6:57 ` [PATCH v5 5/6] MdeModulePkg/PciBus: convert host address to device address Heyi Guo
2018-03-01  6:57 ` [PATCH v5 6/6] MdeModulePkg/PciBus: return CPU address for GetBarAttributes Heyi Guo
2018-03-01  8:28 ` [PATCH v5 0/6] Add translation support to generic PciHostBridge Ard Biesheuvel
2018-03-15  1:07 ` Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180313073107.GD96299@SZX1000114654 \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox