From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::236; helo=mail-io0-x236.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A056121ED1C53 for ; Tue, 13 Mar 2018 00:24:52 -0700 (PDT) Received: by mail-io0-x236.google.com with SMTP id d21so7172730ioc.5 for ; Tue, 13 Mar 2018 00:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Q7dsKBtnYgXup202sJGIcmLkTed/G6KzgQVRHeAgut8=; b=Zb3fjdQGltUbwOsWLmXxXVJPeG9z0UFxzNXEAy4KeBAqDi/edpwZP+ZNSwBZIcTsnv u9cP7sSCIoX66K5+da27VVW/KnFn5rZ/9EzeDRLpy//vX2fCU0MVa+ElVHxm6TWviPI0 8DvJMMybU8LSvB7xAbVeelwdA9UJlZq8Gr+IA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Q7dsKBtnYgXup202sJGIcmLkTed/G6KzgQVRHeAgut8=; b=fJSd7WAG+rxXAE56ema2fP2uxDigtb/pMFLyvye/dLymRiRUJnIVZuz3whMlkTVev+ vi+Jx296M520BYo8GTG4SNnF6zbQQ7Nkvng5ixxcI2UOxf7mNzqGHqZagxMnKdVb+LJB 7F6SmUyCTRsbwKH15fN+skRynKXbXqZKyh6O/FNLM4iKsBGF1Bpt7E9uZxyjLEgbWj+O +ePvGmjZd1xAQsNsTB2/Al5m3X2eNEctlXH04ac/+K/hRgfBN5Tv6nhxg7yHNeXt/nWC wgz/C2Aem3omvM6E6RMtkMRowGUjPZDO8GuHGf4ZCuXK+xuBjvH+C+JVa3ha+ADRyE83 ZtBw== X-Gm-Message-State: AElRT7HXvWcZY4sEeh3IEOM2txJ2a3HeZ4JREeXySLiutAkph8vl0BcR 4pyIx3TJVx04yV6h1OxVLLXvfg== X-Google-Smtp-Source: AG47ELtX3Vk9zNbIPbX1CX2PMdeEhw6MW1F4nV6qnPTnCHZ967eFv+GC84XsXKNiHWE4PpvQ/F+x+w== X-Received: by 10.107.37.17 with SMTP id l17mr10931194iol.236.1520926273018; Tue, 13 Mar 2018 00:31:13 -0700 (PDT) Received: from SZX1000114654 ([45.56.152.76]) by smtp.gmail.com with ESMTPSA id 137sm4822610itx.42.2018.03.13.00.31.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Mar 2018 00:31:12 -0700 (PDT) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Tue, 13 Mar 2018 15:31:07 +0800 To: "Ni, Ruiyu" Cc: Ard Biesheuvel , Guo Heyi , "edk2-devel@lists.01.org" , Star Zeng , Eric Dong , Laszlo Ersek , Michael D Kinney Message-ID: <20180313073107.GD96299@SZX1000114654> References: <1519887444-75510-1-git-send-email-heyi.guo@linaro.org> <1519887444-75510-5-git-send-email-heyi.guo@linaro.org> <20180306024440.GA90780@SZX1000114654> <71a21699-a1b3-155a-e743-ee5e6288ce20@Intel.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 07:24:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Ray, If the major concern is about backward compatibility, we can think about ways to get around of this, e.g. add a feature PCD to turn on translation and set the default value to false. Thanks, Heyi On Tue, Mar 13, 2018 at 11:00:12AM +0800, Ni, Ruiyu wrote: > On 3/13/2018 1:18 AM, Ard Biesheuvel wrote: > >On 7 March 2018 at 04:30, Ni, Ruiyu wrote: > >>On 3/6/2018 10:44 AM, Guo Heyi wrote: > >>> > >>>Hi Ray, > >>> > >>>Any comments for v5? > >> > >> > >>Heyi, > >>Some backward compatibility concerns were received from internal production > >>teams. Current change will cause silent failure on old platforms because > >>TranslationOffset might be random if uninitialized. > >>I will solve the concern and then send out updates to you, hopefully by end > >>of next week. > >> > > > >Hello Ray, > > > >Do you have any updates on these issues? I'd like to proceed with > >getting this code merged if we can > > > >Thanks, > >Ard. > > > Ard， > I will try to give updates tomorrow. > If I cannot, I will let you know. > Then I will give you updates by the end of this week. > > -- > Thanks, > Ray