From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC4DA21E2BE2F for ; Wed, 14 Mar 2018 22:29:58 -0700 (PDT) Received: by mail-it0-x243.google.com with SMTP id v194-v6so7638652itb.0 for ; Wed, 14 Mar 2018 22:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VUL+mF2T8jyWvj6Xd1CzK655QP114F7X9xCHntJ0GHQ=; b=Az+J7ZNU38p67JekhZ1+0A2GGtTx7cAOu7qJFjFcm4n/CdzsgL8yhVIWKIAzhyYaYp PrF7LN6obZUOqnVbyCthnmmu05NvgvUpEXtjOnuJpkH4dy/exx2bq+bx7r9E8NEJz1FM QhsUQF1SJo5JV/3lNSgOfT8msw/puXFkTzuMo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VUL+mF2T8jyWvj6Xd1CzK655QP114F7X9xCHntJ0GHQ=; b=tVj0NhF751qfpum44hu5toxPGj1EASL/ew7AX85kGYSgZIvokDcUYRo7inMeDQStX/ RVAM1nHnoW5j+qEKA3Y9WHZIGKuoayuH1HJljjcWau0hZkr97GhX0ctYD6QtRy4/DURN sxHN4EmHHkdE17rF1E+HrUZ/fWTQms9CJItAGrhs9EW+Orf98Qp0fYpmQ9q8nnmMqZYJ m1dgMRXHQKpJ7Ud9khBy1fQVXpnVcDvgherxvxQ+5yV5A311PERQXzLnjjCeejsQEQMu buF3/8qrPus8qRSbNZ3xeDFdBHhQ/bd75HKt4LL5whlkGf555pmx0L47Fa3oMj+AZ+r+ N4uA== X-Gm-Message-State: AElRT7Fd0k7qXWl4n5mKkz9fnU8YNyvy6cSfirUEKRcl/goaYk9fIYEV XHR/UicfXxQBbIlqM0Q5cCVc1A== X-Google-Smtp-Source: AG47ELvVLfiGLDuowrcKre6GNQHFO3JlsiF69VBw62ftggLcXfh8SIBBPx9SPt8w+FcDIbFOHhcllA== X-Received: by 10.36.148.204 with SMTP id j195mr4799451ite.1.1521092181856; Wed, 14 Mar 2018 22:36:21 -0700 (PDT) Received: from SZX1000114654 ([45.56.152.100]) by smtp.gmail.com with ESMTPSA id o7sm2624514iod.52.2018.03.14.22.36.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Mar 2018 22:36:21 -0700 (PDT) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Thu, 15 Mar 2018 13:36:16 +0800 To: "Ni, Ruiyu" Cc: Heyi Guo , edk2-devel@lists.01.org, Eric Dong , Ard Biesheuvel , Jordan Justen , Anthony Perard , Prince Agyeman , Michael D Kinney , Laszlo Ersek , Star Zeng Message-ID: <20180315053616.GC108227@SZX1000114654> References: <1521086424-113954-1-git-send-email-heyi.guo@linaro.org> <7b0d2465-1dab-7162-aee6-2703b5f38b07@Intel.com> MIME-Version: 1.0 In-Reply-To: <7b0d2465-1dab-7162-aee6-2703b5f38b07@Intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [PATCH v6 0/6] Add translation support to generic PciHostBridge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 05:29:59 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 15, 2018 at 01:27:59PM +0800, Ni, Ruiyu wrote: > On 3/15/2018 12:00 PM, Heyi Guo wrote: > >v6: > >- Patch 1, 2: implement 3 comments from Laszlo. > >- Patch 4: implement 3 comments from Ray. > > > >Patch v5 inherits the code from RFC v4; we don't restart the version number for > >RFC to PATCH change. > > > >v5: > >- Patch 4/6: Modify the code according to the comments from Ray. > >- Patch 1/6 and 2/6 are totally new. They add initialization for all fields of > > PCI_ROOT_BRIDGE_APERTURE temporary variables in PciHostBridgeLib instances, so > > that they will not suffer from extension of PCI_ROOT_BRIDGE_APERTURE > > structure. > >- Generate a separate patch (3/6) for PciHostBridgeLib.h change. Though it is a > > prerequisite for patch 4/6, it does not change the code in PciHostBridge > > driver and won't cause any build failure or functional issue. > > > > > >v4: > >- Modify the code according to the comments from Ray, Laszlo and Ard (Please see > > the notes of Patch 1/3) > >- Ignore translation of bus in CreateRootBridge. > > > > > >v3: > >- Keep definition of Translation consistent in EDKII code: Translation = device > > address - host address. > >- Patch 2/2 is split into 2 patches (2/3 and 3/3). > >- Refine comments and commit messages to make the code easier to understand. > > > > > >v2: > >Changs are made according to the discussion on the mailing list, including: > > > >- PciRootBridgeIo->Configuration should return CPU view address, as well as > > PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view > > address - CPU view address. > >- Add translation offset to PCI_ROOT_BRIDGE_APERTURE structure definition. > >- PciHostBridge driver internally used Base Address is still based on PCI view > > address, and translation offset = CPU view - PCI view, which follows the > > definition in ACPI, and not the same as that in UEFI spec. > > > >Cc: Ruiyu Ni > >Cc: Ard Biesheuvel > >Cc: Star Zeng > >Cc: Eric Dong > >Cc: Laszlo Ersek > >Cc: Michael D Kinney > >Cc: Maurice Ma > >Cc: Prince Agyeman > >Cc: Benjamin You > >Cc: Jordan Justen > >Cc: Anthony Perard > >Cc: Julien Grall > > > > > >Heyi Guo (6): > > CorebootPayloadPkg/PciHostBridgeLib: clear aperture vars for (re)init > > OvmfPkg/PciHostBridgeLib: clear PCI aperture vars for (re)init > > MdeModulePkg/PciHostBridgeLib.h: add address Translation > > MdeModulePkg/PciHostBridgeDxe: Add support for address translation > > MdeModulePkg/PciBus: convert host address to device address > > MdeModulePkg/PciBus: return CPU address for GetBarAttributes > > > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.h | 21 +++ > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h | 3 + > > MdeModulePkg/Include/Library/PciHostBridgeLib.h | 19 +++ > > CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 7 +- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 12 +- > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 129 ++++++++++++++++--- > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 135 ++++++++++++++++++-- > > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 + > > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 7 +- > > 9 files changed, 306 insertions(+), 31 deletions(-) > > > Heyi, > I have given the Reviewed-by for the whole patch series. So please just add > my R-b if you want to send further version of patches. > I only have a minor comment for #4 patch. I don't think you need to send > another version of #4 patch. You can just change the code when committing. Thanks, but I don't have commit privilege myself, so maybe a v7 is needed, and I will add your R-b for the whole series :) Regards, Heyi > Thanks, > Ray > > -- > Thanks, > Ray