From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::22c; helo=mail-wr0-x22c.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x22c.google.com (mail-wr0-x22c.google.com [IPv6:2a00:1450:400c:c0c::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5F72721E082B3 for ; Thu, 15 Mar 2018 11:52:08 -0700 (PDT) Received: by mail-wr0-x22c.google.com with SMTP id n12so9410836wra.2 for ; Thu, 15 Mar 2018 11:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=r4jS337C8v1igUNpCcf6i3rVxoB1suZmerasM1NZLrM=; b=VTv0Y+C8BaFEOq+FtMzsxBA8VXaMIPZ7yo86hxn43pHkW9l1NZLlSbXZEkoJzY7tvq hhlOtDsb6ysUhvlOfMyVCeKre1ro2AIVqjMzs08FNxq7DE8TmHnz2twCwaheyIlWRppy G1Ksl6LxAQTEr3eAqEe0RsqEwi8UQwg6ZucAI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=r4jS337C8v1igUNpCcf6i3rVxoB1suZmerasM1NZLrM=; b=cWtJncRS5IG6qT8yP/+MzEW3S3h0RB4HhpRnFIpJa9m12q/tqmP8KxTtE4cGFtEwgL vyBXu49DanGbETATUilbrb5ThmrX29hErx9exc9A7hIlrwAOynU2aFxGanzMU2JDwaUr 0IBJI/70yreOTp59zOIIydvKQcrRokL9ta0hnMaKI2/mDfzdwVIYb1licZKk3NkO2CdX inV10ZU5xZx5Lk0GJajVM6TSRPX8lZSa/Gy9lOnubxoVd2JFTS30ydF+/uU68eLOSH3P lv5ZUI3vPHhmo3bP+F5J/epYN2tQ/yBc0mexmwO12is/TJVvz/QgrvXyHs8msCcHIQvD okew== X-Gm-Message-State: AElRT7EIKw8vREaBhCkile9WcRoVDnwLrSUCWv0Spha7kaQVFRX7QtVI eLh+R8xp8hMSKwBxEvqvMGcDFNmvH2M= X-Google-Smtp-Source: AG47ELu1Ec9bhqZuzwSAUguOR/g/yP91We6nYBcxDSXOSwW7IPiONVp9DwU23mB0BWpLfX2SyNi/lA== X-Received: by 10.223.131.37 with SMTP id 34mr8326142wrd.169.1521140311823; Thu, 15 Mar 2018 11:58:31 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j137sm6967756wmd.17.2018.03.15.11.58.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Mar 2018 11:58:30 -0700 (PDT) Date: Thu, 15 Mar 2018 18:58:29 +0000 From: Leif Lindholm To: Sami Mujawar Cc: edk2-devel@lists.01.org, evan.lloyd@arm.com, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Message-ID: <20180315185829.jp2oh44ilkpnyk2l@bivouac.eciton.net> References: <20180314185145.15672-1-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20180314185145.15672-1-sami.mujawar@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH][platforms/devel-dynamictables] Branch to implement Dynamic Tables Framework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 18:52:10 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 14, 2018 at 06:51:45PM +0000, Sami Mujawar wrote: > This patch introduces a branch for implementing Dynamic Tables > Framework. The description is in the Readme.md file. > > Please create a branch called 'devel-dynamictables' in edk2-platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > Signed-off-by: Evan Lloyd So, I'm a little bit surprised to see an identical Readme.md submitted to edk2-staging and edk2-platforms. But it possibly makes sense. Nevertheless, that also means the same feedback applies to both of them. / Leif > --- > Readme.md | 149 ++++++++++++++++++++ > 1 file changed, 149 insertions(+) > > diff --git a/Readme.md b/Readme.md > new file mode 100644 > index 0000000000000000000000000000000000000000..dfe247d3fef8936b2f4551cf9f7e735a28bcf1da > --- /dev/null > +++ b/Readme.md > @@ -0,0 +1,149 @@ > +This branch will be used to develop the Configuration Manager, > +which is the platform specific component of the Dynamic Tables > +Framework. > + > +Dynamic Tables Framework > +------------------------ > + > +To reduce the amount of effort required in porting firmware to new > +platforms, we propose this "Dynamic Tables" framework. The aim is > +to provide an example implementation capable of generating the > +firmware tables from an external source. This is potentially a > +management node, either local or remote, or, where suitable, a file > +that might be generated from the system construction. This initial > +"proof of concept" release does not fully implement that - the > +configuration is held in local UEFI modules. > + > +Branch Owners > +------------- > + Evan Lloyd \ > + Sami Mujawar > + > +Feature Summary > +--------------- > +The dynamic tables framework is designed to generate standardised > +firmware tables that describe the hardware information at > +run-time. A goal of standardised firmware is to have a common > +firmware for a platform capable of booting both Windows and Linux > +operating systems. > + > +Traditionally the firmware tables are handcrafted using ACPI > +Source Language (ASL), Table Definition Language (TDL) and > +C-code. This approach can be error prone and involves time > +consuming debugging. In addition, it may be desirable to configure > +platform hardware at runtime such as: configuring the number of > +cores available for use by the OS, or turning SoC features ON or > +OFF. > + > +The dynamic tables framework simplifies this by providing a set > +of standard table generators, that are implemented as libraries. > +These generators query a platform specific component, the > +'Configuration Manager', to collate the information required > +for generating the tables at run-time. > + > +The framework also provides the ability to implement custom/OEM > +generators; thereby facilitating support for custom tables. The > +custom generators can also utilize the existing standard generators > +and override any functionality if needed. > + > +The framework currently implements a set of standard ACPI table > +generators for ARM architecture, that can generate Server Base Boot > +Requirement (SBBR) compliant tables. Although, the set of standard > +generators implement the functionality required for ARM architecture; > +the framework is extensible, and support for other architectures can > +be added easily. > + > +The framework currently supports the following table generators for ARM: > +* DBG2 - Debug Port Table 2 > +* DSDT - Differentiated system description table. This is essentially > + a RAW table generator. > +* FADT - Fixed ACPI Description Table > +* GTDT - Generic Timer Description Table > +* IORT - IO Remapping Table > +* MADT - Multiple APIC Description Table > +* MCFG - PCI Express memory mapped configuration space base address > + Description Table > +* SPCR - Serial Port Console Redirection Table > +* SSDT - Secondary System Description Table. This is essentially > + a RAW table generator. > + > +Roadmap > +------- > +The current implementation of the Configuration Manager populates the > +platform information statically as a C structure. Further enhancements > +to introduce runtime loading of platform information from a platform > +information file is planned. > + > +Also support for generating SMBIOS tables is planned and will be added > +subsequently. > + > +Related Modules > +--------------- > + > +### edk2-staging > +The *dynamictables* branch in the **edk2-staging** repository > +contains the Dynamic Tables Framework. > + > +### ACPICA iASL compiler > +The RAW table generator, used to process the DSDT/SSDT files depends on > +the iASL compiler to convert the DSDT/SSDT ASL files to a C array containing > +the hex AML code. The current implementation of the iASL compiler does not > +support generation of a C header file suitable for including from a C source > +file. > + > +Related Links > +-------------- > + > + > + > + > + > + > +Supported Platforms > +------------------- > +1. Juno > +2. FVP Models > + > +Build Instructions > +------------------ > +1. Set path for the iASL compiler with support for generating a C header > + file as output. > + > +2. Set PACKAGES_PATH to point to the locations of the following repositories: > + > +Example: > + > +> set PACKAGES_PATH=%CD%\edk2;%CD%\edk2-platforms;%CD%\edk2-non-osi > + > + or > + > +> export PACKAGES_PATH=$PWD/edk2:$PWD/edk2-platforms:$PWD/edk2-non-osi > + > +3. To enable Dynamic tables framework the *'DYNAMIC_TABLES_FRAMEWORK'* > +option must be defined. This can be passed as a command line > +parameter to the edk2 build system. > + > +Example: > + > +>build -a AARCH64 -p Platform\ARM\JunoPkg\ArmJuno.dsc > + -t GCC5 **-D DYNAMIC_TABLES_FRAMEWORK** > + > +or > + > +>build -a AARCH64 -p Platform\ARM\VExpressPkg\ArmVExpress-FVP-AArch64.dsc > + -t GCC5 **-D DYNAMIC_TABLES_FRAMEWORK** > + > +Prerequisites > +------------- > +ACPICA iASL compiler with support for generating a C header file. > + > +A patch ***'Add support for hex AML C header file generation'***, to enable > +this support has been submitted to the ACPICA source repository. > + > +Documentation > +------------- > +A description document is in preparation, and should be available in the > +near future. > + > +Miscellaneous > +------------- > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >