From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::231; helo=mail-wm0-x231.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 735A522135D5D for ; Thu, 15 Mar 2018 12:28:07 -0700 (PDT) Received: by mail-wm0-x231.google.com with SMTP id q83so12631631wme.5 for ; Thu, 15 Mar 2018 12:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vH7ZASZ5cocLjo1wQdTK66WjiuN7iUGzNwbi1UJkXxE=; b=gL12IP75u8sm7cqLoGuRlrLrUS4u89cbORtNM6xCRNuuNdqYsgDE+dB9U0pUntlj9I lI3ZHzbNop9a7DOZukHTyFOX31QBgag8KXmZKtqPiQ0v9PnER+OqIOJGN5ZcxxDzdgch Iz0dDA/HKWBy6wXRNd2d2HRpGSLMx34l7V2Dw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vH7ZASZ5cocLjo1wQdTK66WjiuN7iUGzNwbi1UJkXxE=; b=pLpW4zQexLVFPd79b/2ya8hTCDGFBHPYXjNRLBAmw/vPsji2JHity6UAdebIRkXPOX b9QO3NiX0mHrwMAkiBQfoUq+i2CNzQ9rPKO8msPdEkSa/zPgPhhacDbWmsRGIbCKCC0I b4cz5n4tQwzrWnEzn7rjkynQzZWdZ9AhFy30AWVRYRW4FUn3nPwvxkKIDnUJ9Htkm5gk UCwAhS0+9uND1SvSpVUaU28Z+aK3yhQmPY4u6ygWqBhsRgocRl3AujjBlOZ+dko9HiPn gVm/hMPdMoHYk4Awf/NTYtcdmoITg2n/mKNa0IaL2AA4oNF+TqrOE8npItV1xTf0BtVo 2MDg== X-Gm-Message-State: AElRT7HX2Uds2u3UjxHycEv5Xfdvlunio9xIJOkBAHoL46u43oJIyduJ tPBHUaYADxTqBzbtkjNc+lIoxo4+sdw= X-Google-Smtp-Source: AG47ELuSapNrKkFTUxVffw36/CddVAY3yyOibGuhGawj+KJkxjfLtRtriF+WqPIQWaOUDg3DTp8EUA== X-Received: by 10.28.4.216 with SMTP id 207mr5630472wme.108.1521142470398; Thu, 15 Mar 2018 12:34:30 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j42sm6072802wre.55.2018.03.15.12.34.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Mar 2018 12:34:29 -0700 (PDT) Date: Thu, 15 Mar 2018 19:34:27 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20180315193427.l4kfz6ks7eob5xxq@bivouac.eciton.net> References: <20180303112923.13521-1-ard.biesheuvel@linaro.org> <20180315183725.h4vxgrf5ziqiwmyr@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Platform/Socionext/DeveloperBox: add SMBIOS tables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 19:28:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 15, 2018 at 06:43:11PM +0000, Ard Biesheuvel wrote: > On 15 March 2018 at 18:37, Leif Lindholm wrote: > > On Sat, Mar 03, 2018 at 11:29:23AM +0000, Ard Biesheuvel wrote: > >> This adds SMBIOS tables to the DeveloperBox platform describing the > >> BIOS, system, enclosure, CPUs, caches, PCIe slots and system memory, > >> which almost amounts to the mandatory minimum as given by the SMBIOS > >> spec. Only the type 17 structures currently lack detailed information > >> about the DIMMs: the SPDs are on a I2C bus that is only accessible by > >> the SCP, and it currently does not share this information. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Ard Biesheuvel > > > > So, this looks great, but you appear to have generated this patch > > against a working branch (DO_X86EMU, OsInstallerMenuDxe), so it won't > > apply for me automatically. > > Ehm, yes. > > I can respin it if you like? Or you can grab it here > > https://git.linaro.org/leg/noupstream/edk2-platforms.git/ Nah, wasn't hard to resolve manually. So once you've done that and fixed the issue you spotted and I didn't: Reviewed-by: Leif Lindholm / Leif