From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400d:c0d::241; helo=mail-qt0-x241.google.com; envelope-from=gsomlo@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-qt0-x241.google.com (mail-qt0-x241.google.com [IPv6:2607:f8b0:400d:c0d::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 311702095609A for ; Fri, 16 Mar 2018 08:21:14 -0700 (PDT) Received: by mail-qt0-x241.google.com with SMTP id z14so11256392qti.2 for ; Fri, 16 Mar 2018 08:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jVEfSgqdzV6UB2Vd/96EAaetcN2j1jP/u7OcTUD7ap4=; b=W0oynLqQDWxtpJYbzTiFL9urRbepdLhgZqppxF5vDzbIb6L2Kdsnz2lvAE3P2Zy7ds SZMcoyNoAWJys3UOTb8jDkQ7JWVgDmGCXBQ7hnkfrGRdmc1yx6A+EQBCrTGhKvF02Ss4 Rz7mO/fnoxOpAEk3EDQkpRU4oM1PC2AcAdUfRDi5fomjDgH7xYHpMGjfS68kSFqQMtrS BFCFoiaef1/6kA/8lrWTGyp/z0QhbeOCG8taSGNK7/yZEG9mdnsya8Z0n9v73DeLkokt G2QHcwkGXQyqYexn4BliB37nw8oM6ITBaK10GVMNhY3+y8QKqtw0ObrL4y29FyTFuycN qprg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jVEfSgqdzV6UB2Vd/96EAaetcN2j1jP/u7OcTUD7ap4=; b=Ytub4Up3rk6dr3pE/L4BUd22x048b43IGFsRC2b7RM5oHsmIKOtN1MYYy4lLw4sTnJ BHxLPQvpwouD94j8zFxFHckTl+MirCtdSuHskmVxVVCSkBdeBuKds2KwuTUIZhdDIs6O GpkZafYCgFPuL8GujCfkULJdNHTiiQyQYth3Af6kIOaBuR/0ac+4/o4EoOk/t/5rT3G6 49wIUAXJM/h1sRVCOS+JvVNutJOtOBZ//t1r8FzlQisNK5hHH1Me30eykX5eEfUDNEEZ bdVs7gkxHPu1KhawWmhRcSIXJTOEbqjJqRoMSDjbMxeRbRdlDM6W1nQJU+dqmRfKHZq7 HKcQ== X-Gm-Message-State: AElRT7Fkj1bxG8xjJm1hiqW8z//+8E1ll09O2+1MOjVvNh/YRyNc03Rk +XjUYtrez+benWMqmsZs7a0= X-Google-Smtp-Source: AG47ELupGdZqYOEJPic4FimKTNLe0mOcWbsKme6cv6t6F8fKKYcVZh4e/x8ab9dHFG4JcjxH0sAd8A== X-Received: by 10.200.22.145 with SMTP id r17mr3238036qtj.190.1521214058341; Fri, 16 Mar 2018 08:27:38 -0700 (PDT) Received: from hedwig.ini.cmu.edu (HEDWIG.INI.CMU.EDU. [128.2.16.51]) by smtp.gmail.com with ESMTPSA id t82sm3882119qke.52.2018.03.16.08.27.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Mar 2018 08:27:37 -0700 (PDT) Date: Fri, 16 Mar 2018 11:27:33 -0400 From: "Gabriel L. Somlo" To: Laszlo Ersek Cc: edk2-devel-01 , Ard Biesheuvel , Jordan Justen Message-ID: <20180316152731.GA2263@hedwig.ini.cmu.edu> References: <20180315190258.6580-1-lersek@redhat.com> <20180315190258.6580-5-lersek@redhat.com> MIME-Version: 1.0 In-Reply-To: <20180315190258.6580-5-lersek@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [PATCH 4/5] OvmfPkg/PlatformBootManagerLib: hoist PciAcpiInitialization() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 15:21:14 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 15, 2018 at 08:02:57PM +0100, Laszlo Ersek wrote: > PlatformBootManagerAfterConsole() > <--------------------------------+ > PlatformBdsConnectSequence() | > ConnectDevicesFromQemu() / EfiBootManagerConnectAll() | > PciAcpiInitialization() ---------------------------------+ > TryRunningQemuKernel() > > Functionally this is a no-op: > > - PciAcpiInitialization() iterates over PciIo protocol instances, which > are available just the same at the new call site. > > - The PCI interrupt line register exists only to inform system software > (it doesn't affect hardware) and UEFI drivers don't use PCI interrupts > anyway. > > (More background in commits 2e70cf8ade0d and 5218c27950c4.) > > This change will let us move TryRunningQemuKernel() between > PciAcpiInitialization() and PlatformBdsConnectSequence() in the next > patch. > > Cc: "Gabriel L. Somlo" > Cc: Ard Biesheuvel > Cc: Jordan Justen > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > index b155639f3c97..b624b8f22535 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > @@ -1356,14 +1356,12 @@ PlatformBdsConnectSequence ( > // > // Just use the simple policy to connect all devices > // > DEBUG ((DEBUG_INFO, "EfiBootManagerConnectAll\n")); > EfiBootManagerConnectAll (); > } > - > - PciAcpiInitialization (); > } > > /** > Save the S3 boot script. > > Note that DxeSmmReadyToLock must be signaled after this function returns; > @@ -1443,12 +1441,17 @@ PlatformBootManagerAfterConsole ( > > // > // Logo show > // > BootLogoEnableLogo (); > > + // > + // Set PCI Interrupt Line registers and ACPI SCI_EN > + // > + PciAcpiInitialization (); > + Acked-by: Gabriel Somlo > // > // Perform some platform specific connect sequence > // > PlatformBdsConnectSequence (); > > // > -- > 2.14.1.3.gb7cf6e02401b > >