From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1DD4320954B86 for ; Fri, 16 Mar 2018 09:07:13 -0700 (PDT) Received: by mail-wr0-x243.google.com with SMTP id c24so442802wrc.6 for ; Fri, 16 Mar 2018 09:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XMzZam2ekqxCRVuPnZz69gxY464/TRcEPOQ5D7O5r30=; b=RASMuOoLxexUICZcX3w8KpNelmbh7dxY5Xylm8RRmb5YPa7DMMtS2GYdLK8alXW4d3 GsfgKs1VPx5gPoKCFz6bmnlPL2/YSy9plL7L2Z4+rUaX1aCvnB9epRHoODOeFjMvb9nO /F+dcaQa6fGIGy2gUC1RKQBlY/g4kDUh3KZmg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XMzZam2ekqxCRVuPnZz69gxY464/TRcEPOQ5D7O5r30=; b=jn0+LX0k0o4WEMThioLV+ys0Nuy0+c4jegPkL9T0X+MwSh9XTiE2dGT7Q/VRHkc8Ck lsRmHwiYwwxKZqfdvTxpfBUg54VC5JwTKG47oYQ/F8WC5Q8hPbplVopUNRoIuWy2ydKM edpsPnO90P+4zOad9V1BczsFYmyUnvsYEhmQOOOP4vhiwwtHzsZH5GsBWXVMve2c9huB FN9z0qXcKSz030/5i6571+xjWilsPR9XuabuiYtVlhwJoGFLL4Hn+r58a4Q82L+u837A 1bIQI+0KAcSboliOnrWPvmEV8rKbOVqIftDJJKkJTbu6S32Wyy8hbVpfeUeOqfbsvuaW K23w== X-Gm-Message-State: AElRT7H81Wfwbl7MjmgbG0q+5l3BzXAC8rZphcwGOaMCn7U749Dhpivn zZ4eEYWL/jxXO1dQq5oWdx36VuR2AkY= X-Google-Smtp-Source: AG47ELtnYdurn7A9BOCqSKlec1WvgnLwrB1y8H8+ANd2A2YnyFcuMZVr8zMfHFHZ14LpNWFAj4s7hg== X-Received: by 10.223.128.209 with SMTP id 75mr2143667wrl.108.1521216816883; Fri, 16 Mar 2018 09:13:36 -0700 (PDT) Received: from localhost.localdomain ([105.142.191.63]) by smtp.gmail.com with ESMTPSA id n8sm7876242wrf.12.2018.03.16.09.13.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Mar 2018 09:13:36 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org, Ard Biesheuvel Date: Fri, 16 Mar 2018 16:13:20 +0000 Message-Id: <20180316161322.6756-5-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180316161322.6756-1-ard.biesheuvel@linaro.org> References: <20180316161322.6756-1-ard.biesheuvel@linaro.org> Subject: [RFC PATCH edk2-platforms 4/6] Silicon/SynQuacer: make lowest supported f/w version PCD configurable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 16:07:13 -0000 Allow the lowest supported firmware version to be configured by PCD so that each platform can set it individually. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 2 ++ Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc | 2 +- Silicon/Socionext/SynQuacer/SynQuacer.dec | 3 +++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf index 95a5e482a713..db0c9c43b2e5 100644 --- a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf +++ b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf @@ -29,6 +29,7 @@ [Packages] MdeModulePkg/MdeModulePkg.dec MdePkg/MdePkg.dec SignedCapsulePkg/SignedCapsulePkg.dec + Silicon/Socionext/SynQuacer/SynQuacer.dec [LibraryClasses] DebugLib @@ -39,6 +40,7 @@ [LibraryClasses] [FixedPcd] gArmTokenSpaceGuid.PcdFdSize gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareRevision + gSynQuacerTokenSpaceGuid.PcdLowestSupportedFirmwareVersion [Pcd] gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor diff --git a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc index fb69de078313..12a56315a5ab 100644 --- a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc +++ b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc @@ -25,7 +25,7 @@ #define BUILD_STRING(x) L"build #" __BUILD_STRING(x) #define CURRENT_FIRMWARE_VERSION FixedPcdGet32 (PcdFirmwareRevision) #define CURRENT_FIRMWARE_VERSION_STRING BUILD_STRING (FixedPcdGet32 (PcdFirmwareRevision)) -#define LOWEST_SUPPORTED_FIRMWARE_VERSION 0x00000001 +#define LOWEST_SUPPORTED_FIRMWARE_VERSION FixedPcdGet32 (PcdLowestSupportedFirmwareVersion) #define IMAGE_ID SIGNATURE_64('S', 'N', 'D', 'E', 'V', 'B', 'O', 'X') #define IMAGE_ID_STRING L"Socionext Developer Box" diff --git a/Silicon/Socionext/SynQuacer/SynQuacer.dec b/Silicon/Socionext/SynQuacer/SynQuacer.dec index eb4fc4ace2f7..ccaf80def06b 100644 --- a/Silicon/Socionext/SynQuacer/SynQuacer.dec +++ b/Silicon/Socionext/SynQuacer/SynQuacer.dec @@ -44,6 +44,9 @@ [PcdsFixedAtBuild] gSynQuacerTokenSpaceGuid.PcdI2cReferenceClock|62500000|UINT32|0x00000005 + # for capsule update + gSynQuacerTokenSpaceGuid.PcdLowestSupportedFirmwareVersion|1|UINT32|0x00000009 + [PcdsPatchableInModule, PcdsDynamic] # Enable both RC #0 and RC #1 by default gSynQuacerTokenSpaceGuid.PcdPcieEnableMask|0x3|UINT8|0x00000007 -- 2.15.1