From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 089272258AF00 for ; Mon, 19 Mar 2018 01:06:17 -0700 (PDT) Received: by mail-wm0-x244.google.com with SMTP id l9so4247314wmh.2 for ; Mon, 19 Mar 2018 01:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dVFgedkumXm90tPeMXMmVaMKvYXFYA+2cpHFEapG0nk=; b=TR1tLbjDsaLS1Tv+ZPl6IJs856nNt+JKzVSrX8ScjzIB/1FcqiYAISvuNCkUFeGa9m lXf7MI8679gINlYWuKU8HUW3d2Efp+nuwHAMbdH+QTPlNwJkfr4zf/QTiG7TkVmSteYn gG2CrfOBsW3LG5DA5Wh16UXi6Fl++UEkRW8P0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dVFgedkumXm90tPeMXMmVaMKvYXFYA+2cpHFEapG0nk=; b=fMMUAA67axgkAAaxiLM69E2pabEIxNcrz66K7Sdgh75406y006rUcIodYCo1KXUIBt 646YsyQzOydZDpI1at/+q2IQ7OcJCafLVD7D2nW94GRERQllFrxs1To3HZ6izetmsW98 EfhRlcU7cVdcbbOnLFdN6GudhvsdO8BG+xARgPvTj3YPPC/OalM5EVZvJE5+KWR8OSLe zvx2wNOeRDG7j8Qlzy7e4q5AGkDH/ZDEe87prGwbEWmQj1Tn2Y1jM3Oeff2kyw9uJEkl lmpPnuXT0et9kVLlFyQKyuiE4UuN+WCalEVJEDe7Gn+QZC9kjlStVPUHC7Q0U0aaMRSd 9a1w== X-Gm-Message-State: AElRT7HYTLhJEJnbWcEKJlqtaubARy6gO4PWr7DbMJ8QKm9jWWcE4HwV NIYWbVwkKGDzWZRdL2AoeRu29g== X-Google-Smtp-Source: AG47ELvptJ8BLcS+xQDOcaPZtnTPb9RTXNLKqpk7WwzNVYIYPCa5J/pC2s0eQNiNAhA+RpDKnnjifw== X-Received: by 10.28.127.147 with SMTP id a141mr4838282wmd.138.1521447163867; Mon, 19 Mar 2018 01:12:43 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q21sm3094371wra.24.2018.03.19.01.12.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Mar 2018 01:12:42 -0700 (PDT) Date: Mon, 19 Mar 2018 08:12:41 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20180319081240.6ueqdnizbcyutut5@bivouac.eciton.net> References: <20180316161322.6756-1-ard.biesheuvel@linaro.org> <20180316161322.6756-5-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180316161322.6756-5-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [RFC PATCH edk2-platforms 4/6] Silicon/SynQuacer: make lowest supported f/w version PCD configurable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2018 08:06:18 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 16, 2018 at 04:13:20PM +0000, Ard Biesheuvel wrote: > Allow the lowest supported firmware version to be configured by PCD > so that each platform can set it individually. Is there a case for adding this PCD to MdeModulePkg? / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 2 ++ > Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc | 2 +- > Silicon/Socionext/SynQuacer/SynQuacer.dec | 3 +++ > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf > index 95a5e482a713..db0c9c43b2e5 100644 > --- a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf > +++ b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf > @@ -29,6 +29,7 @@ [Packages] > MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > SignedCapsulePkg/SignedCapsulePkg.dec > + Silicon/Socionext/SynQuacer/SynQuacer.dec > > [LibraryClasses] > DebugLib > @@ -39,6 +40,7 @@ [LibraryClasses] > [FixedPcd] > gArmTokenSpaceGuid.PcdFdSize > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareRevision > + gSynQuacerTokenSpaceGuid.PcdLowestSupportedFirmwareVersion > > [Pcd] > gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor > diff --git a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc > index fb69de078313..12a56315a5ab 100644 > --- a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc > +++ b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc > @@ -25,7 +25,7 @@ > #define BUILD_STRING(x) L"build #" __BUILD_STRING(x) > #define CURRENT_FIRMWARE_VERSION FixedPcdGet32 (PcdFirmwareRevision) > #define CURRENT_FIRMWARE_VERSION_STRING BUILD_STRING (FixedPcdGet32 (PcdFirmwareRevision)) > -#define LOWEST_SUPPORTED_FIRMWARE_VERSION 0x00000001 > +#define LOWEST_SUPPORTED_FIRMWARE_VERSION FixedPcdGet32 (PcdLowestSupportedFirmwareVersion) > > #define IMAGE_ID SIGNATURE_64('S', 'N', 'D', 'E', 'V', 'B', 'O', 'X') > #define IMAGE_ID_STRING L"Socionext Developer Box" > diff --git a/Silicon/Socionext/SynQuacer/SynQuacer.dec b/Silicon/Socionext/SynQuacer/SynQuacer.dec > index eb4fc4ace2f7..ccaf80def06b 100644 > --- a/Silicon/Socionext/SynQuacer/SynQuacer.dec > +++ b/Silicon/Socionext/SynQuacer/SynQuacer.dec > @@ -44,6 +44,9 @@ [PcdsFixedAtBuild] > > gSynQuacerTokenSpaceGuid.PcdI2cReferenceClock|62500000|UINT32|0x00000005 > > + # for capsule update > + gSynQuacerTokenSpaceGuid.PcdLowestSupportedFirmwareVersion|1|UINT32|0x00000009 > + > [PcdsPatchableInModule, PcdsDynamic] > # Enable both RC #0 and RC #1 by default > gSynQuacerTokenSpaceGuid.PcdPcieEnableMask|0x3|UINT8|0x00000007 > -- > 2.15.1 >