From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <heyi.guo@linaro.org> Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F14CB225B02A4 for <edk2-devel@lists.01.org>; Tue, 20 Mar 2018 00:48:22 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id 141so1168443iou.12 for <edk2-devel@lists.01.org>; Tue, 20 Mar 2018 00:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ICIwXxMTdkPMgWG8sIRhdL6AJaSFUJDcsmBvc3kkbDs=; b=d70kK92D1CQphiyG3R7OKXbFv/RiJ3l5JQPkGSq1wExVZczfOtLLAi68UAkezKAl8w XJrra/0e3OMpi1R3T7j7rEHY0yHyB7ZsQnO/X1ptnN7TrLUPOqiGupPvVQVfiktqZRgO 0yat4MUy8AyHa4Hp7dAtlGFfB+tAsL/ljQjDw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ICIwXxMTdkPMgWG8sIRhdL6AJaSFUJDcsmBvc3kkbDs=; b=SmNb0jwWa42zoOMB/tkdDesPmfKuQmYIhUrQOBZ2L5TR9BVXOopNllgZpc8SI/ZZjX Rz1vnBYsJvuGIEgSlEqhkDXqEVHDz8Tsi2ppx2Em8a4kC/8a9b9y/3bwMFHc+IiHP0no T6A5tyh3uqWw9NEcO5Uh21q9NV307w6+PP6kLLNtsho5J4Zh6sJg1icB9zNdv0dy6g5f zUm4q89Q5J+WygNS0Y9gJ/odMa1MyW3cHLb2SvepQyFU/hLlbINMmRhrQ7YRmr7QMLvg eO8M5wXPgSWOLoAlZl3IYfD5o8FZdLn68ITCicSOIX7laDEDP+kDZivVvrML3uO1G8mZ 4s8Q== X-Gm-Message-State: AElRT7FDArNAqCVyuNS5XGnfxlQB8cRZUhGa0Hk0VePjOoxTjv9jdqY/ 5qFwSTvv8F3irci3OoCeOVLmj/PfX+s= X-Google-Smtp-Source: AG47ELtCdtM6gAuhlmJ7i/Ry6lL1L/3V3VieWXYxzdwaB6ioVuLg04rqe6xV093x7AopxsXrhsYw1Q== X-Received: by 10.107.95.23 with SMTP id t23mr15984603iob.242.1521532490760; Tue, 20 Mar 2018 00:54:50 -0700 (PDT) Received: from SZX1000114654 ([45.56.152.100]) by smtp.gmail.com with ESMTPSA id l7sm745262ioe.50.2018.03.20.00.54.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Mar 2018 00:54:50 -0700 (PDT) From: Guo Heyi <heyi.guo@linaro.org> X-Google-Original-From: Guo Heyi <g00179230@SZX1000114654> Date: Tue, 20 Mar 2018 15:54:46 +0800 To: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Heyi Guo <heyi.guo@linaro.org>, "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>, Leif Lindholm <leif.lindholm@linaro.org> Message-ID: <20180320075446.GH125210@SZX1000114654> References: <1520391833-9344-1-git-send-email-heyi.guo@linaro.org> <1520391833-9344-2-git-send-email-heyi.guo@linaro.org> <CAKv+Gu_U8-uYkoV7oprcGijRZcMLyY0Q9q6H_LotjfwJhj+=ww@mail.gmail.com> MIME-Version: 1.0 In-Reply-To: <CAKv+Gu_U8-uYkoV7oprcGijRZcMLyY0Q9q6H_LotjfwJhj+=ww@mail.gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development <edk2-devel.lists.01.org> List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>, <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe> List-Archive: <http://lists.01.org/pipermail/edk2-devel/> List-Post: <mailto:edk2-devel@lists.01.org> List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help> List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>, <mailto:edk2-devel-request@lists.01.org?subject=subscribe> X-List-Received-Date: Tue, 20 Mar 2018 07:48:23 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Ping :) On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > On 7 March 2018 at 03:03, Heyi Guo <heyi.guo@linaro.org> wrote: > > Since D0x platforms always have network enabled, we would like to > > enable tftp command by default so that we can download something in > > EFI Shell. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > The first patch looks fine to me, but I would like to give Leif a > chance to comment on the policy side of this patch. > > Please ping us by the end of next week if we haven't responded by then. > > > --- > > Platform/Hisilicon/D03/D03.dsc | 2 ++ > > Platform/Hisilicon/D05/D05.dsc | 1 + > > 2 files changed, 3 insertions(+) > > > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > index cb0669d639d1..fce1e60b1275 100644 > > --- a/Platform/Hisilicon/D03/D03.dsc > > +++ b/Platform/Hisilicon/D03/D03.dsc > > @@ -29,6 +29,8 @@ [Defines] > > SKUID_IDENTIFIER = DEFAULT > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > + > > !include Silicon/Hisilicon/Hisilicon.dsc.inc > > > > [LibraryClasses.common] > > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > index 8373a821a496..f007f3d2d7e8 100644 > > --- a/Platform/Hisilicon/D05/D05.dsc > > +++ b/Platform/Hisilicon/D05/D05.dsc > > @@ -29,6 +29,7 @@ [Defines] > > SKUID_IDENTIFIER = DEFAULT > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > DEFINE EDK2_SKIP_PEICORE=0 > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > DEFINE NETWORK_IP6_ENABLE = FALSE > > DEFINE HTTP_BOOT_ENABLE = FALSE > > > > -- > > 2.7.4 > >