* [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure @ 2018-03-07 3:03 Heyi Guo 2018-03-07 3:03 ` [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default Heyi Guo 2018-04-18 10:59 ` [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure Leif Lindholm 0 siblings, 2 replies; 12+ messages in thread From: Heyi Guo @ 2018-03-07 3:03 UTC (permalink / raw) To: edk2-devel; +Cc: Heyi Guo, Ard Biesheuvel, Leif Lindholm We need to set PcdShellLibAutoInitialize to FALSE for TftpDynamicCommand, or else we will get initialization failure when loading TftpDynamicCommand module, for EFI Shell has not been started at this moment. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo <heyi.guo@linaro.org> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Leif Lindholm <leif.lindholm@linaro.org> --- Platform/Hisilicon/D03/D03.dsc | 5 ++++- Platform/Hisilicon/D05/D05.dsc | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc index c4963063794b..cb0669d639d1 100644 --- a/Platform/Hisilicon/D03/D03.dsc +++ b/Platform/Hisilicon/D03/D03.dsc @@ -517,5 +517,8 @@ [Components.common] gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 } !ifdef $(INCLUDE_TFTP_COMMAND) - ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { + <PcdsFixedAtBuild> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE + } !endif #$(INCLUDE_TFTP_COMMAND) diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc index 0792b0814ea1..8373a821a496 100644 --- a/Platform/Hisilicon/D05/D05.dsc +++ b/Platform/Hisilicon/D05/D05.dsc @@ -675,5 +675,8 @@ [Components.common] gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 } !ifdef $(INCLUDE_TFTP_COMMAND) - ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { + <PcdsFixedAtBuild> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE + } !endif #$(INCLUDE_TFTP_COMMAND) -- 2.7.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default 2018-03-07 3:03 [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure Heyi Guo @ 2018-03-07 3:03 ` Heyi Guo 2018-03-07 16:02 ` Ard Biesheuvel 2018-04-18 10:59 ` [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure Leif Lindholm 1 sibling, 1 reply; 12+ messages in thread From: Heyi Guo @ 2018-03-07 3:03 UTC (permalink / raw) To: edk2-devel; +Cc: Heyi Guo, Ard Biesheuvel, Leif Lindholm Since D0x platforms always have network enabled, we would like to enable tftp command by default so that we can download something in EFI Shell. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo <heyi.guo@linaro.org> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Leif Lindholm <leif.lindholm@linaro.org> --- Platform/Hisilicon/D03/D03.dsc | 2 ++ Platform/Hisilicon/D05/D05.dsc | 1 + 2 files changed, 3 insertions(+) diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc index cb0669d639d1..fce1e60b1275 100644 --- a/Platform/Hisilicon/D03/D03.dsc +++ b/Platform/Hisilicon/D03/D03.dsc @@ -29,6 +29,8 @@ [Defines] SKUID_IDENTIFIER = DEFAULT FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf + DEFINE INCLUDE_TFTP_COMMAND = TRUE + !include Silicon/Hisilicon/Hisilicon.dsc.inc [LibraryClasses.common] diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc index 8373a821a496..f007f3d2d7e8 100644 --- a/Platform/Hisilicon/D05/D05.dsc +++ b/Platform/Hisilicon/D05/D05.dsc @@ -29,6 +29,7 @@ [Defines] SKUID_IDENTIFIER = DEFAULT FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf DEFINE EDK2_SKIP_PEICORE=0 + DEFINE INCLUDE_TFTP_COMMAND = TRUE DEFINE NETWORK_IP6_ENABLE = FALSE DEFINE HTTP_BOOT_ENABLE = FALSE -- 2.7.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default 2018-03-07 3:03 ` [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default Heyi Guo @ 2018-03-07 16:02 ` Ard Biesheuvel 2018-03-20 7:54 ` Guo Heyi 0 siblings, 1 reply; 12+ messages in thread From: Ard Biesheuvel @ 2018-03-07 16:02 UTC (permalink / raw) To: Heyi Guo; +Cc: edk2-devel@lists.01.org, Leif Lindholm On 7 March 2018 at 03:03, Heyi Guo <heyi.guo@linaro.org> wrote: > Since D0x platforms always have network enabled, we would like to > enable tftp command by default so that we can download something in > EFI Shell. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Leif Lindholm <leif.lindholm@linaro.org> The first patch looks fine to me, but I would like to give Leif a chance to comment on the policy side of this patch. Please ping us by the end of next week if we haven't responded by then. > --- > Platform/Hisilicon/D03/D03.dsc | 2 ++ > Platform/Hisilicon/D05/D05.dsc | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > index cb0669d639d1..fce1e60b1275 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -29,6 +29,8 @@ [Defines] > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > + > !include Silicon/Hisilicon/Hisilicon.dsc.inc > > [LibraryClasses.common] > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > index 8373a821a496..f007f3d2d7e8 100644 > --- a/Platform/Hisilicon/D05/D05.dsc > +++ b/Platform/Hisilicon/D05/D05.dsc > @@ -29,6 +29,7 @@ [Defines] > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > DEFINE EDK2_SKIP_PEICORE=0 > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > DEFINE NETWORK_IP6_ENABLE = FALSE > DEFINE HTTP_BOOT_ENABLE = FALSE > > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default 2018-03-07 16:02 ` Ard Biesheuvel @ 2018-03-20 7:54 ` Guo Heyi 2018-03-20 9:51 ` Leif Lindholm 0 siblings, 1 reply; 12+ messages in thread From: Guo Heyi @ 2018-03-20 7:54 UTC (permalink / raw) To: Ard Biesheuvel; +Cc: Heyi Guo, edk2-devel@lists.01.org, Leif Lindholm Ping :) On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > On 7 March 2018 at 03:03, Heyi Guo <heyi.guo@linaro.org> wrote: > > Since D0x platforms always have network enabled, we would like to > > enable tftp command by default so that we can download something in > > EFI Shell. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > The first patch looks fine to me, but I would like to give Leif a > chance to comment on the policy side of this patch. > > Please ping us by the end of next week if we haven't responded by then. > > > --- > > Platform/Hisilicon/D03/D03.dsc | 2 ++ > > Platform/Hisilicon/D05/D05.dsc | 1 + > > 2 files changed, 3 insertions(+) > > > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > index cb0669d639d1..fce1e60b1275 100644 > > --- a/Platform/Hisilicon/D03/D03.dsc > > +++ b/Platform/Hisilicon/D03/D03.dsc > > @@ -29,6 +29,8 @@ [Defines] > > SKUID_IDENTIFIER = DEFAULT > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > + > > !include Silicon/Hisilicon/Hisilicon.dsc.inc > > > > [LibraryClasses.common] > > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > index 8373a821a496..f007f3d2d7e8 100644 > > --- a/Platform/Hisilicon/D05/D05.dsc > > +++ b/Platform/Hisilicon/D05/D05.dsc > > @@ -29,6 +29,7 @@ [Defines] > > SKUID_IDENTIFIER = DEFAULT > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > DEFINE EDK2_SKIP_PEICORE=0 > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > DEFINE NETWORK_IP6_ENABLE = FALSE > > DEFINE HTTP_BOOT_ENABLE = FALSE > > > > -- > > 2.7.4 > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default 2018-03-20 7:54 ` Guo Heyi @ 2018-03-20 9:51 ` Leif Lindholm 2018-03-20 12:15 ` Guo Heyi 0 siblings, 1 reply; 12+ messages in thread From: Leif Lindholm @ 2018-03-20 9:51 UTC (permalink / raw) To: Guo Heyi; +Cc: Ard Biesheuvel, edk2-devel@lists.01.org Ah, apologies. I would be reluctant to add commands not covered by the UEFI Shell Specification by default. Since it is now a dynamic command, is there any way of loading this dynamically (perhaps via DRIVER####) where you feel the need for it? / Leif On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > Ping :) > > > On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > > On 7 March 2018 at 03:03, Heyi Guo <heyi.guo@linaro.org> wrote: > > > Since D0x platforms always have network enabled, we would like to > > > enable tftp command by default so that we can download something in > > > EFI Shell. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > > > The first patch looks fine to me, but I would like to give Leif a > > chance to comment on the policy side of this patch. > > > > Please ping us by the end of next week if we haven't responded by then. > > > > > --- > > > Platform/Hisilicon/D03/D03.dsc | 2 ++ > > > Platform/Hisilicon/D05/D05.dsc | 1 + > > > 2 files changed, 3 insertions(+) > > > > > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > > index cb0669d639d1..fce1e60b1275 100644 > > > --- a/Platform/Hisilicon/D03/D03.dsc > > > +++ b/Platform/Hisilicon/D03/D03.dsc > > > @@ -29,6 +29,8 @@ [Defines] > > > SKUID_IDENTIFIER = DEFAULT > > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > > > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > + > > > !include Silicon/Hisilicon/Hisilicon.dsc.inc > > > > > > [LibraryClasses.common] > > > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > > index 8373a821a496..f007f3d2d7e8 100644 > > > --- a/Platform/Hisilicon/D05/D05.dsc > > > +++ b/Platform/Hisilicon/D05/D05.dsc > > > @@ -29,6 +29,7 @@ [Defines] > > > SKUID_IDENTIFIER = DEFAULT > > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > DEFINE EDK2_SKIP_PEICORE=0 > > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > DEFINE NETWORK_IP6_ENABLE = FALSE > > > DEFINE HTTP_BOOT_ENABLE = FALSE > > > > > > -- > > > 2.7.4 > > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default 2018-03-20 9:51 ` Leif Lindholm @ 2018-03-20 12:15 ` Guo Heyi 2018-03-23 4:51 ` Ni, Ruiyu 0 siblings, 1 reply; 12+ messages in thread From: Guo Heyi @ 2018-03-20 12:15 UTC (permalink / raw) To: Leif Lindholm; +Cc: Guo Heyi, Ard Biesheuvel, edk2-devel@lists.01.org I've no idea about how to use Driver####; let me spend some time to learn first :) Regards, Heyi On Tue, Mar 20, 2018 at 09:51:32AM +0000, Leif Lindholm wrote: > Ah, apologies. > > I would be reluctant to add commands not covered by the UEFI Shell > Specification by default. > > Since it is now a dynamic command, is there any way of loading this > dynamically (perhaps via DRIVER####) where you feel the need for it? > > / > Leif > > On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > > Ping :) > > > > > > On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > > > On 7 March 2018 at 03:03, Heyi Guo <heyi.guo@linaro.org> wrote: > > > > Since D0x platforms always have network enabled, we would like to > > > > enable tftp command by default so that we can download something in > > > > EFI Shell. > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > > > > > The first patch looks fine to me, but I would like to give Leif a > > > chance to comment on the policy side of this patch. > > > > > > Please ping us by the end of next week if we haven't responded by then. > > > > > > > --- > > > > Platform/Hisilicon/D03/D03.dsc | 2 ++ > > > > Platform/Hisilicon/D05/D05.dsc | 1 + > > > > 2 files changed, 3 insertions(+) > > > > > > > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > > > index cb0669d639d1..fce1e60b1275 100644 > > > > --- a/Platform/Hisilicon/D03/D03.dsc > > > > +++ b/Platform/Hisilicon/D03/D03.dsc > > > > @@ -29,6 +29,8 @@ [Defines] > > > > SKUID_IDENTIFIER = DEFAULT > > > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > > > > > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > > + > > > > !include Silicon/Hisilicon/Hisilicon.dsc.inc > > > > > > > > [LibraryClasses.common] > > > > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > > > index 8373a821a496..f007f3d2d7e8 100644 > > > > --- a/Platform/Hisilicon/D05/D05.dsc > > > > +++ b/Platform/Hisilicon/D05/D05.dsc > > > > @@ -29,6 +29,7 @@ [Defines] > > > > SKUID_IDENTIFIER = DEFAULT > > > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > > DEFINE EDK2_SKIP_PEICORE=0 > > > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > > DEFINE NETWORK_IP6_ENABLE = FALSE > > > > DEFINE HTTP_BOOT_ENABLE = FALSE > > > > > > > > -- > > > > 2.7.4 > > > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default 2018-03-20 12:15 ` Guo Heyi @ 2018-03-23 4:51 ` Ni, Ruiyu 2018-03-26 9:03 ` Guo Heyi 0 siblings, 1 reply; 12+ messages in thread From: Ni, Ruiyu @ 2018-03-23 4:51 UTC (permalink / raw) To: edk2-devel On 3/20/2018 8:15 PM, Guo Heyi wrote: > I've no idea about how to use Driver####; let me spend some time to learn first > :) Heyi, you could use "load xxxDriver.efi" to load the dynamic command in shell. After that, you can run "tftp" in shell just as running an internal command. > > Regards, > > Heyi > > On Tue, Mar 20, 2018 at 09:51:32AM +0000, Leif Lindholm wrote: >> Ah, apologies. >> >> I would be reluctant to add commands not covered by the UEFI Shell >> Specification by default. >> >> Since it is now a dynamic command, is there any way of loading this >> dynamically (perhaps via DRIVER####) where you feel the need for it? >> >> / >> Leif >> >> On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: >>> Ping :) >>> >>> >>> On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: >>>> On 7 March 2018 at 03:03, Heyi Guo <heyi.guo@linaro.org> wrote: >>>>> Since D0x platforms always have network enabled, we would like to >>>>> enable tftp command by default so that we can download something in >>>>> EFI Shell. >>>>> >>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>> Signed-off-by: Heyi Guo <heyi.guo@linaro.org> >>>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> >>>>> Cc: Leif Lindholm <leif.lindholm@linaro.org> >>>> >>>> The first patch looks fine to me, but I would like to give Leif a >>>> chance to comment on the policy side of this patch. >>>> >>>> Please ping us by the end of next week if we haven't responded by then. >>>> >>>>> --- >>>>> Platform/Hisilicon/D03/D03.dsc | 2 ++ >>>>> Platform/Hisilicon/D05/D05.dsc | 1 + >>>>> 2 files changed, 3 insertions(+) >>>>> >>>>> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc >>>>> index cb0669d639d1..fce1e60b1275 100644 >>>>> --- a/Platform/Hisilicon/D03/D03.dsc >>>>> +++ b/Platform/Hisilicon/D03/D03.dsc >>>>> @@ -29,6 +29,8 @@ [Defines] >>>>> SKUID_IDENTIFIER = DEFAULT >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf >>>>> >>>>> + DEFINE INCLUDE_TFTP_COMMAND = TRUE >>>>> + >>>>> !include Silicon/Hisilicon/Hisilicon.dsc.inc >>>>> >>>>> [LibraryClasses.common] >>>>> diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc >>>>> index 8373a821a496..f007f3d2d7e8 100644 >>>>> --- a/Platform/Hisilicon/D05/D05.dsc >>>>> +++ b/Platform/Hisilicon/D05/D05.dsc >>>>> @@ -29,6 +29,7 @@ [Defines] >>>>> SKUID_IDENTIFIER = DEFAULT >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf >>>>> DEFINE EDK2_SKIP_PEICORE=0 >>>>> + DEFINE INCLUDE_TFTP_COMMAND = TRUE >>>>> DEFINE NETWORK_IP6_ENABLE = FALSE >>>>> DEFINE HTTP_BOOT_ENABLE = FALSE >>>>> >>>>> -- >>>>> 2.7.4 >>>>> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > -- Thanks, Ray ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default 2018-03-23 4:51 ` Ni, Ruiyu @ 2018-03-26 9:03 ` Guo Heyi 2018-04-02 2:51 ` Guo Heyi 0 siblings, 1 reply; 12+ messages in thread From: Guo Heyi @ 2018-03-26 9:03 UTC (permalink / raw) To: Ni, Ruiyu; +Cc: edk2-devel Thanks Ray. Does that mean we need build the dynamic command driver separately and store it in other media instead of UEFI fd image? Right now if I include the driver into the fd image, it will be automatically added to EFI Shell command list; we don't need to run the load command. Hi Leif, Is the policy to forbid including dynamic command driver into UEFI fd image? If we need other media to store tftp command driver, then the command will become less useful, because it is mainly used to download something else. If we have other media like USB disk, we can use this "other media" instead of network download to store the final target. Thanks, Heyi On Fri, Mar 23, 2018 at 12:51:45PM +0800, Ni, Ruiyu wrote: > On 3/20/2018 8:15 PM, Guo Heyi wrote: > >I've no idea about how to use Driver####; let me spend some time to learn first > >:) > > Heyi, > you could use "load xxxDriver.efi" to load the dynamic command in shell. > After that, you can run "tftp" in shell just as running an internal command. > > > > >Regards, > > > >Heyi > > > >On Tue, Mar 20, 2018 at 09:51:32AM +0000, Leif Lindholm wrote: > >>Ah, apologies. > >> > >>I would be reluctant to add commands not covered by the UEFI Shell > >>Specification by default. > >> > >>Since it is now a dynamic command, is there any way of loading this > >>dynamically (perhaps via DRIVER####) where you feel the need for it? > >> > >>/ > >> Leif > >> > >>On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > >>>Ping :) > >>> > >>> > >>>On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > >>>>On 7 March 2018 at 03:03, Heyi Guo <heyi.guo@linaro.org> wrote: > >>>>>Since D0x platforms always have network enabled, we would like to > >>>>>enable tftp command by default so that we can download something in > >>>>>EFI Shell. > >>>>> > >>>>>Contributed-under: TianoCore Contribution Agreement 1.1 > >>>>>Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > >>>>>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > >>>>>Cc: Leif Lindholm <leif.lindholm@linaro.org> > >>>> > >>>>The first patch looks fine to me, but I would like to give Leif a > >>>>chance to comment on the policy side of this patch. > >>>> > >>>>Please ping us by the end of next week if we haven't responded by then. > >>>> > >>>>>--- > >>>>> Platform/Hisilicon/D03/D03.dsc | 2 ++ > >>>>> Platform/Hisilicon/D05/D05.dsc | 1 + > >>>>> 2 files changed, 3 insertions(+) > >>>>> > >>>>>diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > >>>>>index cb0669d639d1..fce1e60b1275 100644 > >>>>>--- a/Platform/Hisilicon/D03/D03.dsc > >>>>>+++ b/Platform/Hisilicon/D03/D03.dsc > >>>>>@@ -29,6 +29,8 @@ [Defines] > >>>>> SKUID_IDENTIFIER = DEFAULT > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > >>>>> > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > >>>>>+ > >>>>> !include Silicon/Hisilicon/Hisilicon.dsc.inc > >>>>> > >>>>> [LibraryClasses.common] > >>>>>diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > >>>>>index 8373a821a496..f007f3d2d7e8 100644 > >>>>>--- a/Platform/Hisilicon/D05/D05.dsc > >>>>>+++ b/Platform/Hisilicon/D05/D05.dsc > >>>>>@@ -29,6 +29,7 @@ [Defines] > >>>>> SKUID_IDENTIFIER = DEFAULT > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > >>>>> DEFINE EDK2_SKIP_PEICORE=0 > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > >>>>> DEFINE NETWORK_IP6_ENABLE = FALSE > >>>>> DEFINE HTTP_BOOT_ENABLE = FALSE > >>>>> > >>>>>-- > >>>>>2.7.4 > >>>>> > >_______________________________________________ > >edk2-devel mailing list > >edk2-devel@lists.01.org > >https://lists.01.org/mailman/listinfo/edk2-devel > > > > > -- > Thanks, > Ray > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default 2018-03-26 9:03 ` Guo Heyi @ 2018-04-02 2:51 ` Guo Heyi 2018-04-16 12:33 ` Leif Lindholm 0 siblings, 1 reply; 12+ messages in thread From: Guo Heyi @ 2018-04-02 2:51 UTC (permalink / raw) To: edk2-devel; +Cc: Ni, Ruiyu, Leif Lindholm Hi Ray and Leif, Any comments? On Mon, Mar 26, 2018 at 05:03:10PM +0800, Guo Heyi wrote: > Thanks Ray. > > Does that mean we need build the dynamic command driver separately and store it > in other media instead of UEFI fd image? Right now if I include the driver into > the fd image, it will be automatically added to EFI Shell command list; we don't > need to run the load command. > > Hi Leif, > > Is the policy to forbid including dynamic command driver into UEFI fd image? > > If we need other media to store tftp command driver, then the command will > become less useful, because it is mainly used to download something else. If we > have other media like USB disk, we can use this "other media" instead of network > download to store the final target. > > Thanks, > Heyi > > On Fri, Mar 23, 2018 at 12:51:45PM +0800, Ni, Ruiyu wrote: > > On 3/20/2018 8:15 PM, Guo Heyi wrote: > > >I've no idea about how to use Driver####; let me spend some time to learn first > > >:) > > > > Heyi, > > you could use "load xxxDriver.efi" to load the dynamic command in shell. > > After that, you can run "tftp" in shell just as running an internal command. > > > > > > > >Regards, > > > > > >Heyi > > > > > >On Tue, Mar 20, 2018 at 09:51:32AM +0000, Leif Lindholm wrote: > > >>Ah, apologies. > > >> > > >>I would be reluctant to add commands not covered by the UEFI Shell > > >>Specification by default. > > >> > > >>Since it is now a dynamic command, is there any way of loading this > > >>dynamically (perhaps via DRIVER####) where you feel the need for it? > > >> > > >>/ > > >> Leif > > >> > > >>On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > > >>>Ping :) > > >>> > > >>> > > >>>On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > > >>>>On 7 March 2018 at 03:03, Heyi Guo <heyi.guo@linaro.org> wrote: > > >>>>>Since D0x platforms always have network enabled, we would like to > > >>>>>enable tftp command by default so that we can download something in > > >>>>>EFI Shell. > > >>>>> > > >>>>>Contributed-under: TianoCore Contribution Agreement 1.1 > > >>>>>Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > > >>>>>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > >>>>>Cc: Leif Lindholm <leif.lindholm@linaro.org> > > >>>> > > >>>>The first patch looks fine to me, but I would like to give Leif a > > >>>>chance to comment on the policy side of this patch. > > >>>> > > >>>>Please ping us by the end of next week if we haven't responded by then. > > >>>> > > >>>>>--- > > >>>>> Platform/Hisilicon/D03/D03.dsc | 2 ++ > > >>>>> Platform/Hisilicon/D05/D05.dsc | 1 + > > >>>>> 2 files changed, 3 insertions(+) > > >>>>> > > >>>>>diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > >>>>>index cb0669d639d1..fce1e60b1275 100644 > > >>>>>--- a/Platform/Hisilicon/D03/D03.dsc > > >>>>>+++ b/Platform/Hisilicon/D03/D03.dsc > > >>>>>@@ -29,6 +29,8 @@ [Defines] > > >>>>> SKUID_IDENTIFIER = DEFAULT > > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > >>>>> > > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > > >>>>>+ > > >>>>> !include Silicon/Hisilicon/Hisilicon.dsc.inc > > >>>>> > > >>>>> [LibraryClasses.common] > > >>>>>diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > >>>>>index 8373a821a496..f007f3d2d7e8 100644 > > >>>>>--- a/Platform/Hisilicon/D05/D05.dsc > > >>>>>+++ b/Platform/Hisilicon/D05/D05.dsc > > >>>>>@@ -29,6 +29,7 @@ [Defines] > > >>>>> SKUID_IDENTIFIER = DEFAULT > > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > >>>>> DEFINE EDK2_SKIP_PEICORE=0 > > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > > >>>>> DEFINE NETWORK_IP6_ENABLE = FALSE > > >>>>> DEFINE HTTP_BOOT_ENABLE = FALSE > > >>>>> > > >>>>>-- > > >>>>>2.7.4 > > >>>>> > > >_______________________________________________ > > >edk2-devel mailing list > > >edk2-devel@lists.01.org > > >https://lists.01.org/mailman/listinfo/edk2-devel > > > > > > > > > -- > > Thanks, > > Ray > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default 2018-04-02 2:51 ` Guo Heyi @ 2018-04-16 12:33 ` Leif Lindholm 2018-04-17 1:58 ` Guo Heyi 0 siblings, 1 reply; 12+ messages in thread From: Leif Lindholm @ 2018-04-16 12:33 UTC (permalink / raw) To: Guo Heyi; +Cc: edk2-devel, Ni, Ruiyu On Mon, Apr 02, 2018 at 10:51:53AM +0800, Guo Heyi wrote: > Hi Ray and Leif, > > Any comments? > > > On Mon, Mar 26, 2018 at 05:03:10PM +0800, Guo Heyi wrote: > > Thanks Ray. > > > > Does that mean we need build the dynamic command driver separately and store it > > in other media instead of UEFI fd image? Right now if I include the driver into > > the fd image, it will be automatically added to EFI Shell command list; we don't > > need to run the load command. > > > > Hi Leif, > > > > Is the policy to forbid including dynamic command driver into UEFI fd image? Let's just say that I am highly reluctant to have commands not covered by the UEFI Shell specification included by default. Especially commands that we know from experience have been misused in order to not have to figure out a sensible way of doing something properly ... and then been copied to new platforms by new developers coming in and looking at existing ports for reference. > > If we need other media to store tftp command driver, then the command will > > become less useful, because it is mainly used to download something else. If we > > have other media like USB disk, we can use this "other media" instead of network > > download to store the final target. If you are building a development image, by all means specify an appropriate build flag and have additional debug features built in. But if you are looking to use this for non-development builds, I would very much like to hear your use-case. Best Regards, Leif > > Thanks, > > Heyi > > > > On Fri, Mar 23, 2018 at 12:51:45PM +0800, Ni, Ruiyu wrote: > > > On 3/20/2018 8:15 PM, Guo Heyi wrote: > > > >I've no idea about how to use Driver####; let me spend some time to learn first > > > >:) > > > > > > Heyi, > > > you could use "load xxxDriver.efi" to load the dynamic command in shell. > > > After that, you can run "tftp" in shell just as running an internal command. > > > > > > > > > > >Regards, > > > > > > > >Heyi > > > > > > > >On Tue, Mar 20, 2018 at 09:51:32AM +0000, Leif Lindholm wrote: > > > >>Ah, apologies. > > > >> > > > >>I would be reluctant to add commands not covered by the UEFI Shell > > > >>Specification by default. > > > >> > > > >>Since it is now a dynamic command, is there any way of loading this > > > >>dynamically (perhaps via DRIVER####) where you feel the need for it? > > > >> > > > >>/ > > > >> Leif > > > >> > > > >>On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > > > >>>Ping :) > > > >>> > > > >>> > > > >>>On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > > > >>>>On 7 March 2018 at 03:03, Heyi Guo <heyi.guo@linaro.org> wrote: > > > >>>>>Since D0x platforms always have network enabled, we would like to > > > >>>>>enable tftp command by default so that we can download something in > > > >>>>>EFI Shell. > > > >>>>> > > > >>>>>Contributed-under: TianoCore Contribution Agreement 1.1 > > > >>>>>Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > > > >>>>>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > >>>>>Cc: Leif Lindholm <leif.lindholm@linaro.org> > > > >>>> > > > >>>>The first patch looks fine to me, but I would like to give Leif a > > > >>>>chance to comment on the policy side of this patch. > > > >>>> > > > >>>>Please ping us by the end of next week if we haven't responded by then. > > > >>>> > > > >>>>>--- > > > >>>>> Platform/Hisilicon/D03/D03.dsc | 2 ++ > > > >>>>> Platform/Hisilicon/D05/D05.dsc | 1 + > > > >>>>> 2 files changed, 3 insertions(+) > > > >>>>> > > > >>>>>diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > > >>>>>index cb0669d639d1..fce1e60b1275 100644 > > > >>>>>--- a/Platform/Hisilicon/D03/D03.dsc > > > >>>>>+++ b/Platform/Hisilicon/D03/D03.dsc > > > >>>>>@@ -29,6 +29,8 @@ [Defines] > > > >>>>> SKUID_IDENTIFIER = DEFAULT > > > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > >>>>> > > > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > >>>>>+ > > > >>>>> !include Silicon/Hisilicon/Hisilicon.dsc.inc > > > >>>>> > > > >>>>> [LibraryClasses.common] > > > >>>>>diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > > >>>>>index 8373a821a496..f007f3d2d7e8 100644 > > > >>>>>--- a/Platform/Hisilicon/D05/D05.dsc > > > >>>>>+++ b/Platform/Hisilicon/D05/D05.dsc > > > >>>>>@@ -29,6 +29,7 @@ [Defines] > > > >>>>> SKUID_IDENTIFIER = DEFAULT > > > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > >>>>> DEFINE EDK2_SKIP_PEICORE=0 > > > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > >>>>> DEFINE NETWORK_IP6_ENABLE = FALSE > > > >>>>> DEFINE HTTP_BOOT_ENABLE = FALSE > > > >>>>> > > > >>>>>-- > > > >>>>>2.7.4 > > > >>>>> > > > >_______________________________________________ > > > >edk2-devel mailing list > > > >edk2-devel@lists.01.org > > > >https://lists.01.org/mailman/listinfo/edk2-devel > > > > > > > > > > > > > -- > > > Thanks, > > > Ray > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default 2018-04-16 12:33 ` Leif Lindholm @ 2018-04-17 1:58 ` Guo Heyi 0 siblings, 0 replies; 12+ messages in thread From: Guo Heyi @ 2018-04-17 1:58 UTC (permalink / raw) To: Leif Lindholm; +Cc: Guo Heyi, edk2-devel, Ni, Ruiyu On Mon, Apr 16, 2018 at 01:33:56PM +0100, Leif Lindholm wrote: > On Mon, Apr 02, 2018 at 10:51:53AM +0800, Guo Heyi wrote: > > Hi Ray and Leif, > > > > Any comments? > > > > > > On Mon, Mar 26, 2018 at 05:03:10PM +0800, Guo Heyi wrote: > > > Thanks Ray. > > > > > > Does that mean we need build the dynamic command driver separately and store it > > > in other media instead of UEFI fd image? Right now if I include the driver into > > > the fd image, it will be automatically added to EFI Shell command list; we don't > > > need to run the load command. > > > > > > Hi Leif, > > > > > > Is the policy to forbid including dynamic command driver into UEFI fd image? > > Let's just say that I am highly reluctant to have commands not covered > by the UEFI Shell specification included by default. Especially > commands that we know from experience have been misused in order to > not have to figure out a sensible way of doing something properly > ... and then been copied to new platforms by new developers coming in > and looking at existing ports for reference. > > > > If we need other media to store tftp command driver, then the command will > > > become less useful, because it is mainly used to download something else. If we > > > have other media like USB disk, we can use this "other media" instead of network > > > download to store the final target. > > If you are building a development image, by all means specify an > appropriate build flag and have additional debug features built in. > > But if you are looking to use this for non-development builds, I would > very much like to hear your use-case. In our company, network is much more feasible than other media like USB stick, so that we can easily run some external applications or OS loaders. And USB stick is also restricted for security concerns. Anyway, appending a build flag is still acceptable for us, for we can add the flag in our internal build script for development. But patch 1/2 is still needed, or else tftp will initialize failed even if we manually set the define flag. Thanks, Heyi > > Best Regards, > > Leif > > > > Thanks, > > > Heyi > > > > > > On Fri, Mar 23, 2018 at 12:51:45PM +0800, Ni, Ruiyu wrote: > > > > On 3/20/2018 8:15 PM, Guo Heyi wrote: > > > > >I've no idea about how to use Driver####; let me spend some time to learn first > > > > >:) > > > > > > > > Heyi, > > > > you could use "load xxxDriver.efi" to load the dynamic command in shell. > > > > After that, you can run "tftp" in shell just as running an internal command. > > > > > > > > > > > > > >Regards, > > > > > > > > > >Heyi > > > > > > > > > >On Tue, Mar 20, 2018 at 09:51:32AM +0000, Leif Lindholm wrote: > > > > >>Ah, apologies. > > > > >> > > > > >>I would be reluctant to add commands not covered by the UEFI Shell > > > > >>Specification by default. > > > > >> > > > > >>Since it is now a dynamic command, is there any way of loading this > > > > >>dynamically (perhaps via DRIVER####) where you feel the need for it? > > > > >> > > > > >>/ > > > > >> Leif > > > > >> > > > > >>On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > > > > >>>Ping :) > > > > >>> > > > > >>> > > > > >>>On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > > > > >>>>On 7 March 2018 at 03:03, Heyi Guo <heyi.guo@linaro.org> wrote: > > > > >>>>>Since D0x platforms always have network enabled, we would like to > > > > >>>>>enable tftp command by default so that we can download something in > > > > >>>>>EFI Shell. > > > > >>>>> > > > > >>>>>Contributed-under: TianoCore Contribution Agreement 1.1 > > > > >>>>>Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > > > > >>>>>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > >>>>>Cc: Leif Lindholm <leif.lindholm@linaro.org> > > > > >>>> > > > > >>>>The first patch looks fine to me, but I would like to give Leif a > > > > >>>>chance to comment on the policy side of this patch. > > > > >>>> > > > > >>>>Please ping us by the end of next week if we haven't responded by then. > > > > >>>> > > > > >>>>>--- > > > > >>>>> Platform/Hisilicon/D03/D03.dsc | 2 ++ > > > > >>>>> Platform/Hisilicon/D05/D05.dsc | 1 + > > > > >>>>> 2 files changed, 3 insertions(+) > > > > >>>>> > > > > >>>>>diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > > > >>>>>index cb0669d639d1..fce1e60b1275 100644 > > > > >>>>>--- a/Platform/Hisilicon/D03/D03.dsc > > > > >>>>>+++ b/Platform/Hisilicon/D03/D03.dsc > > > > >>>>>@@ -29,6 +29,8 @@ [Defines] > > > > >>>>> SKUID_IDENTIFIER = DEFAULT > > > > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > > >>>>> > > > > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > > >>>>>+ > > > > >>>>> !include Silicon/Hisilicon/Hisilicon.dsc.inc > > > > >>>>> > > > > >>>>> [LibraryClasses.common] > > > > >>>>>diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > > > >>>>>index 8373a821a496..f007f3d2d7e8 100644 > > > > >>>>>--- a/Platform/Hisilicon/D05/D05.dsc > > > > >>>>>+++ b/Platform/Hisilicon/D05/D05.dsc > > > > >>>>>@@ -29,6 +29,7 @@ [Defines] > > > > >>>>> SKUID_IDENTIFIER = DEFAULT > > > > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > > >>>>> DEFINE EDK2_SKIP_PEICORE=0 > > > > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > > >>>>> DEFINE NETWORK_IP6_ENABLE = FALSE > > > > >>>>> DEFINE HTTP_BOOT_ENABLE = FALSE > > > > >>>>> > > > > >>>>>-- > > > > >>>>>2.7.4 > > > > >>>>> > > > > >_______________________________________________ > > > > >edk2-devel mailing list > > > > >edk2-devel@lists.01.org > > > > >https://lists.01.org/mailman/listinfo/edk2-devel > > > > > > > > > > > > > > > > > -- > > > > Thanks, > > > > Ray > > > > _______________________________________________ > > > > edk2-devel mailing list > > > > edk2-devel@lists.01.org > > > > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure 2018-03-07 3:03 [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure Heyi Guo 2018-03-07 3:03 ` [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default Heyi Guo @ 2018-04-18 10:59 ` Leif Lindholm 1 sibling, 0 replies; 12+ messages in thread From: Leif Lindholm @ 2018-04-18 10:59 UTC (permalink / raw) To: Heyi Guo; +Cc: edk2-devel, Ard Biesheuvel On Wed, Mar 07, 2018 at 11:03:52AM +0800, Heyi Guo wrote: > We need to set PcdShellLibAutoInitialize to FALSE for > TftpDynamicCommand, or else we will get initialization failure when > loading TftpDynamicCommand module, for EFI Shell has not been started > at this moment. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Leif Lindholm <leif.lindholm@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> As requested on other thread, pushed separately as 06866930dc. > --- > Platform/Hisilicon/D03/D03.dsc | 5 ++++- > Platform/Hisilicon/D05/D05.dsc | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > index c4963063794b..cb0669d639d1 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -517,5 +517,8 @@ [Components.common] > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 > } > !ifdef $(INCLUDE_TFTP_COMMAND) > - ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { > + <PcdsFixedAtBuild> > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > !endif #$(INCLUDE_TFTP_COMMAND) > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > index 0792b0814ea1..8373a821a496 100644 > --- a/Platform/Hisilicon/D05/D05.dsc > +++ b/Platform/Hisilicon/D05/D05.dsc > @@ -675,5 +675,8 @@ [Components.common] > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 > } > !ifdef $(INCLUDE_TFTP_COMMAND) > - ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { > + <PcdsFixedAtBuild> > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > !endif #$(INCLUDE_TFTP_COMMAND) > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-04-18 10:59 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-03-07 3:03 [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure Heyi Guo 2018-03-07 3:03 ` [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default Heyi Guo 2018-03-07 16:02 ` Ard Biesheuvel 2018-03-20 7:54 ` Guo Heyi 2018-03-20 9:51 ` Leif Lindholm 2018-03-20 12:15 ` Guo Heyi 2018-03-23 4:51 ` Ni, Ruiyu 2018-03-26 9:03 ` Guo Heyi 2018-04-02 2:51 ` Guo Heyi 2018-04-16 12:33 ` Leif Lindholm 2018-04-17 1:58 ` Guo Heyi 2018-04-18 10:59 ` [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure Leif Lindholm
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox