From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A199B20954BBA for ; Tue, 20 Mar 2018 02:45:07 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id h76so2101788wme.4 for ; Tue, 20 Mar 2018 02:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+y8HhEsufBPiNpxQc96/41eRXWEMZ+Mr4IkSHbUgoyg=; b=KI9ALzebl687awPkUb9dO3wUqbKJakQbRJAEGtPBXISl2SuCtHGHfkGrmwTXf4jLhM 1p4iG92FoQD7Un4BuDlxApuAp+PV2ek0qr8kQ6Z+rxmBOw0pfW4fAA6eg3/xN/RAKZtY sJQqicNijPLja/Ri9qxAYfaSvrmHBi65xcNEE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+y8HhEsufBPiNpxQc96/41eRXWEMZ+Mr4IkSHbUgoyg=; b=mdRBERA0uWxxgtLiC22HzaIzIF3bCrmmkR+ZU/rLZnEbedxUvMb8AwOc0j11jX5HoB WTO0aurJhiTM5Zt4CsZJAXpTRWWsRiau7E6eORAMKJvby2UUZhd3YlbbuVIQ0EmEiErv TlEPjadwYxQ5L22AqsA71ehE0U2sVXdokbgOgsFMrsqpKE5vJ71xk2bW7l0WneEZE8Bn F85o2PWVUJi0LyjbIoBfDvUv8e626AMnsQC9tDgCYgkqdR/TXAwngifcrnjNfDY/ypOi 5daLELCHy+X8/LtGi33qXjiEO9JRTOxaWH4GcgaViCfPjYcYMLTg+ICm2/+1jxMPjdNX ZimA== X-Gm-Message-State: AElRT7FgBeHI82HYg1WFKPFHD6ABRMcTYqwce0xESYNg20oI53+n+QqY DLT4t4rGeq0pWIQ3A5NEbqHKWQ== X-Google-Smtp-Source: AG47ELu0yWEzVpm07CbJkYIClmlG5vmNqaYgYIQ814Wkz/a/E7YkOvF6YyO0p6mBvFW6a2suV0eEEA== X-Received: by 10.28.105.78 with SMTP id e75mr1472139wmc.7.1521539495180; Tue, 20 Mar 2018 02:51:35 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l10sm944769wrf.37.2018.03.20.02.51.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Mar 2018 02:51:33 -0700 (PDT) Date: Tue, 20 Mar 2018 09:51:32 +0000 From: Leif Lindholm To: Guo Heyi Cc: Ard Biesheuvel , "edk2-devel@lists.01.org" Message-ID: <20180320095131.l2k2kk7nuxzv7r66@bivouac.eciton.net> References: <1520391833-9344-1-git-send-email-heyi.guo@linaro.org> <1520391833-9344-2-git-send-email-heyi.guo@linaro.org> <20180320075446.GH125210@SZX1000114654> MIME-Version: 1.0 In-Reply-To: <20180320075446.GH125210@SZX1000114654> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 09:45:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Ah, apologies. I would be reluctant to add commands not covered by the UEFI Shell Specification by default. Since it is now a dynamic command, is there any way of loading this dynamically (perhaps via DRIVER####) where you feel the need for it? / Leif On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > Ping :) > > > On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > > On 7 March 2018 at 03:03, Heyi Guo wrote: > > > Since D0x platforms always have network enabled, we would like to > > > enable tftp command by default so that we can download something in > > > EFI Shell. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Heyi Guo > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > > The first patch looks fine to me, but I would like to give Leif a > > chance to comment on the policy side of this patch. > > > > Please ping us by the end of next week if we haven't responded by then. > > > > > --- > > > Platform/Hisilicon/D03/D03.dsc | 2 ++ > > > Platform/Hisilicon/D05/D05.dsc | 1 + > > > 2 files changed, 3 insertions(+) > > > > > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > > index cb0669d639d1..fce1e60b1275 100644 > > > --- a/Platform/Hisilicon/D03/D03.dsc > > > +++ b/Platform/Hisilicon/D03/D03.dsc > > > @@ -29,6 +29,8 @@ [Defines] > > > SKUID_IDENTIFIER = DEFAULT > > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > > > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > + > > > !include Silicon/Hisilicon/Hisilicon.dsc.inc > > > > > > [LibraryClasses.common] > > > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > > index 8373a821a496..f007f3d2d7e8 100644 > > > --- a/Platform/Hisilicon/D05/D05.dsc > > > +++ b/Platform/Hisilicon/D05/D05.dsc > > > @@ -29,6 +29,7 @@ [Defines] > > > SKUID_IDENTIFIER = DEFAULT > > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > DEFINE EDK2_SKIP_PEICORE=0 > > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > DEFINE NETWORK_IP6_ENABLE = FALSE > > > DEFINE HTTP_BOOT_ENABLE = FALSE > > > > > > -- > > > 2.7.4 > > >