From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4991320954B82 for ; Tue, 20 Mar 2018 05:08:55 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id y128so2060109iod.4 for ; Tue, 20 Mar 2018 05:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ceXPUJA0m/hhFEFUKfGXY1/nwzoSAskSUcRzON3OUzY=; b=TMYYwLsyR2EnTqd0JGVMWBowXioai88HhHm5EsiJK0+KCcq9/YAyOOOcit/+U/AI6C RWXj+BiOZbcbcf+EQH5DjmQXNPeTWRePlBIHFsduq+1+q+WfixqDfwHEyAV0A8EkcK8A E7gzcsOBTKLn4fYViTZI6gDcQNClfNxc772Ws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ceXPUJA0m/hhFEFUKfGXY1/nwzoSAskSUcRzON3OUzY=; b=aYamYf7bDkegEBzW9nh/scWNOPMg7rkHlhf+US8eKrWsHGhOkPYCeOzRi0pbX5GmY8 4du8/yGVaZf65vVR3fXInB3mJ2oeHJvwZUAnz9ZVax1bYMn1mfQYnsZ1TTvDYec6Chdc wegRr+OVvobBekTASn+OVhCK5nHtMOt3r4dIoaqmEWOq5bhYzosUuUaD9iNixuCghUfh zFHc3ACpS3wqew7SgZWq11m3ShBBb2YDMtjL6tu0bcrsfcPElZOuS4hpti2rWYmZqdv8 E22aHUa74jqIyMlHM70d5Trsx+IulTB1I60OipOw0+XzqdsZElqUxzfo9S+vfyP38utL h7RQ== X-Gm-Message-State: AElRT7F6fi7LeXhQK3DQCp3ib/mlQTu5BtF9VOl04wGe0iH0Lf1qH/g0 aH/7EEQKKQ/TkSPdGHrwP3Lbmw== X-Google-Smtp-Source: AG47ELuNLZYQpmnmlv7v1aM/ll6xGPqz/oiVLSSnZOqEoFv+I/WjUlSQgRXWVWEi1m5SKEd/TIjpDg== X-Received: by 10.107.101.7 with SMTP id z7mr3001291iob.198.1521548124815; Tue, 20 Mar 2018 05:15:24 -0700 (PDT) Received: from SZX1000114654 ([45.56.152.100]) by smtp.gmail.com with ESMTPSA id v2sm1159832iob.21.2018.03.20.05.15.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Mar 2018 05:15:24 -0700 (PDT) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Tue, 20 Mar 2018 20:15:20 +0800 To: Leif Lindholm Cc: Guo Heyi , Ard Biesheuvel , "edk2-devel@lists.01.org" Message-ID: <20180320121520.GI125210@SZX1000114654> References: <1520391833-9344-1-git-send-email-heyi.guo@linaro.org> <1520391833-9344-2-git-send-email-heyi.guo@linaro.org> <20180320075446.GH125210@SZX1000114654> <20180320095131.l2k2kk7nuxzv7r66@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: <20180320095131.l2k2kk7nuxzv7r66@bivouac.eciton.net> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 12:08:56 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I've no idea about how to use Driver####; let me spend some time to learn first :) Regards, Heyi On Tue, Mar 20, 2018 at 09:51:32AM +0000, Leif Lindholm wrote: > Ah, apologies. > > I would be reluctant to add commands not covered by the UEFI Shell > Specification by default. > > Since it is now a dynamic command, is there any way of loading this > dynamically (perhaps via DRIVER####) where you feel the need for it? > > / > Leif > > On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > > Ping :) > > > > > > On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > > > On 7 March 2018 at 03:03, Heyi Guo wrote: > > > > Since D0x platforms always have network enabled, we would like to > > > > enable tftp command by default so that we can download something in > > > > EFI Shell. > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Heyi Guo > > > > Cc: Ard Biesheuvel > > > > Cc: Leif Lindholm > > > > > > The first patch looks fine to me, but I would like to give Leif a > > > chance to comment on the policy side of this patch. > > > > > > Please ping us by the end of next week if we haven't responded by then. > > > > > > > --- > > > > Platform/Hisilicon/D03/D03.dsc | 2 ++ > > > > Platform/Hisilicon/D05/D05.dsc | 1 + > > > > 2 files changed, 3 insertions(+) > > > > > > > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > > > index cb0669d639d1..fce1e60b1275 100644 > > > > --- a/Platform/Hisilicon/D03/D03.dsc > > > > +++ b/Platform/Hisilicon/D03/D03.dsc > > > > @@ -29,6 +29,8 @@ [Defines] > > > > SKUID_IDENTIFIER = DEFAULT > > > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > > > > > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > > + > > > > !include Silicon/Hisilicon/Hisilicon.dsc.inc > > > > > > > > [LibraryClasses.common] > > > > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > > > index 8373a821a496..f007f3d2d7e8 100644 > > > > --- a/Platform/Hisilicon/D05/D05.dsc > > > > +++ b/Platform/Hisilicon/D05/D05.dsc > > > > @@ -29,6 +29,7 @@ [Defines] > > > > SKUID_IDENTIFIER = DEFAULT > > > > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > > DEFINE EDK2_SKIP_PEICORE=0 > > > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > > DEFINE NETWORK_IP6_ENABLE = FALSE > > > > DEFINE HTTP_BOOT_ENABLE = FALSE > > > > > > > > -- > > > > 2.7.4 > > > >