public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Guo Heyi <heyi.guo@linaro.org>
To: edk2-devel@lists.01.org
Subject: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec
Date: Thu, 22 Mar 2018 19:39:42 +0800	[thread overview]
Message-ID: <20180322113942.GC53577@SZX1000114654> (raw)

Hi folks,

The SetAttributes() interface of generic SerialDxe driver in
MdeModulePkg/Universal does not fully follow UEFI spec. The spec requires to use
default time out value when the input "Timeout" is 0, but the current
implementation will set timeout to 0 directly.  It tries to pass "Timeout" to
SerialPortSetAttributes(), but none of SerialPortLib instances in edk2 tree will
deal with this parameter. What's more, Timeout is actually a software parameter
and is only used in SerialDxe itself, not in SerialPortLib instances, so I think
it makes more sense to set Timeout in SerialDxe directly instead of in
SerialPortLib.

Please advise.

Thanks and regards,

Heyi


             reply	other threads:[~2018-03-22 11:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 11:39 Guo Heyi [this message]
2018-03-22 11:43 ` MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec Guo Heyi
2018-03-23  0:50   ` Zeng, Star
2018-03-23 14:32     ` Laszlo Ersek
2018-03-26  1:40       ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180322113942.GC53577@SZX1000114654 \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox