From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22e; helo=mail-it0-x22e.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 748D222551B90 for ; Thu, 22 Mar 2018 04:36:40 -0700 (PDT) Received: by mail-it0-x22e.google.com with SMTP id z143-v6so1653100itc.0 for ; Thu, 22 Mar 2018 04:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8y+3a/nT8QeHLGCWmnbIoXN+zbUjGAjhBUC6SIN2acg=; b=C35M+yn8zrQKPqtVs4dx/L5K9wzxkmEGeb+uir8BOgVIuCURLrWu0aaXvcgB8ufib/ Pc+EFquanMMxTGeXXjfE0qnj5ItQbPrrkcJNgHxZ30uTsqEeoILzs9p0hz+uc1kldssa YMfPqWsZdPZBwZwH1W2c5/OktBD9bLXJfJY30= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8y+3a/nT8QeHLGCWmnbIoXN+zbUjGAjhBUC6SIN2acg=; b=h8KWFrT4KUa71pMd/5Cd9rk0bcQp2XS3uBjxOQNuIyaLeULwwEF3ybHbm9bOdIOluG is4xH6CphSJKdvVpUVPjn0sgFQxjKX0E4FkaxZD1XBsFlHE66P34cYa0ifPlUgCd6HJG 6Um+sjMXDFk1+dprf3zXQNQB5NIAdNogJw1+fcnuMc95X4R2AnykF0DDhvgudy6PoLwk hvJsXGAe44fjUW78gEyZm50a+hgvX9m2vM6XB+X+mJFDLkeI+W9TyYu+QPPxnGUADetj ccE3kccweC49/OkdwWeY8v7uPPqcjL5yhfJV9XhniaMZDrYF2zJquCrixO5m1LAdXrz5 Gy/w== X-Gm-Message-State: AElRT7HTNAQhPflO1yJ1O31n5P6FDqQ3NpBBuyqeUj+MNuV2ha5r2zUI 04jp6dL857WLCdbM3UQo4ILkxaEob9U= X-Google-Smtp-Source: AG47ELs2S9uyjnz1ClHP/3lu7vEjw5UtnH/8HhYx+jSo5Ktf7GY3Uuq/xTdgJuXg1pnw10fAMdIGCQ== X-Received: by 2002:a24:2f13:: with SMTP id j19-v6mr8287775itj.15.1521718991554; Thu, 22 Mar 2018 04:43:11 -0700 (PDT) Received: from SZX1000114654 ([45.56.152.100]) by smtp.gmail.com with ESMTPSA id j19sm4412609ioe.15.2018.03.22.04.43.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Mar 2018 04:43:11 -0700 (PDT) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Thu, 22 Mar 2018 19:43:07 +0800 To: edk2-devel@lists.01.org Cc: Star Zeng , Eric Dong , Ruiyu Ni Message-ID: <20180322114307.GD53577@SZX1000114654> References: <20180322113942.GC53577@SZX1000114654> MIME-Version: 1.0 In-Reply-To: <20180322113942.GC53577@SZX1000114654> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 11:36:40 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline +cc Maintainers of MdeModulePkg. On Thu, Mar 22, 2018 at 07:39:42PM +0800, Guo Heyi wrote: > Hi folks, > > The SetAttributes() interface of generic SerialDxe driver in > MdeModulePkg/Universal does not fully follow UEFI spec. The spec requires to use > default time out value when the input "Timeout" is 0, but the current > implementation will set timeout to 0 directly. It tries to pass "Timeout" to > SerialPortSetAttributes(), but none of SerialPortLib instances in edk2 tree will > deal with this parameter. What's more, Timeout is actually a software parameter > and is only used in SerialDxe itself, not in SerialPortLib instances, so I think > it makes more sense to set Timeout in SerialDxe directly instead of in > SerialPortLib. > > Please advise. > > Thanks and regards, > > Heyi