From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::243; helo=mail-pl0-x243.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x243.google.com (mail-pl0-x243.google.com [IPv6:2607:f8b0:400e:c01::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 66A1120956061 for ; Sun, 25 Mar 2018 19:03:33 -0700 (PDT) Received: by mail-pl0-x243.google.com with SMTP id w15-v6so11027003plq.9 for ; Sun, 25 Mar 2018 19:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RKRjBb9HfBrXLXJ4yAKam2KkLmVlzqs4ul3Y0r3pVNQ=; b=X4fTVvFC6NqLxw5AOoPsH06sVrLsc5K0OlfMVlGgF1zHLIZmyjA/avQFh+8i426dUu MjEKtkYRWnXS/wyESBjAH57Fo1/flla1JfzBdZcgMBxBs+rGmlzmBVI95YQ88hHOn0eo 4wWaEmy8rD8Z6kE1n8EhJNcxViwmifKSQJK2o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RKRjBb9HfBrXLXJ4yAKam2KkLmVlzqs4ul3Y0r3pVNQ=; b=nlycFDyJxKDuu8ApzVgVA00USidwKG/rnCZqL3kqTMdeGmrUyUEd4A8sBcHSCb45qq /TzudyugtO15MNs2EOczZ7RHncjhHqLgZt1WrywxXlhabBzlFY1kpnUHyqP7qEaw3Gd8 M8h3SV9XSB813KvWX2maTz09yNQQQ9jwIQeNai6TQoE+FUAW5k8XUQ52OLef30VCogMG aiaKYKSx3gWYlOJf8yukx9wMs74My/6OjZtPko2ft//t5nTEzlKMQ+sFWTHcGJTrDGln DBQbffDj/AASboaiLV26Gphol0RprJG2BIf7GXd4fT2U9UN6Q0bVEPiju+0QzJ49ttJ1 rbCQ== X-Gm-Message-State: AElRT7GOnnLegGD3ektMPgxoLglYLEj5iD7tDOd9QxkzJTXTabY2p6DX hkeO1Aa4U/7vGhc7sc/tVs+bGw== X-Google-Smtp-Source: AG47ELsWwaieGcdKMCEs8aPbjeIo1n0IKqAMoDmuBEclgZ7mBEuoh59k4ymNNpgXw6xtfq4ch0Xa6Q== X-Received: by 2002:a17:902:8685:: with SMTP id g5-v6mr34168574plo.133.1522030209589; Sun, 25 Mar 2018 19:10:09 -0700 (PDT) Received: from SZX1000114654 ([104.237.91.79]) by smtp.gmail.com with ESMTPSA id v11sm1958079pgf.57.2018.03.25.19.10.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Mar 2018 19:10:09 -0700 (PDT) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Mon, 26 Mar 2018 10:10:05 +0800 To: Ard Biesheuvel Cc: Heyi Guo , "edk2-devel@lists.01.org" , Yi Li , Leif Lindholm , Michael D Kinney Message-ID: <20180326021005.GA58655@SZX1000114654> References: <1521716541-54412-1-git-send-email-heyi.guo@linaro.org> <1521716541-54412-2-git-send-email-heyi.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [PATCH edk2-non-osi 1/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 02:03:34 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 23, 2018 at 05:25:54PM +0800, Ard Biesheuvel wrote: > On 22 March 2018 at 19:02, Heyi Guo wrote: > > The code in SM750 driver treated the address returned from > > PciIo->GetBarAttributes() as device address; this should be fixed > > after edk2 commit dc080d3 since GetBarAttributes() returns host > > address from then on. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Heyi Guo > > Signed-off-by: Yi Li > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > --- > > Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 18432 bytes > > Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 18464 bytes > > Hi Heyi, > > If this is a PCI device, why do we have separate binaries for D03 and D05? That's a good question :) It should be a unified PCIe driver; I will check if there is any platform specific code included and then try to merge them together. Thanks and regards, Heyi > > > > 2 files changed, 0 insertions(+), 0 deletions(-) > > > > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > > index 16c91e2b18ef..3c7aae7dc6f6 100644 > > Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ > > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > > index b8de0259c785..7d4fe1b3228f 100644 > > Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ > > -- > > 2.7.4 > >