From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 26CE62210D9FB for ; Mon, 26 Mar 2018 01:56:38 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id 19-v6so9786711itw.3 for ; Mon, 26 Mar 2018 02:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l/u0IkOVMeA2AyLSUFqWXpdqZFjT7nyyKw/0V/OxIeo=; b=Hd7/+OfXDpdt6EX0gGWdsQ5RP/vx48eivpYZNAxkv68rsqwPzoThB4gcjWakjW6OrB lUgJUyziov53kgKiOJbFqPyj8sPs1VvF5DLy3yIRdCsBZlc8fQ7VPR5DFrmLpGhR5wHM X7VtiQVjZrzY1jP520TAEZRIEhIvcaAWNE7Vk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l/u0IkOVMeA2AyLSUFqWXpdqZFjT7nyyKw/0V/OxIeo=; b=jwEOsswc6NO7CMOgoiSDhN322GL6Tt43sI7aOuSa3KmAfVd+oSjE4eVLu7FcPnik1I MuXhuAkYaCzrUDr5clgymA3hTzDcpxHZLwolruEEPezi99AgesIfh1/vAxU9JOgu04IN vMcvkZsADfbUVrIEMdJCAHk9Dt4aREX8IqYoOVtNPlpblTjQ4ifcF0+iM8SQ2F7oXvXU aRngD7VcqLYoLm4ha281JsL7sTOme7zGmGel7jGYIGY2N2cHgancarvtM90B8rTxMb0r ho3FjE6jnWLbhMlULGx3lm/pjYGMXu5G3FjGo3YpvxCVMj45qcsOYl9j1SSpwg+LdvHB jNlg== X-Gm-Message-State: AElRT7GeHfKmhRqt4LZ2bR1dKANM56IG8dW4Z5qQNywYOeZm4Nogn32I 4g9BPVyJ99K3owXzTO0fHxNmTw== X-Google-Smtp-Source: AG47ELueY3GbTgBAc+VXcf5cFPdA404AuYgBpsTV5jiC/f+bVmJdVkFen72SJKxgOAAB8QkIGLtnhw== X-Received: by 2002:a24:5491:: with SMTP id t139-v6mr20994228ita.89.1522054994389; Mon, 26 Mar 2018 02:03:14 -0700 (PDT) Received: from SZX1000114654 ([104.237.91.79]) by smtp.gmail.com with ESMTPSA id j28sm8736171iod.84.2018.03.26.02.03.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 02:03:13 -0700 (PDT) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Mon, 26 Mar 2018 17:03:10 +0800 To: "Ni, Ruiyu" Cc: edk2-devel@lists.01.org Message-ID: <20180326090310.GB67369@SZX1000114654> References: <1520391833-9344-1-git-send-email-heyi.guo@linaro.org> <1520391833-9344-2-git-send-email-heyi.guo@linaro.org> <20180320075446.GH125210@SZX1000114654> <20180320095131.l2k2kk7nuxzv7r66@bivouac.eciton.net> <20180320121520.GI125210@SZX1000114654> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 08:56:39 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks Ray. Does that mean we need build the dynamic command driver separately and store it in other media instead of UEFI fd image? Right now if I include the driver into the fd image, it will be automatically added to EFI Shell command list; we don't need to run the load command. Hi Leif, Is the policy to forbid including dynamic command driver into UEFI fd image? If we need other media to store tftp command driver, then the command will become less useful, because it is mainly used to download something else. If we have other media like USB disk, we can use this "other media" instead of network download to store the final target. Thanks, Heyi On Fri, Mar 23, 2018 at 12:51:45PM +0800, Ni, Ruiyu wrote: > On 3/20/2018 8:15 PM, Guo Heyi wrote: > >I've no idea about how to use Driver####; let me spend some time to learn first > >:) > > Heyi, > you could use "load xxxDriver.efi" to load the dynamic command in shell. > After that, you can run "tftp" in shell just as running an internal command. > > > > >Regards, > > > >Heyi > > > >On Tue, Mar 20, 2018 at 09:51:32AM +0000, Leif Lindholm wrote: > >>Ah, apologies. > >> > >>I would be reluctant to add commands not covered by the UEFI Shell > >>Specification by default. > >> > >>Since it is now a dynamic command, is there any way of loading this > >>dynamically (perhaps via DRIVER####) where you feel the need for it? > >> > >>/ > >> Leif > >> > >>On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > >>>Ping :) > >>> > >>> > >>>On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > >>>>On 7 March 2018 at 03:03, Heyi Guo wrote: > >>>>>Since D0x platforms always have network enabled, we would like to > >>>>>enable tftp command by default so that we can download something in > >>>>>EFI Shell. > >>>>> > >>>>>Contributed-under: TianoCore Contribution Agreement 1.1 > >>>>>Signed-off-by: Heyi Guo > >>>>>Cc: Ard Biesheuvel > >>>>>Cc: Leif Lindholm > >>>> > >>>>The first patch looks fine to me, but I would like to give Leif a > >>>>chance to comment on the policy side of this patch. > >>>> > >>>>Please ping us by the end of next week if we haven't responded by then. > >>>> > >>>>>--- > >>>>> Platform/Hisilicon/D03/D03.dsc | 2 ++ > >>>>> Platform/Hisilicon/D05/D05.dsc | 1 + > >>>>> 2 files changed, 3 insertions(+) > >>>>> > >>>>>diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > >>>>>index cb0669d639d1..fce1e60b1275 100644 > >>>>>--- a/Platform/Hisilicon/D03/D03.dsc > >>>>>+++ b/Platform/Hisilicon/D03/D03.dsc > >>>>>@@ -29,6 +29,8 @@ [Defines] > >>>>> SKUID_IDENTIFIER = DEFAULT > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > >>>>> > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > >>>>>+ > >>>>> !include Silicon/Hisilicon/Hisilicon.dsc.inc > >>>>> > >>>>> [LibraryClasses.common] > >>>>>diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > >>>>>index 8373a821a496..f007f3d2d7e8 100644 > >>>>>--- a/Platform/Hisilicon/D05/D05.dsc > >>>>>+++ b/Platform/Hisilicon/D05/D05.dsc > >>>>>@@ -29,6 +29,7 @@ [Defines] > >>>>> SKUID_IDENTIFIER = DEFAULT > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > >>>>> DEFINE EDK2_SKIP_PEICORE=0 > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > >>>>> DEFINE NETWORK_IP6_ENABLE = FALSE > >>>>> DEFINE HTTP_BOOT_ENABLE = FALSE > >>>>> > >>>>>-- > >>>>>2.7.4 > >>>>> > >_______________________________________________ > >edk2-devel mailing list > >edk2-devel@lists.01.org > >https://lists.01.org/mailman/listinfo/edk2-devel > > > > > -- > Thanks, > Ray > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel