From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::242; helo=mail-pl0-x242.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x242.google.com (mail-pl0-x242.google.com [IPv6:2607:f8b0:400e:c01::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 54792225F3208 for ; Sun, 1 Apr 2018 19:51:57 -0700 (PDT) Received: by mail-pl0-x242.google.com with SMTP id m22-v6so3315698pls.5 for ; Sun, 01 Apr 2018 19:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wIPuSvixpiGt6gDYzgLYam1CMfcsCAF4BtUXeIJMt6k=; b=UgBE8FP+22qlbZssXqXrJG670wSlyynPviTa12Z+i2yK6G0DOc1K0DXK23Z6HH8Ttb ZIRsTanIbZe8+Aoc3PqdiBP6zsI0x+CgE6HFfs5+o8GzpEVoM7edsMQ+eBlvpKI1QCWV XfzW5aey5NW2P9MBXWBl1P8jgeRb0dqswt70g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wIPuSvixpiGt6gDYzgLYam1CMfcsCAF4BtUXeIJMt6k=; b=N634+r5SkwuAsn0GtZireL5WHNTDS/lmgDNJoatbJNbWqmgxm2pEECEl7oiYZxlXcw rqezj6173pEWUshjNg/uqxwE55KnYKQAkN6+laV3ez+tNZhrXs1E9k13Fy8A/+NdBQ/O z3e1Th3Gi4pJTmbdhoheHKWUiu4KtTca0XoienqXHsLNxk7j5YMxRzEmmwlpRMLOBm3/ fbfuFaXr+bO/2MbvQLFvXt6pOXX3yysg8M03GhDswnjvnYEy8/8IKvZGM4hXg7or52re oCnsdhrqS4LzEYayLKXO2DTAXBhhCRtpPt9NKVcYGTE6lfeVWfiG79s0gxUsxwDutmHt aPkQ== X-Gm-Message-State: AElRT7EwWWuMqq3vq0wV8QskDF9887WvF687aabb8qlyUxFyrKRXtc2Z fu71jG9xoc5woJgzYg3f2lo7DJd/Ms8= X-Google-Smtp-Source: AIpwx4/XGbuJRQVYQ/xO+vJe9a8xMT7hcZyWA4dNZaG8xOfCaLugexhTz4v27jn39AqpZv+kPtf3Eg== X-Received: by 2002:a17:902:7888:: with SMTP id q8-v6mr8148916pll.108.1522637516546; Sun, 01 Apr 2018 19:51:56 -0700 (PDT) Received: from SZX1000114654 ([45.56.152.115]) by smtp.gmail.com with ESMTPSA id o66sm28390263pfg.90.2018.04.01.19.51.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Apr 2018 19:51:56 -0700 (PDT) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Mon, 2 Apr 2018 10:51:53 +0800 To: edk2-devel@lists.01.org Cc: "Ni, Ruiyu" , Leif Lindholm Message-ID: <20180402025153.GB109127@SZX1000114654> References: <1520391833-9344-1-git-send-email-heyi.guo@linaro.org> <1520391833-9344-2-git-send-email-heyi.guo@linaro.org> <20180320075446.GH125210@SZX1000114654> <20180320095131.l2k2kk7nuxzv7r66@bivouac.eciton.net> <20180320121520.GI125210@SZX1000114654> <20180326090310.GB67369@SZX1000114654> MIME-Version: 1.0 In-Reply-To: <20180326090310.GB67369@SZX1000114654> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 02:51:57 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Ray and Leif, Any comments? On Mon, Mar 26, 2018 at 05:03:10PM +0800, Guo Heyi wrote: > Thanks Ray. > > Does that mean we need build the dynamic command driver separately and store it > in other media instead of UEFI fd image? Right now if I include the driver into > the fd image, it will be automatically added to EFI Shell command list; we don't > need to run the load command. > > Hi Leif, > > Is the policy to forbid including dynamic command driver into UEFI fd image? > > If we need other media to store tftp command driver, then the command will > become less useful, because it is mainly used to download something else. If we > have other media like USB disk, we can use this "other media" instead of network > download to store the final target. > > Thanks, > Heyi > > On Fri, Mar 23, 2018 at 12:51:45PM +0800, Ni, Ruiyu wrote: > > On 3/20/2018 8:15 PM, Guo Heyi wrote: > > >I've no idea about how to use Driver####; let me spend some time to learn first > > >:) > > > > Heyi, > > you could use "load xxxDriver.efi" to load the dynamic command in shell. > > After that, you can run "tftp" in shell just as running an internal command. > > > > > > > >Regards, > > > > > >Heyi > > > > > >On Tue, Mar 20, 2018 at 09:51:32AM +0000, Leif Lindholm wrote: > > >>Ah, apologies. > > >> > > >>I would be reluctant to add commands not covered by the UEFI Shell > > >>Specification by default. > > >> > > >>Since it is now a dynamic command, is there any way of loading this > > >>dynamically (perhaps via DRIVER####) where you feel the need for it? > > >> > > >>/ > > >> Leif > > >> > > >>On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > > >>>Ping :) > > >>> > > >>> > > >>>On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > > >>>>On 7 March 2018 at 03:03, Heyi Guo wrote: > > >>>>>Since D0x platforms always have network enabled, we would like to > > >>>>>enable tftp command by default so that we can download something in > > >>>>>EFI Shell. > > >>>>> > > >>>>>Contributed-under: TianoCore Contribution Agreement 1.1 > > >>>>>Signed-off-by: Heyi Guo > > >>>>>Cc: Ard Biesheuvel > > >>>>>Cc: Leif Lindholm > > >>>> > > >>>>The first patch looks fine to me, but I would like to give Leif a > > >>>>chance to comment on the policy side of this patch. > > >>>> > > >>>>Please ping us by the end of next week if we haven't responded by then. > > >>>> > > >>>>>--- > > >>>>> Platform/Hisilicon/D03/D03.dsc | 2 ++ > > >>>>> Platform/Hisilicon/D05/D05.dsc | 1 + > > >>>>> 2 files changed, 3 insertions(+) > > >>>>> > > >>>>>diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > >>>>>index cb0669d639d1..fce1e60b1275 100644 > > >>>>>--- a/Platform/Hisilicon/D03/D03.dsc > > >>>>>+++ b/Platform/Hisilicon/D03/D03.dsc > > >>>>>@@ -29,6 +29,8 @@ [Defines] > > >>>>> SKUID_IDENTIFIER = DEFAULT > > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > >>>>> > > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > > >>>>>+ > > >>>>> !include Silicon/Hisilicon/Hisilicon.dsc.inc > > >>>>> > > >>>>> [LibraryClasses.common] > > >>>>>diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > >>>>>index 8373a821a496..f007f3d2d7e8 100644 > > >>>>>--- a/Platform/Hisilicon/D05/D05.dsc > > >>>>>+++ b/Platform/Hisilicon/D05/D05.dsc > > >>>>>@@ -29,6 +29,7 @@ [Defines] > > >>>>> SKUID_IDENTIFIER = DEFAULT > > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > >>>>> DEFINE EDK2_SKIP_PEICORE=0 > > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > > >>>>> DEFINE NETWORK_IP6_ENABLE = FALSE > > >>>>> DEFINE HTTP_BOOT_ENABLE = FALSE > > >>>>> > > >>>>>-- > > >>>>>2.7.4 > > >>>>> > > >_______________________________________________ > > >edk2-devel mailing list > > >edk2-devel@lists.01.org > > >https://lists.01.org/mailman/listinfo/edk2-devel > > > > > > > > > -- > > Thanks, > > Ray > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel