* [Patch] MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls
@ 2018-04-02 22:40 Kinney, Michael D
0 siblings, 0 replies; only message in thread
From: Kinney, Michael D @ 2018-04-02 22:40 UTC (permalink / raw)
To: edk2-devel
Cc: Heyi Guo, Yi Li, Renhao Liang, Star Zeng, Eric Dong, Liming Gao,
Jian J Wang, Ruiyu Ni, Michael D Kinney
This patch fixes an issue with VlvTbltDevicePkg introduced
by commit:
https://github.com/tianocore/edk2/commit/5b91bf82c67b586b9588cbe4bbffa1588f6b5926
This patch filters the call to gCpu->SetMemoryAttributes()
if the requested attributes is 0. It also removes the #define
INVALID_CPU_ARCH_ATTRIBUTES that is no longer used.
Cc: Heyi Guo <heyi.guo@linaro.org>
Cc: Yi Li <phoenix.liyi@huawei.com>
Cc: Renhao Liang <liangrenhao@huawei.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
index 907245a3f5..45ed6280db 100644
--- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
+++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
@@ -48,8 +48,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#define NONEXCLUSIVE_MEMORY_ATTRIBUTES (EFI_MEMORY_XP | EFI_MEMORY_RP | \
EFI_MEMORY_RO)
-#define INVALID_CPU_ARCH_ATTRIBUTES 0xffffffff
-
//
// Module Variables
//
@@ -873,7 +871,7 @@ CoreConvertSpace (
// Call CPU Arch Protocol to attempt to set attributes on the range
//
CpuArchAttributes = ConverToCpuArchAttributes (Attributes);
- if (CpuArchAttributes != INVALID_CPU_ARCH_ATTRIBUTES) {
+ if (CpuArchAttributes != 0) {
if (gCpu == NULL) {
Status = EFI_NOT_AVAILABLE_YET;
} else {
--
2.14.2.windows.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-04-02 22:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-02 22:40 [Patch] MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls Kinney, Michael D
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox