From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.47; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=achin.gupta@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0047.outbound.protection.outlook.com [104.47.1.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A25122742A89 for ; Wed, 11 Apr 2018 07:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FuOefWd/lS4VJm9HKx3/e/J3LBxBZLCvoDjWZf8PrSA=; b=NPQqp3P3jhSCdmAxSZy/8KXnKWSjG9T/AA9MyrtSnxVmMACNVPyKPnTSJ4N72LUZGqlcz0DCqSJKXL7SMoQSUq9IPz4dz/j0O9k02aX5oMx7B+L9OJ16Q7E6wLBurT8yZNfhLPSJKobvwnaIFzjy9Cka7Vs85HhcFmivky7eT8M= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Achin.Gupta@arm.com; Received: from e104320-lin (217.140.96.140) by DB7PR08MB2988.eurprd08.prod.outlook.com (2603:10a6:5:1c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Wed, 11 Apr 2018 14:36:41 +0000 Date: Wed, 11 Apr 2018 15:38:06 +0100 From: Achin Gupta To: Supreeth Venkatesh Cc: edk2-devel@lists.01.org, michael.d.kinney@intel.com, liming.gao@intel.com, jiewen.yao@intel.com, leif.lindholm@linaro.org, ard.biesheuvel@linaro.org, nd@arm.com Message-ID: <20180411143805.GF663@e104320-lin> References: <20180406144223.10931-1-supreeth.venkatesh@arm.com> <20180406144223.10931-4-supreeth.venkatesh@arm.com> MIME-Version: 1.0 In-Reply-To: <20180406144223.10931-4-supreeth.venkatesh@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: CWXP265CA0011.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:2e::23) To DB7PR08MB2988.eurprd08.prod.outlook.com (2603:10a6:5:1c::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR08MB2988; X-Microsoft-Exchange-Diagnostics: 1; DB7PR08MB2988; 3:3OZJqTj0hIqTY0JQz/zweIrmMZxyItp0gptKz9FF1lCHuPWz6LU1ic3Pr7L9VY5XIEB5i7xCgc/KzAHczr1PylccSsJxyZAWE9YPBQzQH1AO+AuIYkPyMKjfuTQBh61wyqbBABp/SadZn43QDPXHziphem6OFE/ZfLYARtT+8FIx2DiObqwcguF4iGKr5RoDN5quujtq6uehpLawRraFgFGg3ODEZBYYLJaPTa5Ez1iiJqYfIWwsNoL3hcFCSA2b; 25:+ovrKO56nM+n4StmYy8Om5ZoryHd8LC/jaOZHlHffQ1/25MKRjJ8kI9oK6hKBrT7p2keUqkstd5cO9JrUoDfCLARZIEMdzBmc5y1vCFPJ1RgM4suPFcInHp0ehxJKBo6mX7DPNCiYGn8ifjW5fviaDF1qxvi/8N2900G3WS6yNtHAs/aoG+9RwYBe6GDR6X3SDryTus3Dq+GgAhi3tgCaxeqMrzT1SmahBCWgkih1SukseIqW6lTW/vSaxLbKiktk59UERdIALVa4c+Nmjs0jqel1r82VLY3/QuHKRhOznzR7xdPRfMRlM6F8rPQMlGpKO1CMaRDtGaVHOe0haKT0w==; 31:mT/sLV9zt4KgTx9O8WBbyA5yzUJKmQpEYrbwfWKRSmTBc6giY5ceALkl3ASxzJjy3eHL9JCuPerAeWc9Isb4Ru7B+AFurDSKkRWusgum/5QDNN3XFq3LVoXEDmQGgu03HpS4I10INIUaUs9HHMxZZa/w1G8pv9N5LkBoQ7X9ymcC9ER+G87uVUlaClHtaUG3plCJDy2FB/OMGe2EOaZ0OmWfgj7PDY/0riUyJ4wvOJU= X-MS-TrafficTypeDiagnostic: DB7PR08MB2988: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; DB7PR08MB2988; 20:4WdvtC7DmoI5+hp7XhW6yXlu8zAYRMpLYKQv0PNKXAg/oczcLzznMeUmSdCvI0wS3KqQzil67FkK0qsqpij+vIZdYup0U4MGVBuNcTwG6D8EqoG82RJUsbloM6iOAgsh3Fkyr5cEnpHe0POB+IgP1Zn7jvxJLE+c+qBj+mWLzV8=; 4:ThUX1hD5rNzMXvrO8qb+DU8XGQi/+IqZiTD2frCh9dE/J2g12kQYeeiEDaWQWbWyJOmaJHsnWAKmnwZX7nbMA41cH8tD6JiqzICdkbFB//iHQ0+lSa3C1wcvjygoDf9MHoodWw0tYly/kT/K6NxIYj9OQOnQsJ4Rav55wyatYgA2/esQ8Ug8TXiT9fXnmgiwAINj+u2LG2D3xQnm5JC88tnFUVpSZ4BsaNl5iKl5ADdMU6l5QIW9SfvWgBelMuZgZ7mMcc9GcAe4KlAz27DGdeJlWYULfCqULDFBRxSxQ8xqgTSoScGyoTQesDq3oo0q X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:DB7PR08MB2988; BCL:0; PCL:0; RULEID:; SRVR:DB7PR08MB2988; X-Forefront-PRVS: 0639027A9E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(39380400002)(396003)(366004)(376002)(189003)(199004)(50466002)(52116002)(8936002)(16526019)(966005)(1076002)(81156014)(26005)(106356001)(305945005)(33656002)(8676002)(81166006)(229853002)(23726003)(105586002)(11346002)(5660300001)(6246003)(6636002)(6666003)(7736002)(33716001)(66066001)(3846002)(2906002)(76176011)(25786009)(956004)(55016002)(68736007)(4326008)(478600001)(53936002)(6306002)(6116002)(16586007)(446003)(47776003)(33896004)(6496006)(486006)(9686003)(6862004)(72206003)(97736004)(476003)(58126008)(86362001)(59450400001)(386003)(316002)(18370500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB2988; H:e104320-lin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR08MB2988; 23:f070Z1gimwPk7EnFXEYLjtm0qR5/ZB/8XZDd4CQuH?= =?us-ascii?Q?AVPaLBUXT/24izz84Qjbc4N7so5dkvPcjgIj9mpa47Vc4plRoAOOj0XVc8o6?= =?us-ascii?Q?pZplvdoIzpnD4mD+gKZkaXvpLQqh59fP2dYpx8TYlIAacnQ4DM6BZSEAvTJV?= =?us-ascii?Q?ezQwYlYaZMw0kjsnFXOJcQI+/IlJBIwq2jtCS4ABP0C5rh4AZ8GsenwCPtf+?= =?us-ascii?Q?jYxh8LRg/WlnobTE63eua5pkyz8wRTSys20m4xdPKzDZABtwxYIiprDHXCs2?= =?us-ascii?Q?EwL2ky0v7Lc+xffC8ZIy/ObyeKG+wS744PA+Iu9J33hBKYiRdPAF3ZDtRXEr?= =?us-ascii?Q?fxxHlizQoUdMARYs/l5RI1Iiz+NKrxt9jYE8Sg1/xAksw3tnR/esXQHTGoGa?= =?us-ascii?Q?+acVBVZQKHGraV3/MRcALny7uewL/hXTodylpKvak9LtuwrIBmWWLjj91VSE?= =?us-ascii?Q?KzX/PEOMSgKSJ/k7to8T78KREqrbeqSQ5hrL2ZBE/5TyWybXMMfCNU+tw9DG?= =?us-ascii?Q?odT0fpmCnwiGuEa6QbbUhDFxAgNkJt5p+pCSFTY7LujjOor7uvpo2JtLPB1c?= =?us-ascii?Q?q41IbD22U2NgPSQkN7OM7B+OM8tI3OSuxBj3iTEQ1NKZA/llhzkz+vkt9Gwx?= =?us-ascii?Q?rn67tQvY+E1WllFpjzAAN+3MRJ6X5aW0ES16isZGVg/51Rhi4d76vWhUhvq8?= =?us-ascii?Q?qqHMyuLIst4ijmyJ1ZLN8Y+X1CZSIHsbvfrOzhCg4WL88yvMto2UPSfji31q?= =?us-ascii?Q?s5Rahdk/HyXKotSo+qyXTJawI4UCAYgmLrtpcYM/g0rh/E/faMZHF0vKQdDJ?= =?us-ascii?Q?wmv3PL4j9rY8D7v3Ses99OLyn5zXmNcltCUmqFzqtM0r+OEHHGLTZvX1+Izd?= =?us-ascii?Q?jr8t5RQy07Fz9QRAneOUV07f6c1TWBkX32iKPGjiOP7snKdUPLuBTEBgu9rw?= =?us-ascii?Q?rOH4Zf4iyLxto67VRkEx5Ymr0U3be4hJXl/opQraZ9o++lSGh1GMBwhJqcZM?= =?us-ascii?Q?3CLDIr1vbaQfMGPTmR7D65hx1IJPoh4BT2tH+EXl+tVo/hQlASx1giy4ZU03?= =?us-ascii?Q?DFMn5JrYVmFq1LCKzCDERKZ6uwrBdKhlPnqFw/GLCRqmw2XhrJv9FcdFQ0Xh?= =?us-ascii?Q?JZeEWsIo/jhDFx1Sz1PQS5mBGFXvK5BP8+O7rds1lbFltMe9W0Vai0LNvNlv?= =?us-ascii?Q?pcfizVXnHni3/y19DkDQDDH7Whpkm1ZHke4uFfRGa4xh5P2LziGct2FXpqbj?= =?us-ascii?Q?YmngiEp5CWdR1D2V5wew71Oy9glfUpW+9AaOyayvdITow3GCmhSiKyGwKU7y?= =?us-ascii?Q?+gcKr0oV+84jOtvjqNYvUPauqySUukaZ2ex/QXxx17pZK3TuSQtAEAHpsscu?= =?us-ascii?Q?NeEMzsRkdvTDckkCQMiGy6qUos=3D?= X-Microsoft-Antispam-Message-Info: Jbb/jEkIDjxPOjyYFPeCnqiWgoZb73196TNSMtBfo8oKE4zrngEILol1JzrkSVeGXCE8Ld0UXvRvqsDloi4YMIOFPGQk2SEkTLitmFgHaxTYmb/xe32T3iZaCmEC3ExSJ9z0vhE0W0osQ0tFDKTqkr6D2QyBjf4/dx8hkNGvJ+rAZn4ExvEkbWfvvUyAv7sV X-Microsoft-Exchange-Diagnostics: 1; DB7PR08MB2988; 6:aDIF/Qjz7MunDtXdKLpVj2wHlt/2Q38Mw05lU2ChzGNOe8xKXBiVTl21YC6jCz8N7CYROj/QTK2uJiIEJbTprbUYjxQagJacZ7Qc52Ob8lUZal9jT2JUQU9fb5KxV7EJHKm/Ppzt00U7GXb72h1ThibTKGWH3zbyBrBxZ4YJZFHr5IwoUsmGAUbSB7R2ccwTUzwjt585Q8q1x4+CyG5MVRPe+FhdrDHg7l6jIEMo2v/lfIvEnGl0mECIl1E5cZSD8TSN+yPmAYW1C5tQ9Zr0EWn5c8kw2Hs0CJtzPG5mK/RF74ZUk5BA1aTGA/57fKf9u5qvYDkDMiV9lLLrd1mQ1w2IzyTsbF/zDMGVBgid76oTme7Ens9uaMJBIHpBpmy/97FvPFvesTarNzIg7lrovB8R6mr3lOp2mzTmL+EVHYTIUnIH9oMhfansrDeW/ARHOq5bY+5SaMh4RAvN0nSFBA==; 5:nDbIHnFn2xMM/im1/sjKu6z5SFh5xaQhI/WFDSbjL0Gu0h07PbGMSmyH1UWr603H92o/KkgcNIQ/S537vBzQHZPuGp35NMp7hgmNZqw2JMbszKC33LnpYTNEFprzPkGFDw6nEEL0mSBOk2e9NoQdAXLKtDXYK1iy7h6Z9GkaCCc=; 24:gjAbmozAUXuUhngCr8rSEcSt2ZUf/QiuRoRqLTl0tkVQ/8FSMqd9i9IX94nuCoUpLsDk7AIKavyWbIQfWcvjKplwG6d4sSWiv7qwpm/5QkM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB7PR08MB2988; 7:U+zQ18YC9LA/+3Zm5rPKX2JQgc2inc3Xg3CJvZoSR7kGfVWF80dgbcstm+DJIlH9+GtmLAQCkwcVeFtOheif14UVM9dNjDrMMpxzU7FRL5NuwXak+sQNI3qNzl+WYNWZIdLUdrwjx6bqLq3qOxDwmE3mPNItVNweHyw/WgkF5e5HXNzn4EfyAALJbzt/pmiEwQ/8x9CzYIXirqBkm/i0vZK1/mgQa+ebakhCA6F8c4NqA1BxRFIkAzPywUW2Ipzo X-MS-Office365-Filtering-Correlation-Id: 9695446d-ee00-42d7-c6d0-08d59fb9a434 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2018 14:36:41.2359 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9695446d-ee00-42d7-c6d0-08d59fb9a434 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB2988 Subject: Re: [PATCH v1 03/18] ArmPkg/Include: Add MM interface SVC return codes. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 14:36:45 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Supreeth, On Fri, Apr 06, 2018 at 03:42:08PM +0100, Supreeth Venkatesh wrote: > This patch adds the Management Mode(MM) SVC return codes as specified in > http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM_MM_Interface_Specification.pdf. > Also, corrects SVC ID for retrieving SPM version information. The MM interface specification says nothing about these SVCs. At the moment, this interface is exported by Arm TF. So lets say that instead. Also, it would make sense to rename this file to ArmTfSpmSvc.h or similar 'cause this SVC interface is usable by non-MM partitions too. cheers, Achin > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > --- > ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > index 4c7b6c3386..a64b9ec23c 100644 > --- a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > +++ b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > @@ -20,7 +20,7 @@ > * delegated events and request the Secure partition manager to perform > * privileged operations on its behalf. > */ > -#define ARM_SVC_ID_SPM_VERSION_AARCH64 0xC4000060 > +#define ARM_SVC_ID_SPM_VERSION_AARCH32 0x84000060 > #define ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64 0xC4000061 > #define ARM_SVC_ID_SP_GET_MEM_ATTRIBUTES_AARCH64 0xC4000064 > #define ARM_SVC_ID_SP_SET_MEM_ATTRIBUTES_AARCH64 0xC4000065 > @@ -40,4 +40,11 @@ > ((((c_perm) & SET_MEM_ATTR_CODE_PERM_MASK) << SET_MEM_ATTR_CODE_PERM_SHIFT) | \ > (( (d_perm) & SET_MEM_ATTR_DATA_PERM_MASK) << SET_MEM_ATTR_DATA_PERM_SHIFT)) > > +/* MM SVC Return error codes */ > +#define ARM_SVC_SPM_RET_SUCCESS 0 > +#define ARM_SVC_SPM_RET_NOT_SUPPORTED -1 > +#define ARM_SVC_SPM_RET_INVALID_PARAMS -2 > +#define ARM_SVC_SPM_RET_DENIED -3 > +#define ARM_SVC_SPM_RET_NO_MEMORY -5 > + > #endif > -- > 2.16.2 >