From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4D63A22729612 for ; Thu, 12 Apr 2018 10:23:22 -0700 (PDT) Received: by mail-wr0-x243.google.com with SMTP id q13so2426578wre.3 for ; Thu, 12 Apr 2018 10:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5JC4Z8s2zC2qZbpvlrzwwrBY8fIyvslI2CqnqWdAH1I=; b=L6HcgvLdEmmAGJP6pXevmtEDE2xokwDzNIAK8vP8Zr9us3Adkk14Ne67DZ8NSbiY0m KYyaEpz6aZTPHH4zd3QGuO1dV7Vb6XgBcKrVG5xnMbpJIZ26mezA3qYuKEkXUZtySRwS f6XEGiQvzq67yhqnm9WH1Ob9geZO74KFxxvuI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5JC4Z8s2zC2qZbpvlrzwwrBY8fIyvslI2CqnqWdAH1I=; b=HH6SNtTOqQdS1c2gm8bAfn5stvfIKR3QW08z6vwSFMi0IQgXrB3rCWzpexVLcgft5z cWoPJna1kvxMaTStSkv21TDPpr0rh5/mSTFA9q8mvZEdBCLk7HXxZF3ve3z0hj1x1dV9 uyHNqyUy0aTIyGX7dDBqN8xqMBBHGdXYOwtlFc2Xn+qmrY06K7ZqdK4arOlcWFfguGiC EbnXxi2Coo7P9JByQUxFiIV4x2wAzgtdNVM1jsuKUxcLdXGWTTlTx0LD2V29f6yJm/RJ KfsiRd65dndU2OXZtWMjQyyYU9hKsxyaVuXz23VVUtJEdaovrPYDg8l78Y7qF/gVx7a1 2OwA== X-Gm-Message-State: ALQs6tBnP0v2/fXUIVSYr7XspB8IkYSLLMy3X1W/rjmVK+ioZMO+kxqH pne+Nj1ZJZpQPfJ5KXc6x4UGRw== X-Google-Smtp-Source: AIpwx49YUE4NICZqcpG1+NR9V5wPftKs3hdQQPWn23Jg+cVuZw5JdhewlM62mM30hNBLH54raeKTgw== X-Received: by 10.223.185.21 with SMTP id k21mr1493029wrf.116.1523553801443; Thu, 12 Apr 2018 10:23:21 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m35sm5354615wrm.59.2018.04.12.10.23.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Apr 2018 10:23:20 -0700 (PDT) Date: Thu, 12 Apr 2018 18:23:18 +0100 From: Leif Lindholm To: Laszlo Ersek , Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Steve Capper , Supreeth Venkatesh Message-ID: <20180412172318.jtugn7p3w2qgr24y@bivouac.eciton.net> References: <20180412005540.26651-1-lersek@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 17:23:24 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 12, 2018 at 12:09:46PM +0200, Ard Biesheuvel wrote: > On 12 April 2018 at 02:55, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/edk2.git > > Branch: depex_fixes > > > > ArmVirtQemu boots again, it just took a few more patches than I expected > > :) > > > > Some of these patches will have to be ported to edk2-platforms, I think. > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Steve Capper > > Cc: Supreeth Venkatesh > > > > Thanks, > > Laszlo > > > > Laszlo Ersek (10): > > Omap35xxPkg/InterruptDxe: replace CPU Arch Protocol depex with notify > > ArmPkg/ArmGicDxe: annotate protocol usage in "ArmGicDxe.inf" > > ArmPkg/CpuDxe: order CpuDxe after ArmGicDxe via protocol depex > > EmbeddedPkg: introduce NvVarStoreFormattedLib > > ArmPlatformPkg/NorFlashDxe: initialize varstore headers eagerly > > ArmPlatformPkg/NorFlashDxe: cue the variable driver with > > NvVarStoreFormatted > > ArmPlatformPkg/NorFlashDxe: depend on gEfiCpuArchProtocolGuid > > ArmPlatformPkg/PL031RealTimeClockLib: depend on > > gEfiCpuArchProtocolGuid > > ArmVirtPkg/PlatformHasAcpiDtDxe: depend on > > gEfiVariableArchProtocolGuid > > ArmVirtPkg/ArmVirtQemu: hook NvVarStoreFormattedLib into > > VariableRuntimeDxe > > > > Laszlo, > > Thanks a lot for taking care of this. I am glad we finally got rid of > the BEFORE depex in the NOR flash driver, which has been problematic > for years. > > For the series, > > Reviewed-by: Ard Biesheuvel > > but please allow some time for Leif to chime in as well. Well, there are a couple of places where I could nitpick on alphabetical sorting of includes, but none in files that weren't already disorderly. And like Ard, I am very grateful for this quite invasive (yet clean) bugfix. So, for 1-9/10: Reviewed-by: Leif Lindholm > > Thanks, > Ard. > > > > > ArmPkg/ArmPkg.dec | 2 - > > ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 8 +- > > ArmPkg/Drivers/CpuDxe/CpuDxe.inf | 2 +- > > ArmPlatformPkg/ArmPlatformPkg.dec | 4 - > > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 13 +--- > > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.h | 6 -- > > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf | 7 +- > > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c | 22 +++--- > > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf | 5 +- > > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > > ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf | 2 +- > > EmbeddedPkg/EmbeddedPkg.dec | 3 + > > EmbeddedPkg/Include/Guid/NvVarStoreFormatted.h | 39 ++++++++++ > > EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.c | 41 ++++++++++ > > EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 52 +++++++++++++ > > Omap35xxPkg/InterruptDxe/HardwareInterrupt.c | 81 +++++++++++++++----- > > Omap35xxPkg/InterruptDxe/InterruptDxe.inf | 6 +- > > 18 files changed, 230 insertions(+), 65 deletions(-) > > create mode 100644 EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > > create mode 100644 EmbeddedPkg/Include/Guid/NvVarStoreFormatted.h > > create mode 100644 EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.c > > > > -- > > 2.14.1.3.gb7cf6e02401b > >