From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::22c; helo=mail-wr0-x22c.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x22c.google.com (mail-wr0-x22c.google.com [IPv6:2a00:1450:400c:c0c::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9AC8B2244E3E3 for ; Mon, 16 Apr 2018 05:34:02 -0700 (PDT) Received: by mail-wr0-x22c.google.com with SMTP id y7so25506076wrh.10 for ; Mon, 16 Apr 2018 05:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XqBGdsy5pY5NTzpLWiJ3nPLhW3dwtS50E/sXzPdIGFM=; b=PndOE/jR4vbMkwb9X5LpYvf4pZnOFt6jHn/7YiPD3F5uzv9HCze2eVdUsrNp+ijWzg ZInpOsZaVfKJtRWvbGRcAI5KgCaLT+RMSEgqNQVKVJwvA+ih7BLfBFWqyLcstjOPCrYt z74Z0UlrdN19bvgT6kOJbl7MNTwZRLBoXhQ6Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XqBGdsy5pY5NTzpLWiJ3nPLhW3dwtS50E/sXzPdIGFM=; b=S1s3C5Hr9ottC/S5G1v1lUWfskJgnsSn75EGtrIhwHEGaGmNhfcoitv/63ohQTYC/w FqhmF2EmqqOY4/SscrDKBgiOxQW1CDPOxH4pWAqy10OmAfHRbEOVBrqMvgLapRHVbJWs jZhXw1GDKFCFC3IjIXrYwbq11IbE6MVgHRzsbAJDlLfc4x6s2Qx8lsCI2kih4eOhwtxy V9fz0hiGczj2nr6yDOh60M9jZRX4TTe9JdPlUYbfq/bHsKghl2Xnfy9BktM2i7Ixp6Q8 o6y+18LGs62sluDrmjAxpWkJLE8FTSTrjqZSsKeD78xAvcpapFje3kIa40kikFm2SX9U PU3w== X-Gm-Message-State: ALQs6tCjWaRRYJ0OSiTSxAmXk8WYZxByhSgbikqgko3M8Pm5jHi6so8b BRmXbtPzmNW3wBmrOqlPL6+AYPucfRk= X-Google-Smtp-Source: AIpwx4+fiBKIL9RFCMJ2xpS1eH/pEzMV9XA+BsdUVgAxKIEq20plGvrifY+1Ma8f6CumI5/MHLnzUQ== X-Received: by 10.28.31.19 with SMTP id f19mr1153718wmf.73.1523882039216; Mon, 16 Apr 2018 05:33:59 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p187sm6946270wme.8.2018.04.16.05.33.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Apr 2018 05:33:57 -0700 (PDT) Date: Mon, 16 Apr 2018 13:33:56 +0100 From: Leif Lindholm To: Guo Heyi Cc: edk2-devel@lists.01.org, "Ni, Ruiyu" Message-ID: <20180416123356.fbbfiyi7onnajuja@bivouac.eciton.net> References: <1520391833-9344-1-git-send-email-heyi.guo@linaro.org> <1520391833-9344-2-git-send-email-heyi.guo@linaro.org> <20180320075446.GH125210@SZX1000114654> <20180320095131.l2k2kk7nuxzv7r66@bivouac.eciton.net> <20180320121520.GI125210@SZX1000114654> <20180326090310.GB67369@SZX1000114654> <20180402025153.GB109127@SZX1000114654> MIME-Version: 1.0 In-Reply-To: <20180402025153.GB109127@SZX1000114654> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 12:34:03 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 02, 2018 at 10:51:53AM +0800, Guo Heyi wrote: > Hi Ray and Leif, > > Any comments? > > > On Mon, Mar 26, 2018 at 05:03:10PM +0800, Guo Heyi wrote: > > Thanks Ray. > > > > Does that mean we need build the dynamic command driver separately and store it > > in other media instead of UEFI fd image? Right now if I include the driver into > > the fd image, it will be automatically added to EFI Shell command list; we don't > > need to run the load command. > > > > Hi Leif, > > > > Is the policy to forbid including dynamic command driver into UEFI fd image? Let's just say that I am highly reluctant to have commands not covered by the UEFI Shell specification included by default. Especially commands that we know from experience have been misused in order to not have to figure out a sensible way of doing something properly ... and then been copied to new platforms by new developers coming in and looking at existing ports for reference. > > If we need other media to store tftp command driver, then the command will > > become less useful, because it is mainly used to download something else. If we > > have other media like USB disk, we can use this "other media" instead of network > > download to store the final target. If you are building a development image, by all means specify an appropriate build flag and have additional debug features built in. But if you are looking to use this for non-development builds, I would very much like to hear your use-case. Best Regards, Leif > > Thanks, > > Heyi > > > > On Fri, Mar 23, 2018 at 12:51:45PM +0800, Ni, Ruiyu wrote: > > > On 3/20/2018 8:15 PM, Guo Heyi wrote: > > > >I've no idea about how to use Driver####; let me spend some time to learn first > > > >:) > > > > > > Heyi, > > > you could use "load xxxDriver.efi" to load the dynamic command in shell. > > > After that, you can run "tftp" in shell just as running an internal command. > > > > > > > > > > >Regards, > > > > > > > >Heyi > > > > > > > >On Tue, Mar 20, 2018 at 09:51:32AM +0000, Leif Lindholm wrote: > > > >>Ah, apologies. > > > >> > > > >>I would be reluctant to add commands not covered by the UEFI Shell > > > >>Specification by default. > > > >> > > > >>Since it is now a dynamic command, is there any way of loading this > > > >>dynamically (perhaps via DRIVER####) where you feel the need for it? > > > >> > > > >>/ > > > >> Leif > > > >> > > > >>On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > > > >>>Ping :) > > > >>> > > > >>> > > > >>>On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: > > > >>>>On 7 March 2018 at 03:03, Heyi Guo wrote: > > > >>>>>Since D0x platforms always have network enabled, we would like to > > > >>>>>enable tftp command by default so that we can download something in > > > >>>>>EFI Shell. > > > >>>>> > > > >>>>>Contributed-under: TianoCore Contribution Agreement 1.1 > > > >>>>>Signed-off-by: Heyi Guo > > > >>>>>Cc: Ard Biesheuvel > > > >>>>>Cc: Leif Lindholm > > > >>>> > > > >>>>The first patch looks fine to me, but I would like to give Leif a > > > >>>>chance to comment on the policy side of this patch. > > > >>>> > > > >>>>Please ping us by the end of next week if we haven't responded by then. > > > >>>> > > > >>>>>--- > > > >>>>> Platform/Hisilicon/D03/D03.dsc | 2 ++ > > > >>>>> Platform/Hisilicon/D05/D05.dsc | 1 + > > > >>>>> 2 files changed, 3 insertions(+) > > > >>>>> > > > >>>>>diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > > >>>>>index cb0669d639d1..fce1e60b1275 100644 > > > >>>>>--- a/Platform/Hisilicon/D03/D03.dsc > > > >>>>>+++ b/Platform/Hisilicon/D03/D03.dsc > > > >>>>>@@ -29,6 +29,8 @@ [Defines] > > > >>>>> SKUID_IDENTIFIER = DEFAULT > > > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > >>>>> > > > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > >>>>>+ > > > >>>>> !include Silicon/Hisilicon/Hisilicon.dsc.inc > > > >>>>> > > > >>>>> [LibraryClasses.common] > > > >>>>>diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > > >>>>>index 8373a821a496..f007f3d2d7e8 100644 > > > >>>>>--- a/Platform/Hisilicon/D05/D05.dsc > > > >>>>>+++ b/Platform/Hisilicon/D05/D05.dsc > > > >>>>>@@ -29,6 +29,7 @@ [Defines] > > > >>>>> SKUID_IDENTIFIER = DEFAULT > > > >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > > >>>>> DEFINE EDK2_SKIP_PEICORE=0 > > > >>>>>+ DEFINE INCLUDE_TFTP_COMMAND = TRUE > > > >>>>> DEFINE NETWORK_IP6_ENABLE = FALSE > > > >>>>> DEFINE HTTP_BOOT_ENABLE = FALSE > > > >>>>> > > > >>>>>-- > > > >>>>>2.7.4 > > > >>>>> > > > >_______________________________________________ > > > >edk2-devel mailing list > > > >edk2-devel@lists.01.org > > > >https://lists.01.org/mailman/listinfo/edk2-devel > > > > > > > > > > > > > -- > > > Thanks, > > > Ray > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel