From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::232; helo=mail-wr0-x232.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x232.google.com (mail-wr0-x232.google.com [IPv6:2a00:1450:400c:c0c::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6F26722590E0B for ; Tue, 17 Apr 2018 06:55:42 -0700 (PDT) Received: by mail-wr0-x232.google.com with SMTP id z73so35799242wrb.0 for ; Tue, 17 Apr 2018 06:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NcsZiDAUNE8k/o+UrDtEFo+LQS11nUnH7FRyfkZk++4=; b=S6pFujqQ2TNj0HSnFQtKdyYfQU5dLdzU5Xv4U383SQIYestH6QHLWVjbMs/yLN9bLW 5STrOGl/YuTqOUDnaDf6YSquj+sqQmuYv48tNoB1ozcOYyejkV8fjOsRMJK76LSTK6Yn L3fYZ2G/1NxJkIBFMOXvzAjgoSSo7nQHBrZuk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NcsZiDAUNE8k/o+UrDtEFo+LQS11nUnH7FRyfkZk++4=; b=LB1kh3mBWeV6guJ+vSKjGDI0np5DQWUiKTy6V9nSlOItH9FuB4ZkHp7yOwWP20g2Ik nlZmsyJTJuE3+xRStbz/SFLVYo131ETyC8d8m0RrIDAH1+SKdtuXOWqoiSoxhp4r1dtv 1/bzeivIo/bRU/aVggZaxKk+Fv/xNS5e8ILJGhshuR9sLk3LW8TXanVCc4nvRSLib7zt F2V8LaqPFi76X39mwl/jTeofg4meXciJ6d/XUc9f5ZaJr/AhUmcH2iRS6s9Bgsn5XJqX MEa6dQtq7QVh3pV4pwUyeg1Jk1GP2nM0hOT7AMkCpQ0jjFg/yV3nkIjd3x+vQYg5wCFA Hayg== X-Gm-Message-State: ALQs6tD3gCGLbZYA34z9KMfbRQO44nVPGQW4B4tK5ewaO9XtgEAVwMXU 1OQuBkMq8zXI1SCK/8QN8Trv1JsrKzU= X-Google-Smtp-Source: AIpwx49X35xMwGuk8kZ6fdKIDoNCLHqs1VFV5qsliudwfu+pIrDI/Em9ZRLDkQHO0p0R+qBuHs/Jng== X-Received: by 10.223.152.142 with SMTP id w14mr1826711wrb.210.1523973340654; Tue, 17 Apr 2018 06:55:40 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j17sm10003073wmc.26.2018.04.17.06.55.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Apr 2018 06:55:39 -0700 (PDT) Date: Tue, 17 Apr 2018 14:55:38 +0100 From: Leif Lindholm To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" Message-ID: <20180417135538.4a26k4atmyvcotkj@bivouac.eciton.net> References: <20180413174211.858-1-leif.lindholm@linaro.org> <20180413193143.t45tua3yi7sopk4d@bivouac.eciton.net> <20180416100712.6v642ycksvmoffvt@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: (spawning off more style discussion) X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 13:55:42 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 16, 2018 at 09:32:44PM +0200, Laszlo Ersek wrote: > (4) Please consider adopting > > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-10 > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 > > so that patches roughly advance from "abstract" to "concrete". I have been reluctant to adopt this aspect of the guidance since it means project-specific syntax to generic commands (whereas --stat-graph-width and --stat are generic and not always needed). However, at least newer versions of git seem to support a diff.orderFile config option. So you should see this improved in future patches from me. > (6) Please don't use "__" and "_C" prefixes for identifiers (see > __CONCATENATE and _CONCATENATE); according to the C standard, "All > identifiers that begin with an underscore and either an uppercase > letter or another underscore are always reserved for any use". > > I know Linux uses "__" prefixes liberally; that doesn't make them > any less wrong :) I stole those internal names from MdePkg/Include/Base.h While that makes me a double-baddie - should we have some global macros for this particularly awkward bit of CPP-ness? > ... Obviously I don't insist on these patches being implemented "my > way"; I'm stating my opinion because you CC'd me :) (Thanks for that!) And your input is always appreciated. / Leif