From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::22a; helo=mail-wr0-x22a.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x22a.google.com (mail-wr0-x22a.google.com [IPv6:2a00:1450:400c:c0c::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 41F692265A18C for ; Tue, 17 Apr 2018 09:44:09 -0700 (PDT) Received: by mail-wr0-x22a.google.com with SMTP id u11so37334728wri.12 for ; Tue, 17 Apr 2018 09:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4yK9YQld408qY8ocJwtCU/f1k33DVe7BD8NUpNwbp1k=; b=IPSD040B3PC8IdsJLgZ4NINtaO7aVRLc1zv3juph+7Fw9Rc8c8BNYyfxmVwQY2PQR2 K6QRPtAWydqU40yLNUKvvOB2+bzDkj3r+FKpll9ujLsa/34bvzWh99HEd4tFk3Bc6NdC Rbov/IhBcwzGidU73CrLBwnL4WagIwpJmo5IU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4yK9YQld408qY8ocJwtCU/f1k33DVe7BD8NUpNwbp1k=; b=R8qe04/hoLI4ucjzgx4ZcXSNcwn/D5pOlAr4eX6iRjV0UfzRTxTLbv9sChSRQxrEAm QvR3YCRNNPS8nV2P7pF6FCl+3KCtSXmULo2UJPTICbJ8m1iPRImhDvvcFKMdGpbjICUZ 4KShFrlqMKFAMMfnFLFBmsZdzvj/IvSS/70rstmbPaXaEvMTU9jqdu/1oQpJVDoKuQHU UQpvZ/udOCHTzVUq90NMfLM+LJn34Aid+1u/FdwqdKzuJEb0hxPV6OkYJDxUP82auNb4 AR/9ZaJexXV7eU2PfSgxw/U+PzDdWn1/I0wDcGwb9NYrl5iotQR+HWDwtK04dfNXkuj7 7Trw== X-Gm-Message-State: ALQs6tAxzh9fiSBf+X6vyXcPx7Bm81AygWT6tB14XSZrl3JDOTymifjq fH9jv/R0b6aCOJBowIRpXxKqwA== X-Google-Smtp-Source: AIpwx4/VO/ha5ZhnN6KC0H1V85sGnL28Q7sCaBO3zvSLNFmi5rMqEmGSQ8UqHXO7KwYzGAaDw1Ifjw== X-Received: by 10.223.152.83 with SMTP id v77mr2183417wrb.225.1523983447764; Tue, 17 Apr 2018 09:44:07 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 60sm8229753wrj.62.2018.04.17.09.44.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Apr 2018 09:44:06 -0700 (PDT) Date: Tue, 17 Apr 2018 17:44:05 +0100 From: Leif Lindholm To: Meenakshi Cc: ard.biesheuvel@linaro.org, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com Message-ID: <20180417164405.mzmxbs6qfhgt5asi@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 00/39] NXP: Add support of LS1043, LS1046 and LS2088 SoCs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 16:44:09 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Could you please integrate the below changes in whichever commits they belong individually? - Clarifications (via file name changes) of which .dsc files are meant as include files rather than standalone platform descriptions. - Getting rid of relative paths to locate said include files. (No, I don't need copyright or attribution, it's just a more structured way to provide this particular bit of feedback.) / Leif >>From 7da6ca87177153532811f8ecd9ad6847b480161e Mon Sep 17 00:00:00 2001 From: Leif Lindholm Date: Tue, 17 Apr 2018 16:22:00 +0100 Subject: [PATCH edk2-platforms] {Platform|Silicon}/NXP: Build config includes cleanup --- Platform/NXP/{NxpQoriqLs.dsc => NxpQoriqLs.dsc.inc} | 0 Silicon/NXP/LS1043A/{LS1043A.dsc => LS1043A.dsc.inc} | 0 Silicon/NXP/LS1046A/{LS1046A.dsc => LS1046A.dsc.inc} | 0 Silicon/NXP/LS2088A/{LS2088A.dsc => LS2088A.dsc.inc} | 0 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 4 ++-- Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc | 4 ++-- Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc | 4 ++-- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 2 +- Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf | 2 +- Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf | 2 +- 10 files changed, 9 insertions(+), 9 deletions(-) rename Platform/NXP/{NxpQoriqLs.dsc => NxpQoriqLs.dsc.inc} (100%) rename Silicon/NXP/LS1043A/{LS1043A.dsc => LS1043A.dsc.inc} (100%) rename Silicon/NXP/LS1046A/{LS1046A.dsc => LS1046A.dsc.inc} (100%) rename Silicon/NXP/LS2088A/{LS2088A.dsc => LS2088A.dsc.inc} (100%) diff --git a/Platform/NXP/NxpQoriqLs.dsc b/Platform/NXP/NxpQoriqLs.dsc.inc similarity index 100% rename from Platform/NXP/NxpQoriqLs.dsc rename to Platform/NXP/NxpQoriqLs.dsc.inc diff --git a/Silicon/NXP/LS1043A/LS1043A.dsc b/Silicon/NXP/LS1043A/LS1043A.dsc.inc similarity index 100% rename from Silicon/NXP/LS1043A/LS1043A.dsc rename to Silicon/NXP/LS1043A/LS1043A.dsc.inc diff --git a/Silicon/NXP/LS1046A/LS1046A.dsc b/Silicon/NXP/LS1046A/LS1046A.dsc.inc similarity index 100% rename from Silicon/NXP/LS1046A/LS1046A.dsc rename to Silicon/NXP/LS1046A/LS1046A.dsc.inc diff --git a/Silicon/NXP/LS2088A/LS2088A.dsc b/Silicon/NXP/LS2088A/LS2088A.dsc.inc similarity index 100% rename from Silicon/NXP/LS2088A/LS2088A.dsc rename to Silicon/NXP/LS2088A/LS2088A.dsc.inc diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc index 8cbaf8829c..e75672cd0c 100644 --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc @@ -28,8 +28,8 @@ [Defines] OUTPUT_DIRECTORY = Build/LS1043aRdbPkg FLASH_DEFINITION = Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf -!include ../NxpQoriqLs.dsc -!include ../../../Silicon/NXP/LS1043A/LS1043A.dsc +!include Platform/NXP/NxpQoriqLs.dsc.inc +!include Silicon/NXP/LS1043A/LS1043A.dsc.inc [LibraryClasses.common] ArmPlatformLib|Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf diff --git a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc index 231207d7ca..93a01a770f 100644 --- a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc +++ b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc @@ -28,8 +28,8 @@ [Defines] OUTPUT_DIRECTORY = Build/LS1046aRdbPkg FLASH_DEFINITION = Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf -!include ../NxpQoriqLs.dsc -!include ../../../Silicon/NXP/LS1046A/LS1046A.dsc +!include Platform/NXP/NxpQoriqLs.dsc.inc +!include Silicon/NXP/LS1046A/LS1046A.dsc.inc [LibraryClasses.common] ArmPlatformLib|Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf diff --git a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc index 1ae55d4584..7605ea50f8 100755 --- a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc +++ b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc @@ -29,8 +29,8 @@ [Defines] FLASH_DEFINITION = Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf DEFINE MC_HIGH_MEM = TRUE -!include ../NxpQoriqLs.dsc -!include ../../../Silicon/NXP/LS2088A/LS2088A.dsc +!include Platform/NXP/NxpQoriqLs.dsc.inc +!include Silicon/NXP/LS2088A/LS2088A.dsc.inc [LibraryClasses.common] ArmPlatformLib|Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf index 7993bf170a..c88bbe1475 100644 --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf @@ -54,7 +54,7 @@ [FD.LS1043ARDB_EFI] gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize FV = FVMAIN_COMPACT -!include ../FVRules.fdf.inc +!include Platform/NXP/FVRules.fdf.inc !include VarStore.fdf.inc ################################################################################ # diff --git a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf index 3351a062e9..8ae0ada5b2 100644 --- a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf +++ b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf @@ -54,7 +54,7 @@ [FD.LS1046ARDB_EFI] gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize FV = FVMAIN_COMPACT -!include ../FVRules.fdf.inc +!include Platform/NXP/FVRules.fdf.inc ################################################################################ # # FV Section diff --git a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf index 35a79bda6f..93760df409 100644 --- a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf +++ b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf @@ -54,7 +54,7 @@ [FD.LS2088aRdb_EFI] gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize FV = FVMAIN_COMPACT -!include ../FVRules.fdf.inc +!include Platform/NXP/FVRules.fdf.inc !include VarStore.fdf.inc ################################################################################ # -- 2.11.0