From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D9A07226838FF for ; Wed, 18 Apr 2018 03:59:31 -0700 (PDT) Received: by mail-wr0-x244.google.com with SMTP id h3-v6so3612033wrh.5 for ; Wed, 18 Apr 2018 03:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JJXNm3/Zm++8zXR/eCJ0UXXzHLy9qz2xU6BakgZo0sw=; b=TA8ydSMEH7hS2TsPqm5Hpwv4MTqu48uXCZTmYkqvzWc7OKCw0F6N50+pxHk9v7l0hF 1RDlMQi0P2Qq6haFytw8isjhavpf1cqzCLKaS5gQKIlrFY+MDVhtWREe6Xd5vQMPbZQ/ Y5RmXQRdwl6J9aaDYeSBdAzrPIPlyK8DJlvhY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JJXNm3/Zm++8zXR/eCJ0UXXzHLy9qz2xU6BakgZo0sw=; b=SPj8FyYwxeiVaVEzpAaTfITu235jW5d58LaZxFnVuuiF/G6B66Rs6fd4xWvNPobXnA 16XNqPNvRtDo4mG4Dthmxyj3DgwdQNfld+Q3GQ/zNcbHDAtfBUq71+uzaTDk2iRLK5NL yiXsY+h965gCKwQGCdMxKtaqtStAxOC2W+868IP4/BjJ9SJEtZFDLVCyBGLXsX6FeWoa TaS56EhOac36jR1Ijq8sH7LvA4lTLTf7C55tMAPOR1TKwhtfqgXUGDUAOOOoWqGluWkZ 0ZRbGC5yMJUJjOSnLGJHpNUlLMhhtG/JrRr6ut5GPs6ncPm/sd+9HZudQQdyoTEp3ESC kQ/w== X-Gm-Message-State: ALQs6tApveYiQsqdP1SIGKuEOzzQTqnm0NbV9bXIkkGHdPomt9Qumrfy JUisO3HPPBjl3gRIDr5dhKLuUg== X-Google-Smtp-Source: AIpwx4/UxThrH2JOBdxy6GX9w+vwP+h3ehCoszD9brsav6LQh+KYbPIEGv9eveupS/lTnQVOUc5YZA== X-Received: by 10.28.15.83 with SMTP id 80mr1452282wmp.151.1524049169998; Wed, 18 Apr 2018 03:59:29 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 78sm1835029wmm.19.2018.04.18.03.59.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Apr 2018 03:59:29 -0700 (PDT) Date: Wed, 18 Apr 2018 11:59:27 +0100 From: Leif Lindholm To: Heyi Guo Cc: edk2-devel@lists.01.org, Ard Biesheuvel Message-ID: <20180418105927.cgppqxhl7qglx3zn@bivouac.eciton.net> References: <1520391833-9344-1-git-send-email-heyi.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: <1520391833-9344-1-git-send-email-heyi.guo@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 10:59:32 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 07, 2018 at 11:03:52AM +0800, Heyi Guo wrote: > We need to set PcdShellLibAutoInitialize to FALSE for > TftpDynamicCommand, or else we will get initialization failure when > loading TftpDynamicCommand module, for EFI Shell has not been started > at this moment. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo > Cc: Ard Biesheuvel > Cc: Leif Lindholm Reviewed-by: Leif Lindholm As requested on other thread, pushed separately as 06866930dc. > --- > Platform/Hisilicon/D03/D03.dsc | 5 ++++- > Platform/Hisilicon/D05/D05.dsc | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > index c4963063794b..cb0669d639d1 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -517,5 +517,8 @@ [Components.common] > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 > } > !ifdef $(INCLUDE_TFTP_COMMAND) > - ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > !endif #$(INCLUDE_TFTP_COMMAND) > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > index 0792b0814ea1..8373a821a496 100644 > --- a/Platform/Hisilicon/D05/D05.dsc > +++ b/Platform/Hisilicon/D05/D05.dsc > @@ -675,5 +675,8 @@ [Components.common] > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 > } > !ifdef $(INCLUDE_TFTP_COMMAND) > - ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > !endif #$(INCLUDE_TFTP_COMMAND) > -- > 2.7.4 >