From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B686622637DF3 for ; Thu, 19 Apr 2018 02:54:48 -0700 (PDT) Received: by mail-wr0-x244.google.com with SMTP id o15-v6so12302513wro.11 for ; Thu, 19 Apr 2018 02:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wJSH6eqncNFhSFlIDBbWu/ZtgT0/HqCkzVyJVYCp0cc=; b=KeD5N/m4MHhGOtyYhR8nG88SYVguKUmVq8+RH3YtdU7D9Qc+ZiStMcMFZjzLZ6M4Fi 4uBfUBn/gwGt0k88tp4ThoDyMYBDnrfxmWJE0iFqSI9NY6+kwrZ9CEh0XronltH3jvjY IRAbC/R0GE3QkP7BathApPBA+ubJ4BlCNsNTI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wJSH6eqncNFhSFlIDBbWu/ZtgT0/HqCkzVyJVYCp0cc=; b=O6mNUpvg3gPnJ7KMK2DhfoLhoOnnvCjpLdCRlBuiLfla4WEn5ebYi/V3jjzDedWfxP DucAeuv8L9m7lB2ebORv5Nz2+UeTINhBajwYWPnP+qdWX+GEO8KQeN0R7x3OxF39XJlN 1sYW1UzRPuxZNaNu9BgLe26i7NCkdkZjyqkUJI5rwHpZspnOMYNBI835HEFtbVAvGNI4 7mlHGSblIn7bHNeUPWLPHsvS91Ogid6YlD03lV0UnpaKeZO6oEbnIDY/7Y2JFqixmZRw Gt8TtI9hO95ElrnSXPaMmVIIzycRKazm8mzqxBA3wQI2G1eJGn4iPoMW3RyBRuhkn3F7 PXjw== X-Gm-Message-State: ALQs6tAcZVznn+RCCRVFgGoK29mQI343g9lsl3l8fB9TFfNUw239V7k6 +fGHe83528teWB7Hzy+0HpgU7A== X-Google-Smtp-Source: AIpwx48LumqVFWGDtWUE4HU50hEEhLu/2NDu9iP7vnXCG9jUmF3ajJ6mmtvH2WrW/FFC3rW/dML6vw== X-Received: by 2002:adf:c590:: with SMTP id m16-v6mr4222400wrg.220.1524131686956; Thu, 19 Apr 2018 02:54:46 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j1-v6sm3385099wre.25.2018.04.19.02.54.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Apr 2018 02:54:45 -0700 (PDT) Date: Thu, 19 Apr 2018 10:54:44 +0100 From: Leif Lindholm To: Meenakshi Cc: ard.biesheuvel@linaro.org, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com Message-ID: <20180419095443.osycgsgn6nbpyi3k@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1518771035-6733-18-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1518771035-6733-18-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 17/39] LS1043 : Enable NOR driver for LS1043aRDB package. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 09:54:49 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 16, 2018 at 02:20:13PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal Will this one require any changes to build (and work correctly) against current edk2? If not: Reviewed-by: Leif Lindholm / Leif > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 16 +++++++++++++++- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 9 ++++++++- > 2 files changed, 23 insertions(+), 2 deletions(-) > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > index df4d917..7708e0a 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > @@ -41,6 +41,7 @@ > IfcLib|Silicon/NXP/Library/IfcLib/IfcLib.inf > BoardLib|Platform/NXP/LS1043aRdbPkg/Library/BoardLib/BoardLib.inf > FpgaLib|Platform/NXP/LS1043aRdbPkg/Library/FpgaLib/FpgaLib.inf > + NorFlashLib|Silicon/NXP/Library/NorFlashLib/NorFlashLib.inf > > [PcdsFixedAtBuild.common] > > @@ -70,6 +71,13 @@ > gDs1307RtcLibTokenSpaceGuid.PcdI2cSlaveAddress|0x68 > gDs1307RtcLibTokenSpaceGuid.PcdI2cBusFrequency|100000 > > + # > + # NV Storage PCDs. > + # > + gArmTokenSpaceGuid.PcdVFPEnabled|1 > + gNxpQoriqLsTokenSpaceGuid.PcdFlashDeviceBase64|0x060000000 > + gNxpQoriqLsTokenSpaceGuid.PcdFlashReservedRegionBase64|0x60300000 > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -79,9 +87,15 @@ > # > # Architectural Protocols > # > - MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf > + > + MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf{ > + > + NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > + } > + MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > > Silicon/NXP/Drivers/WatchDog/WatchDogDxe.inf > Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > + Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > > ## > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > index fa6510c..6b5b63f 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > @@ -55,6 +55,7 @@ gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > FV = FVMAIN_COMPACT > > !include ../FVRules.fdf.inc > +!include VarStore.fdf.inc > ################################################################################ > # > # FV Section > @@ -103,7 +104,8 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > INF EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf > - INF MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf > + INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > + INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > INF MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf > > INF Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > @@ -123,6 +125,11 @@ READ_LOCK_STATUS = TRUE > INF EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOutSerial.inf > > # > + # NOR Driver > + # > + INF Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > + > + # > # Network modules > # > INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > -- > 1.9.1 >