From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::230; helo=mail-wr0-x230.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x230.google.com (mail-wr0-x230.google.com [IPv6:2a00:1450:400c:c0c::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0D00C2268478C for ; Thu, 19 Apr 2018 03:20:52 -0700 (PDT) Received: by mail-wr0-x230.google.com with SMTP id f14-v6so12536767wre.4 for ; Thu, 19 Apr 2018 03:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QaLFPSWT27RFAlPOYfCNGixR8n2ogSRINxljqxrXc5w=; b=DQSjCmeTd+4EHQICid678Qw/hRUxIBOS6KuxsQMTvSrU5SmI2zdMbjTqfzZIWW5vmd 4yxE0xHt8LcyCzHyrja7O0hOYc8bqpqikh9BvXAWd1+5DNlk8nL55Fi+D0coB0pa7Nje egAoreafltPmyTlHluhUudvk52j9ne+PHELZE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QaLFPSWT27RFAlPOYfCNGixR8n2ogSRINxljqxrXc5w=; b=t/xNT2vFDIUqiZIKyXvse9Yk6bcg7716ocgpCbTVEIMQqDfQW7/jkqWPBSoZxmW0i+ 5e3GLL05+jhBwQZtTFoxpOMMvonflyzxU39TXLj60HqbSuomPymHB7m85FZLErkFeFAd SFzntNv5iqbN21ylWQSu8x4UEEKl6oGgY4q7+/rxldCUHECh95ZF+EIRcW0DLkB+h9I8 LVyV3l8rAlMublDN6SrEIZaMrpsZloF2TGXwXSwY7rqw9IDoackn3m7rtHel+FoYTYOi xAv4HzptrCshIArherewI2f61JgsY4XQholshokB+L6PSQGLGZGNf7g6NTqgklpJxmFH fFTg== X-Gm-Message-State: ALQs6tAxaii/Zge+AGRyZkjYoA+Wkks66j+hz+gwED+xCsbdnAU7N3Me gFc9wPgxcC24h+WZtB018x1IMg== X-Google-Smtp-Source: AIpwx4/lXZBVLU5IjWsp4CGNVlSbUz/ctoyytHg+coG0rBOjuVS6T4FeOv2PQDoZBVYqaenk6JdH8g== X-Received: by 10.28.212.149 with SMTP id l143mr793339wmg.144.1524133251341; Thu, 19 Apr 2018 03:20:51 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a13-v6sm3521444wrc.19.2018.04.19.03.20.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Apr 2018 03:20:50 -0700 (PDT) Date: Thu, 19 Apr 2018 11:20:48 +0100 From: Leif Lindholm To: Meenakshi Aggarwal Cc: "ard.biesheuvel@linaro.org" , "edk2-devel@lists.01.org" , Udit Kumar , Varun Sethi , Vabhav Sharma Message-ID: <20180419102048.ffxvlydmuss4gkrk@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1518771035-6733-19-git-send-email-meenakshi.aggarwal@nxp.com> <20180419100050.bl4tdllduqmet6eo@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 18/39] Silicon/NXP:Add LS1046ARDB SoCLib Support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 10:20:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 19, 2018 at 10:05:45AM +0000, Meenakshi Aggarwal wrote: > > CCSR_SCFG_USBDRVVBUS_SELCR_USB1); > > > + UsbPwrFault = (CCSR_SCFG_USBPWRFAULT_DEDICATED << > > > + CCSR_SCFG_USBPWRFAULT_USB3_SHIFT) | > > > + (CCSR_SCFG_USBPWRFAULT_DEDICATED << > > > + CCSR_SCFG_USBPWRFAULT_USB2_SHIFT) | > > > + (CCSR_SCFG_USBPWRFAULT_SHARED << > > > + CCSR_SCFG_USBPWRFAULT_USB1_SHIFT); > > > > Can you change indentation like so?: > > > > UsbPwrFault = (CCSR_SCFG_USBPWRFAULT_DEDICATED << > > CCSR_SCFG_USBPWRFAULT_USB3_SHIFT) | > > (CCSR_SCFG_USBPWRFAULT_DEDICATED << > > CCSR_SCFG_USBPWRFAULT_USB2_SHIFT) | > > (CCSR_SCFG_USBPWRFAULT_SHARED << > > CCSR_SCFG_USBPWRFAULT_USB1_SHIFT); > > > I will accommodate all other changes except I am not getting the > difference between above two. Please tell a bit about the change. Apologies, I could have been more clear. First of all, it makes the relation between the items within parameters immediately obvious. It is a continuation of the statement within the parentheses. Secondly, it aligns up all of the CCSR_SCFG_USBPWRFAULT_, which makes it a lot easier to see that all the prefixes are the same. In summary, it makes code review easier. Best Regards, Leif