From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 67AC421E080FD for ; Thu, 19 Apr 2018 09:31:11 -0700 (PDT) Received: by mail-wr0-x241.google.com with SMTP id s18-v6so15680421wrg.9 for ; Thu, 19 Apr 2018 09:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QUgsOIb0JFSRyvaucHGYKD5K6Mrsof6OqUGI6VMkLkk=; b=NQwyqNGBmlh7BlXhyd7AXINhsDcRbDo05CqN6dC3kYzq8ZpOvbmohmUH+1WLUN6zzP PVi5LRniP4TIZYkFMgbsVxa51RUbMVFnTS4wlh9gC7WgXKfQkfa70VVCvsIDA5u2jcj9 joG5MCxdETb3En07c6WFXU65yQYXF54vX/OhE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QUgsOIb0JFSRyvaucHGYKD5K6Mrsof6OqUGI6VMkLkk=; b=ijrkHDxCePGJND5tJP30QdkresV/eMjI839QjJ9dp7A1OVgfXuI61alQ4rcxRKWRBz SBuBDgH6TYUTbYi+aseUZGEcsUSFdulV5WbfYy0dTanACC/gIjPprFMo67EYnn+zxxHs AuBg6ozTHM1XRzsI8166egCT5XOGg0lA755UMWFL1exncZam4BTugtVnItwrvvUQ6Hhq 4HHSzLfGRYIyiIM58vlpJTW5Bs7lXWK3eI+v3vlGBe2IbXmDLMir5l/9w8STYzsCxfqm nbfO8+rHkAHl+8cjNVirrIHynWQxlrAhK8iBb6iNEDmT2q4NlhtIOUHa5gVaBrMW+xMo NlBw== X-Gm-Message-State: ALQs6tDHzUgyo/v+5gv8l6r2ZXGkyrQiZGk+869lGx90TKl03jp5UZ4m qVoelZwOtPcJ9wypxYKbKXs5DQ== X-Google-Smtp-Source: AIpwx4/19NcJhXy91rnMhejKdnOaPVOKy75xxmRAyamxnTJP2s2CQh6IQRqz8JFHv5mFXrs4CSGqgw== X-Received: by 2002:adf:b71a:: with SMTP id l26-v6mr5440022wre.115.1524155469891; Thu, 19 Apr 2018 09:31:09 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 58-v6sm7937268wrv.41.2018.04.19.09.31.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Apr 2018 09:31:08 -0700 (PDT) Date: Thu, 19 Apr 2018 17:31:07 +0100 From: Leif Lindholm To: Meenakshi Cc: ard.biesheuvel@linaro.org, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com, Wasim Khan Message-ID: <20180419163106.oajtxgwnats4fhdj@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1518771035-6733-31-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1518771035-6733-31-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 30/39] LS2088 : Enable support of FpgaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 16:31:11 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 16, 2018 at 02:20:26PM +0530, Meenakshi wrote: > From: Wasim Khan > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wasim Khan Reviewed-by: Leif Lindholm > --- > Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc | 3 +++ > Silicon/NXP/Chassis/Chassis3/Soc.c | 18 +++++++++++++++++- > Silicon/NXP/Chassis/Chassis3/Soc.h | 1 - > Silicon/NXP/Chassis/LS2088aSocLib.inf | 2 ++ > Silicon/NXP/LS2088A/LS2088A.dsc | 1 + > 5 files changed, 23 insertions(+), 2 deletions(-) > > diff --git a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > index c0a802d..7894925 100755 > --- a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > +++ b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > @@ -39,6 +39,9 @@ > BeIoLib|Silicon/NXP/Library/BeIoLib/BeIoLib.inf > SocLib|Silicon/NXP/Chassis/LS2088aSocLib.inf > RealTimeClockLib|Silicon/Maxim/Library/Ds3232RtcLib/Ds3232RtcLib.inf > + IfcLib|Silicon/NXP/Library/IfcLib/IfcLib.inf > + BoardLib|Platform/NXP/LS2088aRdbPkg/Library/BoardLib/BoardLib.inf > + FpgaLib|Platform/NXP/LS2088aRdbPkg/Library/FpgaLib/FpgaLib.inf > > [PcdsFixedAtBuild.common] > > diff --git a/Silicon/NXP/Chassis/Chassis3/Soc.c b/Silicon/NXP/Chassis/Chassis3/Soc.c > index ed6c3cc..dbb1884 100644 > --- a/Silicon/NXP/Chassis/Chassis3/Soc.c > +++ b/Silicon/NXP/Chassis/Chassis3/Soc.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -25,6 +26,9 @@ > > #include "Soc.h" > > +extern VOID PrintBoardPersonality (VOID); > +extern UINTN GetBoardSysClk (VOID); > + > VOID > GetSysInfo ( > OUT SYS_INFO *PtrSysInfo > @@ -83,7 +87,7 @@ GetSysInfo ( > > GurBase = (VOID *)PcdGet64 (PcdGutsBaseAddr); > ClkBase = (VOID *)PcdGet64 (PcdClkBaseAddr); > - SysClk = CLK_FREQ; > + SysClk = GetBoardSysClk (); > > PtrSysInfo->FreqSystemBus = SysClk; > PtrSysInfo->FreqDdrBus = PcdGet64 (PcdDdrClk); > @@ -152,6 +156,13 @@ SocInit ( > SmmuInit (); > > // > + // Perform IFC Initialization. > + // Early IFC initialization is required to set timings required for fpga initilzation to > + // get system clock frequency, board info etc. > + // > + IfcInit (); > + > + // > // Initialize the Serial Port. > // Early serial port initialization is required to print RCW, Soc and CPU infomation at > // the begining of UEFI boot. > @@ -176,5 +187,10 @@ SocInit ( > // Print Soc Personality information > // > PrintSoc (); > + > + // > + // Print Board Personality information > + // > + PrintBoardPersonality (); > } > > diff --git a/Silicon/NXP/Chassis/Chassis3/Soc.h b/Silicon/NXP/Chassis/Chassis3/Soc.h > index 0e892fb..c3ac1d5 100644 > --- a/Silicon/NXP/Chassis/Chassis3/Soc.h > +++ b/Silicon/NXP/Chassis/Chassis3/Soc.h > @@ -20,7 +20,6 @@ > #define FSL_CLK_GRPA_ADDR 0x01300000 > #define FSL_CLK_GRPB_ADDR 0x01310000 > #define NUM_CC_PLLS 6 > -#define CLK_FREQ 100000000 > > #define FSL_CLUSTER_CLOCKS { 1, 1, 4, 4 } /* LS208x */ > #define TP_CLUSTER_EOC_MASK 0x80000000 /* Mask for End of clusters */ > diff --git a/Silicon/NXP/Chassis/LS2088aSocLib.inf b/Silicon/NXP/Chassis/LS2088aSocLib.inf > index 8a4da50..3111d49 100644 > --- a/Silicon/NXP/Chassis/LS2088aSocLib.inf > +++ b/Silicon/NXP/Chassis/LS2088aSocLib.inf > @@ -31,6 +31,8 @@ > BaseLib > BeIoLib > DebugLib > + FpgaLib > + IfcLib > SerialPortLib > > [Sources.common] > diff --git a/Silicon/NXP/LS2088A/LS2088A.dsc b/Silicon/NXP/LS2088A/LS2088A.dsc > index 8f7dbb5..2cff40f 100644 > --- a/Silicon/NXP/LS2088A/LS2088A.dsc > +++ b/Silicon/NXP/LS2088A/LS2088A.dsc > @@ -67,5 +67,6 @@ > gNxpQoriqLsTokenSpaceGuid.PcdI2c0BaseAddr|0x02000000 > gNxpQoriqLsTokenSpaceGuid.PcdI2cSize|0x10000 > gNxpQoriqLsTokenSpaceGuid.PcdNumI2cController|4 > + gNxpQoriqLsTokenSpaceGuid.PcdIfcBaseAddr|0x02240000 > > ## > -- > 1.9.1 >