From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CE4FD2251212C for ; Fri, 20 Apr 2018 08:33:18 -0700 (PDT) Received: by mail-wr0-x244.google.com with SMTP id m26-v6so6230078wrb.3 for ; Fri, 20 Apr 2018 08:33:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WEsTtpNVl032te7tAkUV0MLUOLjuLGhVGBhvnYjUgxc=; b=KntbHpv4QGppOYJEk08A5uZftsi65RR6MlfilLFSkTPOv0uL8P9WMR6VkKJU8+yc6l JnUBlYGxD8TR0/2Vqq84gdFmYiDe3HSOyDr/IOe75mhTYKjEC2dGRNJp34IyPyD8xizJ /Ux+ub9foPVj2A0mYp87iRMUZ2pTWPzT/OjbY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WEsTtpNVl032te7tAkUV0MLUOLjuLGhVGBhvnYjUgxc=; b=JFGeLU65iaPNVh7l0EyaCGTEybX33Bk8Opy0ln1HRTHN6CBxONb+Lus7J8tCE+Rui+ a6/4iRMbaY4RFBSJUu6zMV6xI+1/helO8sz9t59CrpNNaP8EgZOPro49aFa/qQFyQQOp 1kuHt1pC/qLyD76+Uy6nBw6/0K9Dyz5UlroMxsAOoSbnjw+wgRSE7vnvAJuuJya8tAQS p6dlKOYhtrQjr02pSviShL0b0xpii6wmO5OXpv5Igl33OVfTH2NtRcJ3NaSJFKodPjnd IPDqZ527/+Iq9Oxu1FemBk4csj4NLgaRMlgxgQcxXL/AwYByBIEt63AKMyYFZKuS53RK EzGg== X-Gm-Message-State: ALQs6tCYFwkl2yBPC9euvhu4IE025OIlAcxLW4qCbc2RbgCbFNOPD4nD V42HEvXOjGcA0vmsU2ne8MVb4A== X-Google-Smtp-Source: AIpwx4/y1+oFdKr9S+fvzLQ43WGCC6bIlNgVDcRZKcysKEFVopgCd+tusu0cVDVyMdxmX18ykArrZA== X-Received: by 10.28.217.67 with SMTP id q64mr2367501wmg.12.1524238397298; Fri, 20 Apr 2018 08:33:17 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b5-v6sm6167849wrf.40.2018.04.20.08.33.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Apr 2018 08:33:15 -0700 (PDT) Date: Fri, 20 Apr 2018 16:33:14 +0100 From: Leif Lindholm To: Meenakshi Cc: ard.biesheuvel@linaro.org, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com, Vabhav Message-ID: <20180420153314.a2bpppacu5bjxdya@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1518771035-6733-39-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1518771035-6733-39-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 38/39] Platform/NXP:PCIe enablement for LS1046A RDB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 15:33:19 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 16, 2018 at 02:20:34PM +0530, Meenakshi wrote: > From: Vabhav > > Compilation: Update the fdf, dsc and dec files. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > --- > Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc | 15 +++++++++++++++ > Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf | 9 +++++++++ > .../LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf | 2 ++ > .../NXP/LS1046aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c | 6 ++++++ > Silicon/NXP/LS1046A/LS1046A.dsc | 3 +++ > 5 files changed, 35 insertions(+) > > diff --git a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc > index 36002d5..231207d 100644 > --- a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc > +++ b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc > @@ -41,6 +41,8 @@ > IfcLib|Silicon/NXP/Library/IfcLib/IfcLib.inf > BoardLib|Platform/NXP/LS1046aRdbPkg/Library/BoardLib/BoardLib.inf > FpgaLib|Platform/NXP/LS1046aRdbPkg/Library/FpgaLib/FpgaLib.inf > + PciSegmentLib|Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.inf > + PciHostBridgeLib|Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf > > [PcdsFixedAtBuild.common] > > @@ -65,6 +67,7 @@ > gNxpQoriqLsTokenSpaceGuid.PcdGurBigEndian|TRUE > gNxpQoriqLsTokenSpaceGuid.PcdWdogBigEndian|TRUE > gNxpQoriqLsTokenSpaceGuid.PcdIfcBigEndian|TRUE > + gNxpQoriqLsTokenSpaceGuid.PcdPciLutBigEndian|TRUE > > # > # I2C controller Pcds > @@ -77,6 +80,12 @@ > gNxpQoriqLsTokenSpaceGuid.PcdI2cSlaveAddress|0x51 > gNxpQoriqLsTokenSpaceGuid.PcdI2cSpeed|100000 > > + # > + # PCI PCDs. > + # > + gNxpQoriqLsTokenSpaceGuid.PcdPciDebug|FALSE > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutBase|0x80000 > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutDbg|0x407FC > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -90,5 +99,11 @@ > > Silicon/NXP/Drivers/WatchDog/WatchDogDxe.inf > Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > + Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf > + MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { > + > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8010004F > + } > + MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > > ## > diff --git a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf > index 834e3a4..3351a06 100644 > --- a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf > +++ b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf > @@ -123,6 +123,13 @@ READ_LOCK_STATUS = TRUE > INF EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOutSerial.inf > > # > + # PCI > + # > + INF Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf > + INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > + INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + > + # > # Network modules > # > INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > @@ -147,6 +154,8 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > !endif > > + INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > + Same comment as for previous platform(s): please conditionalise and mention in commit message. / Leif > # > # FAT filesystem + GPT/MBR partitioning > # > diff --git a/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf b/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > index 49b57fc..5e09757 100644 > --- a/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > +++ b/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > @@ -42,6 +42,8 @@ > gArmTokenSpaceGuid.PcdArmPrimaryCore > gNxpQoriqLsTokenSpaceGuid.PcdCcsrBaseAddr > gNxpQoriqLsTokenSpaceGuid.PcdCcsrSize > + gNxpQoriqLsTokenSpaceGuid.PcdRomBaseAddr > + gNxpQoriqLsTokenSpaceGuid.PcdRomSize > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion1BaseAddr > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion1Size > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion2BaseAddr > diff --git a/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c b/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > index 64c5612..1ef3292 100644 > --- a/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > +++ b/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > @@ -67,6 +67,12 @@ ArmPlatformGetVirtualMemoryMap ( > VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdCcsrSize); > VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > > + // ROM Space > + VirtualMemoryTable[++Index].PhysicalBase = FixedPcdGet64 (PcdRomBaseAddr); > + VirtualMemoryTable[Index].VirtualBase = FixedPcdGet64 (PcdRomBaseAddr); > + VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdRomSize); > + VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > + > // IFC region 1 > // > // A-009241 : Unaligned write transactions to IFC may result in corruption of data > diff --git a/Silicon/NXP/LS1046A/LS1046A.dsc b/Silicon/NXP/LS1046A/LS1046A.dsc > index 9f87028..59a6150 100644 > --- a/Silicon/NXP/LS1046A/LS1046A.dsc > +++ b/Silicon/NXP/LS1046A/LS1046A.dsc > @@ -64,5 +64,8 @@ > gNxpQoriqLsTokenSpaceGuid.PcdQspiRegionBaseAddr|0x40000000 > gNxpQoriqLsTokenSpaceGuid.PcdQspiRegionSize|0x20000000 > gNxpQoriqLsTokenSpaceGuid.PcdIfcBaseAddr|0x1530000 > + gNxpQoriqLsTokenSpaceGuid.PcdNumPciController|3 > + gNxpQoriqLsTokenSpaceGuid.PcdRomBaseAddr|0x00000000 > + gNxpQoriqLsTokenSpaceGuid.PcdRomSize|0x00100000 > > ## > -- > 1.9.1 >