From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 01B0621EBD1DB for ; Fri, 20 Apr 2018 08:36:12 -0700 (PDT) Received: by mail-wr0-x243.google.com with SMTP id v60-v6so24088672wrc.7 for ; Fri, 20 Apr 2018 08:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ynqB0+KNGM8k3Qztt2wh+Ri3n7MV96ZKLASXH5fqAAs=; b=Bi1rZrNxEbpeAKiJwQWni6sUGZNlCvaJxbBrRBIMtV8rNDwp3fEXELX7rJ3InG4/Va wGKScJFYAYJ/uUVHCnXs6Z30y+DBq6eIlDc9WXotphfrJEvqD/y56rvXTn5lmn96bLZy 9pQY26hgI9QglWm6Ic/EwWlI6stGFP/U0WZ7o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ynqB0+KNGM8k3Qztt2wh+Ri3n7MV96ZKLASXH5fqAAs=; b=D2OCP4RdjMGs6M/Mj1YsBnKlYU5FhC4PWsF3/f8qsWNa9jGur1SzrHKkqJrzRxTf7M 5cIjrG1ajQfsYksD7v8WJ9YfWz5naUhUYa4AZy0tI6C4VYERu2ZCvt1s5JktOdrul2OC 5R80zQgE2SL9fB6F99xyZJXYeiHHNtYX5gJ4u4TwG1FtRJTSWoW1cHYOjnzt52ygVNvB jHaUofPFJo4Lq1baEfw1IWAATUdI7vzGQV9nd7dHOncbC9Fwjrx6/lTBJHRF/0gJ3SeJ g5m3F7INQ9rpQUvsjqrLOidUA0ojsQd6FwtojV4GbOAxZuXzfAqX0gYxXfrqnvLq5zTo FaFw== X-Gm-Message-State: ALQs6tC8iq4+jzQ7nwS3J0UO7IWQdj0iQC1HgTux0d8Tw6YClcpUmZ06 N11N0UO8eq1BEIILErnLuYqEAg== X-Google-Smtp-Source: AIpwx495zxCHxxf68auZgZmqRnAUlYsDtJxHuVDmEGWWFGIcF+/MrkNH9WeU+t6ojYBnITjBpm+PMA== X-Received: by 2002:adf:860d:: with SMTP id 13-v6mr6171266wrv.12.1524238571217; Fri, 20 Apr 2018 08:36:11 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a129sm3767509wme.3.2018.04.20.08.36.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Apr 2018 08:36:10 -0700 (PDT) Date: Fri, 20 Apr 2018 16:36:08 +0100 From: Leif Lindholm To: Meenakshi Cc: ard.biesheuvel@linaro.org, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com, Vabhav Message-ID: <20180420153608.rkicsycfguc5ap4f@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1518771035-6733-40-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1518771035-6733-40-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 39/39] Platform/NXP:PCIe enablement for LS2088A RDB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 15:36:13 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 16, 2018 at 02:20:35PM +0530, Meenakshi wrote: > From: Vabhav > > Compilation: Update the fdf, dsc and dec files. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > --- > Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc | 17 +++++++++++++++++ > Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf | 9 +++++++++ > .../Library/PlatformLib/ArmPlatformLib.inf | 2 ++ > .../LS2088aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c | 6 ++++++ > Silicon/NXP/LS2088A/LS2088A.dsc | 3 +++ > 5 files changed, 37 insertions(+) > > diff --git a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > index 4d32ea5..1ae55d4 100755 > --- a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > +++ b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > @@ -43,6 +43,8 @@ > BoardLib|Platform/NXP/LS2088aRdbPkg/Library/BoardLib/BoardLib.inf > FpgaLib|Platform/NXP/LS2088aRdbPkg/Library/FpgaLib/FpgaLib.inf > NorFlashLib|Silicon/NXP/Library/NorFlashLib/NorFlashLib.inf > + PciSegmentLib|Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.inf > + PciHostBridgeLib|Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf > > [PcdsFixedAtBuild.common] > > @@ -97,6 +99,13 @@ > gNxpQoriqLsTokenSpaceGuid.PcdFlashDeviceBase64|0x580000000 > gNxpQoriqLsTokenSpaceGuid.PcdFlashReservedRegionBase64|0x580300000 > > + # > + # PCI PCDs. > + # > + gNxpQoriqLsTokenSpaceGuid.PcdPciDebug|FALSE > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutBase|0x80000 > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutDbg|0x407FC > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -115,3 +124,11 @@ > Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf > + Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf > + MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { > + > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8010004F > + } > + MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + > + ## > diff --git a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf > index 8688d85..35a79bd 100644 > --- a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf > +++ b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf > @@ -127,6 +127,13 @@ READ_LOCK_STATUS = TRUE > INF Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > > # > + # PCI > + # > + INF Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf > + INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > + INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + > + # > # Network modules > # > INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > @@ -153,6 +160,8 @@ READ_LOCK_STATUS = TRUE > > INF MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.inf > > + INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > + Same comment as previously platforms: please conditionalise and mention in commit message. (Please add some detail to commit message in general about what is being enabled.) / Leif > # > # USB Support > # > diff --git a/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf b/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > index f5e5abd..0b836a8 100644 > --- a/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > +++ b/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > @@ -44,6 +44,8 @@ > gArmTokenSpaceGuid.PcdArmPrimaryCore > gNxpQoriqLsTokenSpaceGuid.PcdCcsrBaseAddr > gNxpQoriqLsTokenSpaceGuid.PcdCcsrSize > + gNxpQoriqLsTokenSpaceGuid.PcdRomBaseAddr > + gNxpQoriqLsTokenSpaceGuid.PcdRomSize > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion1BaseAddr > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion1Size > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion2BaseAddr > diff --git a/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c b/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > index ccb49f6..8b2145b 100644 > --- a/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > +++ b/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > @@ -80,6 +80,12 @@ ArmPlatformGetVirtualMemoryMap ( > VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdCcsrSize); > VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > > + // ROM Space > + VirtualMemoryTable[++Index].PhysicalBase = FixedPcdGet64 (PcdRomBaseAddr); > + VirtualMemoryTable[Index].VirtualBase = FixedPcdGet64 (PcdRomBaseAddr); > + VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdRomSize); > + VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > + > // IFC region 1 > // > // A-009241 : Unaligned write transactions to IFC may result in corruption of data > diff --git a/Silicon/NXP/LS2088A/LS2088A.dsc b/Silicon/NXP/LS2088A/LS2088A.dsc > index 0d8fd82..831edea 100644 > --- a/Silicon/NXP/LS2088A/LS2088A.dsc > +++ b/Silicon/NXP/LS2088A/LS2088A.dsc > @@ -69,5 +69,8 @@ > gNxpQoriqLsTokenSpaceGuid.PcdNumI2cController|4 > gNxpQoriqLsTokenSpaceGuid.PcdIfcBaseAddr|0x02240000 > gNxpQoriqLsTokenSpaceGuid.PcdNumUsbController|2 > + gNxpQoriqLsTokenSpaceGuid.PcdNumPciController|4 > + gNxpQoriqLsTokenSpaceGuid.PcdRomBaseAddr|0x00000000 > + gNxpQoriqLsTokenSpaceGuid.PcdRomSize|0x00100000 > > ## > -- > 1.9.1 >