From: Leif Lindholm <leif.lindholm@linaro.org>
To: Girish Pathak <girish.pathak@arm.com>
Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org,
Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com,
nd@arm.com, Arvind.Chauhan@arm.com, Daniil.Egranov@arm.com,
thomas.abraham@arm.com, evan.lloyd@arm.com
Subject: Re: [PATCH edk2-platforms v4 00/17] Update GOP
Date: Mon, 23 Apr 2018 14:00:49 +0100 [thread overview]
Message-ID: <20180423130048.lxoirvicllv5vaf6@bivouac.eciton.net> (raw)
In-Reply-To: <20180405180803.33684-1-girish.pathak@arm.com>
For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Not pushed yet due to dependencies on the corresponding edk2 set.
Evan: since you already have Signed-off-by on all of the patches, I
don't intend to add your Reviewed-by as well (I did see them).
On Thu, Apr 05, 2018 at 07:07:46PM +0100, Girish Pathak wrote:
> This patch series addresses comments on the patch v3
> (https://lists.01.org/pipermail/edk2-devel/2018-March/023015.html)
> reworking of the Graphics Output Protocol code in ArmPlatformPkg.
> It also contains updates for the new SCMI protocol (MTL Library).
>
> Code is available for examination at:
> https://github.com/girishpathak/edk2-platforms/tree/201_gop_v4
>
> Ard Biesheuvel (1):
> ARM/VExpressPkg: Fix MODULE_TYPE of HDLCD/PL111 platform libraries
>
> EvanLloyd (2):
> ARM/VExpressPkg: HdLcdArmVExpressLib: Remove redundant Bpp
> ARM/VExpressPkg: Redefine LcdPlatformGetTimings function
>
> Girish Pathak (14):
> ARM/VExpressPkg: Tidy HDLCD and PL11LCD platform Lib: Coding standard
> ARM/VExpressPkg: Tidy HdLcd/PL111Lcd code: Updated comments
> ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf
> ARM/VExpressPkg: Add and update debug ASSERTS
> ARM/VExpressPkg: PL111Lcd/HdLcd plaform libs: Minor code cleanup
> ARM/VExpressPkg: PL111 and HDLCD: Use FixedPcdGet32
> ARM/VExpressPkg: HdLcdArmVExpressLib: Remove status check EFI_TIMEOUT
> ARM/VExpressPkg: PL111 and HDLCD: Add PCD to select pixel format
> ARM/VExpressPkg: Allocate framebuffer using EfiReservedMemoryType
> ARM/VExpressPkg: Reserving framebuffer at build
> ARM/VExpressPkg: Set EFI_MEMORY_XP flag on GOP framebuffer
> ARM/VExpressPkg: New DP500/DP550/DP650 platform library
> ARM/JunoPkg: Adding SCMI MTL library
> ARM/JunoPkg: Add HDLCD platform library
>
> Platform/ARM/JunoPkg/ArmJuno.dec | 17 +-
> Platform/ARM/JunoPkg/ArmJuno.dsc | 31 +-
> Platform/ARM/JunoPkg/ArmJuno.fdf | 12 +-
> Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf | 5 +-
> Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c | 29 +-
> Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlLib.c | 198 +++++++
> Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlLib.inf | 39 ++
> Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlPrivateLib.h | 94 ++++
> Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c | 555 ++++++++++++++++++++
> Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJunoLib.inf | 41 ++
> Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 3 +-
> Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.c | 387 ++++++++++++++
> Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.inf | 43 ++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 7 +-
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c | 53 +-
> Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 310 +++++++----
> Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf | 14 +-
> Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 389 +++++++++-----
> Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf | 10 +-
> 19 files changed, 1945 insertions(+), 292 deletions(-)
> create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlLib.c
> create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlLib.inf
> create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlPrivateLib.h
> create mode 100644 Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c
> create mode 100644 Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJunoLib.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.inf
>
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
prev parent reply other threads:[~2018-04-23 13:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 18:07 [PATCH edk2-platforms v4 00/17] Update GOP Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 01/17] ARM/VExpressPkg: Fix MODULE_TYPE of HDLCD/PL111 platform libraries Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 02/17] ARM/VExpressPkg: Tidy HDLCD and PL11LCD platform Lib: Coding standard Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 03/17] ARM/VExpressPkg: Tidy HdLcd/PL111Lcd code: Updated comments Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf Girish Pathak
2018-04-23 17:03 ` Leif Lindholm
2018-04-23 17:07 ` Girish Pathak
2018-04-23 17:10 ` Leif Lindholm
2018-04-05 18:07 ` [PATCH edk2-platforms v4 05/17] ARM/VExpressPkg: Add and update debug ASSERTS Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 06/17] ARM/VExpressPkg: PL111Lcd/HdLcd plaform libs: Minor code cleanup Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 07/17] ARM/VExpressPkg: PL111 and HDLCD: Use FixedPcdGet32 Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 08/17] ARM/VExpressPkg: HdLcdArmVExpressLib: Remove status check EFI_TIMEOUT Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 09/17] ARM/VExpressPkg: HdLcdArmVExpressLib: Remove redundant Bpp Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 10/17] ARM/VExpressPkg: Redefine LcdPlatformGetTimings function Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 11/17] ARM/VExpressPkg: PL111 and HDLCD: Add PCD to select pixel format Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 12/17] ARM/VExpressPkg: Allocate framebuffer using EfiReservedMemoryType Girish Pathak
2018-04-05 18:07 ` [PATCH edk2-platforms v4 13/17] ARM/VExpressPkg: Reserving framebuffer at build Girish Pathak
2018-04-05 18:08 ` [PATCH edk2-platforms v4 14/17] ARM/VExpressPkg: Set EFI_MEMORY_XP flag on GOP framebuffer Girish Pathak
2018-04-05 18:08 ` [PATCH edk2-platforms v4 15/17] ARM/VExpressPkg: New DP500/DP550/DP650 platform library Girish Pathak
2018-04-05 18:08 ` [PATCH edk2-platforms v4 16/17] ARM/JunoPkg: Adding SCMI MTL library Girish Pathak
2018-04-05 18:08 ` [PATCH edk2-platforms v4 17/17] ARM/JunoPkg: Add HDLCD platform library Girish Pathak
2018-04-23 13:00 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423130048.lxoirvicllv5vaf6@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox