From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED3612277AF1A for ; Mon, 23 Apr 2018 06:00:53 -0700 (PDT) Received: by mail-wr0-x242.google.com with SMTP id v15-v6so22926664wrm.10 for ; Mon, 23 Apr 2018 06:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TwkZ/bJAFGZvtjW/lHvJtKFRH4tz4CHcpxHuAKWs/l0=; b=PyS1YEViPD2TsXTeiuZP8/nFIoDx7+HI6u1HagmIRMoeH+fQ+H+KgE6qonKQKme8tt DQKFgTVOfDD0ehCrSaHx51JoOcoFx3NOXMci5fT5qYdaRMAy5/J2uecpq7JDUdZi+sCK LWy5q4Btc4EF6rK2cWHmOCe+XpD9yj5/ufsDw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TwkZ/bJAFGZvtjW/lHvJtKFRH4tz4CHcpxHuAKWs/l0=; b=h0Zc5kpAndSd3URWC4+ApavHTeSV9r6T6F5A+TI3rZrvY3Bcn7q3ylfcQBc5hh9iql qv0lUyYIkAr+yVAzeN8g0Jk7PNhVOcoZHd4MOnF+Uj8VMK5TTT+2f+Gn7CfmvrLtow6F C7TeG1b1n/7KZh24MgrPQvZWL0/3dAFnovQnKDk5DXHzzR8yu6TGzQSPQtPOTK2eBYWM urqGDhdxI9ZJ13hcK+sHxMaKreaPkNr7k9OMVZjFZbpR/sh8HSsRHZbpRouvVdUVFm8E btL8mWcaPbF1ebfZ2IQP6SB5NZrd7uDc3OhAJdGdnBB6OfgiSpkBtFfdmrhHgYrRTqYd eqOQ== X-Gm-Message-State: ALQs6tDGn/gMPSu/pvkId5ogvYa5sJ5gM7yWosaASsPz/2EXH05dj5jl aRGwBVGcil8K3pBqB8BNy3evrA== X-Google-Smtp-Source: AIpwx48sAYZHaglhidk6rJQ46Q3TyDNwx92vkIvY/EJVw1ZFX2eOc1xdLNnS87DvF0FVcAa9n0RsUw== X-Received: by 10.28.87.73 with SMTP id l70mr10126696wmb.123.1524488451978; Mon, 23 Apr 2018 06:00:51 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id k30-v6sm31786153wrf.1.2018.04.23.06.00.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 06:00:50 -0700 (PDT) Date: Mon, 23 Apr 2018 14:00:49 +0100 From: Leif Lindholm To: Girish Pathak Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com, Arvind.Chauhan@arm.com, Daniil.Egranov@arm.com, thomas.abraham@arm.com, evan.lloyd@arm.com Message-ID: <20180423130048.lxoirvicllv5vaf6@bivouac.eciton.net> References: <20180405180803.33684-1-girish.pathak@arm.com> MIME-Version: 1.0 In-Reply-To: <20180405180803.33684-1-girish.pathak@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v4 00/17] Update GOP X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 13:00:54 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline For the series: Reviewed-by: Leif Lindholm Not pushed yet due to dependencies on the corresponding edk2 set. Evan: since you already have Signed-off-by on all of the patches, I don't intend to add your Reviewed-by as well (I did see them). On Thu, Apr 05, 2018 at 07:07:46PM +0100, Girish Pathak wrote: > This patch series addresses comments on the patch v3 > (https://lists.01.org/pipermail/edk2-devel/2018-March/023015.html) > reworking of the Graphics Output Protocol code in ArmPlatformPkg. > It also contains updates for the new SCMI protocol (MTL Library). > > Code is available for examination at: > https://github.com/girishpathak/edk2-platforms/tree/201_gop_v4 > > Ard Biesheuvel (1): > ARM/VExpressPkg: Fix MODULE_TYPE of HDLCD/PL111 platform libraries > > EvanLloyd (2): > ARM/VExpressPkg: HdLcdArmVExpressLib: Remove redundant Bpp > ARM/VExpressPkg: Redefine LcdPlatformGetTimings function > > Girish Pathak (14): > ARM/VExpressPkg: Tidy HDLCD and PL11LCD platform Lib: Coding standard > ARM/VExpressPkg: Tidy HdLcd/PL111Lcd code: Updated comments > ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf > ARM/VExpressPkg: Add and update debug ASSERTS > ARM/VExpressPkg: PL111Lcd/HdLcd plaform libs: Minor code cleanup > ARM/VExpressPkg: PL111 and HDLCD: Use FixedPcdGet32 > ARM/VExpressPkg: HdLcdArmVExpressLib: Remove status check EFI_TIMEOUT > ARM/VExpressPkg: PL111 and HDLCD: Add PCD to select pixel format > ARM/VExpressPkg: Allocate framebuffer using EfiReservedMemoryType > ARM/VExpressPkg: Reserving framebuffer at build > ARM/VExpressPkg: Set EFI_MEMORY_XP flag on GOP framebuffer > ARM/VExpressPkg: New DP500/DP550/DP650 platform library > ARM/JunoPkg: Adding SCMI MTL library > ARM/JunoPkg: Add HDLCD platform library > > Platform/ARM/JunoPkg/ArmJuno.dec | 17 +- > Platform/ARM/JunoPkg/ArmJuno.dsc | 31 +- > Platform/ARM/JunoPkg/ArmJuno.fdf | 12 +- > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf | 5 +- > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c | 29 +- > Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlLib.c | 198 +++++++ > Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlLib.inf | 39 ++ > Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlPrivateLib.h | 94 ++++ > Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c | 555 ++++++++++++++++++++ > Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJunoLib.inf | 41 ++ > Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 3 +- > Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.c | 387 ++++++++++++++ > Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.inf | 43 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 7 +- > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c | 53 +- > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 310 +++++++---- > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf | 14 +- > Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 389 +++++++++----- > Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf | 10 +- > 19 files changed, 1945 insertions(+), 292 deletions(-) > create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlLib.c > create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlLib.inf > create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoMtlLib/ArmJunoMtlPrivateLib.h > create mode 100644 Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c > create mode 100644 Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJunoLib.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.inf > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >