From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::233; helo=mail-wr0-x233.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x233.google.com (mail-wr0-x233.google.com [IPv6:2a00:1450:400c:c0c::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3DD482277AF30 for ; Mon, 23 Apr 2018 10:03:15 -0700 (PDT) Received: by mail-wr0-x233.google.com with SMTP id s18-v6so43251564wrg.9 for ; Mon, 23 Apr 2018 10:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EF08xg3RQ8A2dQLT8NgCmrhcsGBVbuGqxOc/Rh84aKk=; b=JgutoSISloS66KX5Gi4sTvVYxTUoAHwtnJXzxB8FU1DKkaZID4bnya5psCsfth0e4k bYce7sNSZHElO0VpWtAqyi2728B3zBPZ8QGQnTbsUNqXaW2OQxLWDu1FsHI3wH7yYvcN vAMZZHr8eXxBWWJUSf0BK6w/9KEAsuN3LNOFw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EF08xg3RQ8A2dQLT8NgCmrhcsGBVbuGqxOc/Rh84aKk=; b=k74QNLuAJIjxFXFEkDQ/jktOB4aa8Bk3GlDTiWdg22XoQQjnJUdx+wgn/2aX46il2n L9Apih/1Cr5B37bcPwCdNKK/HB05RWEVZ2Stk5P6xtL0NnWQ1S8urd5xfD/x/0oJRbRW mUxwbK4Uaf5bH6JyzXbLguArgs25aSAqXoRXV/uScwryaOv9muG0pjBIIDIejp8bamPp wI1+SAFXvziqYEnkmoY0qM/G6/MzOQagt/3lKkkL51RIj37+fpYFqOUJz1xSrC3kxwah Rr/GBR9hHEEvmXdoKE3Ref0wBUTsmoF2c7Y7+ZMmOnsSoY5NswRt9DYCjOQRFBP3W6kC KaKA== X-Gm-Message-State: ALQs6tAXWG8m0vxkYeousFBmbm9gxqmQznTmlsMH5aIEB5VXO0rXaWZy 7DVhEFlPFMH3H4zcrvNY7K/MYA== X-Google-Smtp-Source: AIpwx4//jX54vkgxLQmFr1lsVYcphj2LGAurFyY8s8Trksf+I9oLIwtJGZQS0hUCjGXIOhP0UKvuLw== X-Received: by 2002:adf:ba50:: with SMTP id t16-v6mr14848192wrg.237.1524502993765; Mon, 23 Apr 2018 10:03:13 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u35-v6sm19299522wrc.29.2018.04.23.10.03.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 10:03:12 -0700 (PDT) Date: Mon, 23 Apr 2018 18:03:10 +0100 From: Leif Lindholm To: Girish Pathak Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com, Arvind.Chauhan@arm.com, Daniil.Egranov@arm.com, thomas.abraham@arm.com Message-ID: <20180423170310.gox5mgxwu4bsflpk@bivouac.eciton.net> References: <20180405180803.33684-1-girish.pathak@arm.com> <20180405180803.33684-5-girish.pathak@arm.com> MIME-Version: 1.0 In-Reply-To: <20180405180803.33684-5-girish.pathak@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 17:03:15 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 05, 2018 at 07:07:50PM +0100, Girish Pathak wrote: > PCD PcdPL111LcdMaxMode is not used in HDLCD platform library. > Presence of this PCD in HDLCD is probably due to copy/paste code > from PL111 Lcd platform library. This change removes it from > the HdLcdArmVExpressLib.inf file. > > Contributed-under: TianoCore Contribution Agreement 1.0 Urgh - push failed on the above. Can you confirm it should be version 1.1? / Leif > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > Reviewed-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > index bedbaea3a296bea5184564c582659381733d08a9..34db24d4ee6162b0e963d500a8ed1097bd8a5ceb 100644 > --- a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > +++ b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > @@ -40,5 +40,4 @@ [Protocols] > gEfiEdidActiveProtocolGuid # Produced > > [Pcd] > - gArmVExpressTokenSpaceGuid.PcdPL111LcdMaxMode > gArmVExpressTokenSpaceGuid.PcdHdLcdVideoModeOscId > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >