From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8E97422839315 for ; Mon, 23 Apr 2018 10:10:34 -0700 (PDT) Received: by mail-wr0-x241.google.com with SMTP id q3-v6so33324364wrj.6 for ; Mon, 23 Apr 2018 10:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WiV7wxzU11XEDMy1NUZMC4IjKmqe7rnVfv7qVcDGMYA=; b=jmP/yzbqoNbC9Fcgog3ZYp2BYP0w/Cm0EXeuROalIT9DesxXIlNZLkBxFKes6Zcuvi lU/LW/Ss2gF6yh5A7dtldaw6aK4CJmNuU73nthn4IwrVSDU+DxtvRVKNnSbambek6Vq8 KjMtP42zW0BXH+GdrzidcOS4dv4Sp3mLE9kmk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WiV7wxzU11XEDMy1NUZMC4IjKmqe7rnVfv7qVcDGMYA=; b=HIz9+6kD684+NWTP1VbnkXxgbyq1PaXoo26oCVser7RzXZErYlAlOLZjLexIygc+uE 5ac7UX0LRUSmpgMQyfh9lF2VaUPajpVP3gDS6OWJ3MbRW6xR0sKoSxJ5BVcF4s/aXMW0 KrmFvIC5Mr/bSmmtnAPBVsw12sVciClAliL9Ob0lEbX/I2JPsIdAWCZDeqT0MQ7ZLloc 0NnkXmSVJwZaPK2Mb4oxpZe0GE4ytGjCtQutZD49fiWmQWcBnXKs3gLDjz0/00yxDimW MlPv1YUM7nb4jyWmMTodRgdsxMQq+oq5i3EMLRPXf4akPrxVOySXGUpK7mJ9LJmM1oQR SNpw== X-Gm-Message-State: ALQs6tB643grtP6Tikv8xIVVBnuDUSQYmDpv1DJ/cr3Yy6j0nPcCay5Y Q8OfgUCAWykEv3e4653mO5MwCQ== X-Google-Smtp-Source: AB8JxZovXNeo/K/E2CvwYb8FWIf8H8RN6Md8T6UKTLnlUBAVgyZq91QXng48Qio0uBWazh58Nb1y/g== X-Received: by 10.28.135.149 with SMTP id j143mr843031wmd.149.1524503432956; Mon, 23 Apr 2018 10:10:32 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 58-v6sm27571045wrv.41.2018.04.23.10.10.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 10:10:31 -0700 (PDT) Date: Mon, 23 Apr 2018 18:10:30 +0100 From: Leif Lindholm To: Girish Pathak Cc: "edk2-devel@lists.01.org" , "ard.biesheuvel@linaro.org" , Matteo Carlini , Stephanie Hughes-Fitt , nd , Arvind Chauhan , Daniil Egranov , Thomas Abraham Message-ID: <20180423171030.tkhqgnxc3rrxxyjq@bivouac.eciton.net> References: <20180405180803.33684-1-girish.pathak@arm.com> <20180405180803.33684-5-girish.pathak@arm.com> <20180423170310.gox5mgxwu4bsflpk@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 17:10:35 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 23, 2018 at 05:07:02PM +0000, Girish Pathak wrote: > Hi Leif, > > > -----Original Message----- > > From: Leif Lindholm > > Sent: 23 April 2018 18:03 > > To: Girish Pathak > > Cc: edk2-devel@lists.01.org; ard.biesheuvel@linaro.org; Matteo Carlini > > ; Stephanie Hughes-Fitt > Fitt@arm.com>; nd ; Arvind Chauhan > > ; Daniil Egranov ; > > Thomas Abraham > > Subject: Re: [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove > > unused PcdPL111LcdMaxMode from HDLCD inf > > > > On Thu, Apr 05, 2018 at 07:07:50PM +0100, Girish Pathak wrote: > > > PCD PcdPL111LcdMaxMode is not used in HDLCD platform library. > > > Presence of this PCD in HDLCD is probably due to copy/paste code from > > > PL111 Lcd platform library. This change removes it from the > > > HdLcdArmVExpressLib.inf file. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > > Urgh - push failed on the above. > > Can you confirm it should be version 1.1? > Oops.. Sorry my fault. It should be 1.1 Well, it made it past everyone except for my pre-push hook script... Thanks - series: Reviewed-by: Leif Lindholm Pushed as 0b5af57f00..b581a4934d. Regards, Leif > Thanks, > Girish > > / > > Leif > > > > > Signed-off-by: Girish Pathak > > > Signed-off-by: Evan Lloyd > > > Reviewed-by: Ard Biesheuvel > > > --- > > > > > > > > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpr > > essL > > > ib.inf | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git > > > > > a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > > pres > > > sLib.inf > > > > > b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > > pres > > > sLib.inf index > > > > > bedbaea3a296bea5184564c582659381733d08a9..34db24d4ee6162b0e963d50 > > 0a8ed > > > 1097bd8a5ceb 100644 > > > --- > > > > > a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > > pres > > > sLib.inf > > > +++ > > b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > > > +++ pressLib.inf > > > @@ -40,5 +40,4 @@ [Protocols] > > > gEfiEdidActiveProtocolGuid # Produced > > > > > > [Pcd] > > > - gArmVExpressTokenSpaceGuid.PcdPL111LcdMaxMode > > > gArmVExpressTokenSpaceGuid.PcdHdLcdVideoModeOscId > > > -- > > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > > >